[Bug 21597] New: Test suite is still failing with new default SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Bug ID: 21597 Summary: Test suite is still failing with new default SQL modes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 20521, 20144 We pushed bug 20521 to enable the problematic SQL modes for dev installs, and now new tests (since bug 20144 has been pushed) are failing. Let's fix them again. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 [Bug 20144] Test suite is failing with new default SQL modes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 [Bug 20521] dev installations should run with problematic SQL modes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris@bigballofwax.co.nz |jonathan.druart@bugs.koha-c | |ommunity.org Summary|Test suite is still failing |[OMNIBUS] Test suite is |with new default SQL modes |still failing with new | |default SQL modes --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This will be an omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Bug 21593 - Remove Group by clause in GetAuthValueDropbox 'koha_kohadev.me.id' isn't in GROUP BY -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21598, 21593 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Bug 21598 - budget_parent_id isn't in GROUP BY - GetBudgetHierarchy Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 [Bug 21593] Remove Group by clause in GetAuthValueDropbox https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21598 [Bug 21598] budget_parent_id isn't in GROUP BY - GetBudgetHierarchy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21599 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Bug 21599 - Incorrect decimal value: '' for column 'defaultreplacecost' - Cannot create item type Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21599 [Bug 21599] Incorrect decimal value: '' for column 'defaultreplacecost' - Cannot create item type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21596 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Bug 21596 - Should not set "" as default for some columns during patron import Patron import is failing, as well as the tests t/db_dependent/Koha/Patrons/Import.t Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21596 [Bug 21596] Should not set "" as default for some columns during patron import -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[OMNIBUS] Test suite is |Test suite is still failing |still failing with new |with new default SQL modes |default SQL modes | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The previous bug reports are fixing bugs found by tests but impacting the interface. I am going to submit here the fixes for the tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80812&action=edit Bug 21597: Column 'notforloan' cannot be null Fix t/db_dependent/Circulation.t items.notforloan: `notforloan` tinyint(1) NOT NULL DEFAULT '0', t/db_dependent/Circulation.t .. 115/119 DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. # No tests run! # Failed test 'No tests run for subtest "item-level_itypes = 0"' # at t/db_dependent/Circulation.t line 2356. # Looks like you failed 1 test of 2. # Failed test 'CanBookBeIssued | notforloan' # at t/db_dependent/Circulation.t line 2359. Can't locate object method "rethrow" via package "DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80813&action=edit Bug 21597: Field 'amount' doesn't have a default value Fix t/db_dependent/Accounts.t Default value could be 0, or left as it. It seems that the different initialisation we have in the code pass a value for 'amount' account_offsets.amount `amount` decimal(26,6) NOT NULL, DBIx::Class::Storage::DBI::_dbh_execute(): Field 'amount' doesn't have a default value at /home/vagrant/kohaclone/Koha/Object.pm line 125 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80814&action=edit Bug 21597: Data too long for column 'invitekey' Fix t/db_dependent/Virtualshelves.t virtualshelfshares.invitekey `invitekey` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL, We should not insert a longer string! DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column 'invitekey' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 125 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80815&action=edit Bug 21597: Incorrect date value: '0' for column 'onloan' Fix t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t items.onloan `onloan` date DEFAULT NULL, DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect date value: '0' for column 'onloan' at row 1 at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 288 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80816&action=edit Bug 21597: Field 'description' doesn't have a default value Nick proposed another fix, see bug 21594. The interface does not explode so I do not think we should make a DB update in a rush. Fix t/db_dependent/Koha/Object.t and t/db_dependent/Koha/ApiKeys.t api_keys.description and api_keys.secret: `secret` varchar(191) COLLATE utf8mb4_unicode_ci NOT NULL, `description` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL, # Failed test 'Exception is thrown correctly' # at t/db_dependent/Koha/Object.t line 262. # expecting: Koha::Exceptions::Object::FKConstraint # found: DBIx::Class::Exception (DBIx::Class::Storage::DBI::_dbh_execute(): Field 'description' doesn't have a default value at /home/vagrant/kohaclone/Koha/Object.pm line 125 # ) # Looks like you planned 7 tests but ran 1. # Looks like you failed 1 test of 1 run. and later, but not related: Can't locate object method "message" via package "DBIx::Class::Exception" at t/db_dependent/Koha/Object.t line 264. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80821&action=edit Bug 21597: Incorrect decimal value: 't_value_bib639' for column 'price' Fix t/db_dependent/selenium/basic_workflow.t We want to send specific values depending on the data type in DB For instance integer, or varchar(10) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ready for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80812|0 |1 is obsolete| | Attachment #80813|0 |1 is obsolete| | Attachment #80814|0 |1 is obsolete| | Attachment #80815|0 |1 is obsolete| | Attachment #80816|0 |1 is obsolete| | Attachment #80821|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 80829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80829&action=edit Bug 21597: Column 'notforloan' cannot be null Fix t/db_dependent/Circulation.t items.notforloan: `notforloan` tinyint(1) NOT NULL DEFAULT '0', t/db_dependent/Circulation.t .. 115/119 DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. # No tests run! # Failed test 'No tests run for subtest "item-level_itypes = 0"' # at t/db_dependent/Circulation.t line 2356. # Looks like you failed 1 test of 2. # Failed test 'CanBookBeIssued | notforloan' # at t/db_dependent/Circulation.t line 2359. Can't locate object method "rethrow" via package "DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 80830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80830&action=edit Bug 21597: Field 'amount' doesn't have a default value Fix t/db_dependent/Accounts.t Default value could be 0, or left as it. It seems that the different initialisation we have in the code pass a value for 'amount' account_offsets.amount `amount` decimal(26,6) NOT NULL, DBIx::Class::Storage::DBI::_dbh_execute(): Field 'amount' doesn't have a default value at /home/vagrant/kohaclone/Koha/Object.pm line 125 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 80831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80831&action=edit Bug 21597: Data too long for column 'invitekey' Fix t/db_dependent/Virtualshelves.t virtualshelfshares.invitekey `invitekey` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL, We should not insert a longer string! DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column 'invitekey' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 125 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 80832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80832&action=edit Bug 21597: Incorrect date value: '0' for column 'onloan' Fix t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t items.onloan `onloan` date DEFAULT NULL, DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect date value: '0' for column 'onloan' at row 1 at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 288 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 80833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80833&action=edit Bug 21597: Field 'description' doesn't have a default value Nick proposed another fix, see bug 21594. The interface does not explode so I do not think we should make a DB update in a rush. Fix t/db_dependent/Koha/Object.t and t/db_dependent/Koha/ApiKeys.t api_keys.description and api_keys.secret: `secret` varchar(191) COLLATE utf8mb4_unicode_ci NOT NULL, `description` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL, # Failed test 'Exception is thrown correctly' # at t/db_dependent/Koha/Object.t line 262. # expecting: Koha::Exceptions::Object::FKConstraint # found: DBIx::Class::Exception (DBIx::Class::Storage::DBI::_dbh_execute(): Field 'description' doesn't have a default value at /home/vagrant/kohaclone/Koha/Object.pm line 125 # ) # Looks like you planned 7 tests but ran 1. # Looks like you failed 1 test of 1 run. and later, but not related: Can't locate object method "message" via package "DBIx::Class::Exception" at t/db_dependent/Koha/Object.t line 264. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 80834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80834&action=edit Bug 21597: Incorrect decimal value: 't_value_bib639' for column 'price' Fix t/db_dependent/selenium/basic_workflow.t We want to send specific values depending on the data type in DB For instance integer, or varchar(10) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21600 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last failure seem to be api/v1/patrons.t but I did not manage to fix it. Opened a new bug report: Bug 21600 - t/db_dependent/api/v1/patrons.t is failing with new SQL modes Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21600 [Bug 21600] t/db_dependent/api/v1/patrons.t is failing with new SQL modes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21601 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21601 [Bug 21601] Cannot create lists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21603 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21603 [Bug 21603] Remove Group by clause in SearchCourses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 [Bug 21604] Cannot add/edit funds, cannot add budgets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605 [Bug 21605] Cannot create EDI account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21606 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21606 [Bug 21606] Issues with matching rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80829|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80852&action=edit Bug 21597: Column 'notforloan' cannot be null Fix t/db_dependent/Circulation.t items.notforloan: `notforloan` tinyint(1) NOT NULL DEFAULT '0', t/db_dependent/Circulation.t .. 115/119 DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. # No tests run! # Failed test 'No tests run for subtest "item-level_itypes = 0"' # at t/db_dependent/Circulation.t line 2356. # Looks like you failed 1 test of 2. # Failed test 'CanBookBeIssued | notforloan' # at t/db_dependent/Circulation.t line 2359. Can't locate object method "rethrow" via package "DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80830|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80853&action=edit Bug 21597: Field 'amount' doesn't have a default value Fix t/db_dependent/Accounts.t Default value could be 0, or left as it. It seems that the different initialisation we have in the code pass a value for 'amount' account_offsets.amount `amount` decimal(26,6) NOT NULL, DBIx::Class::Storage::DBI::_dbh_execute(): Field 'amount' doesn't have a default value at /home/vagrant/kohaclone/Koha/Object.pm line 125 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80831|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80854&action=edit Bug 21597: Data too long for column 'invitekey' Fix t/db_dependent/Virtualshelves.t virtualshelfshares.invitekey `invitekey` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL, We should not insert a longer string! DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column 'invitekey' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 125 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80832|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80855&action=edit Bug 21597: Incorrect date value: '0' for column 'onloan' Fix t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t items.onloan `onloan` date DEFAULT NULL, DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect date value: '0' for column 'onloan' at row 1 at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 288 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80833|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80856&action=edit Bug 21597: Field 'description' doesn't have a default value Nick proposed another fix, see bug 21594. The interface does not explode so I do not think we should make a DB update in a rush. Fix t/db_dependent/Koha/Object.t and t/db_dependent/Koha/ApiKeys.t api_keys.description and api_keys.secret: `secret` varchar(191) COLLATE utf8mb4_unicode_ci NOT NULL, `description` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL, # Failed test 'Exception is thrown correctly' # at t/db_dependent/Koha/Object.t line 262. # expecting: Koha::Exceptions::Object::FKConstraint # found: DBIx::Class::Exception (DBIx::Class::Storage::DBI::_dbh_execute(): Field 'description' doesn't have a default value at /home/vagrant/kohaclone/Koha/Object.pm line 125 # ) # Looks like you planned 7 tests but ran 1. # Looks like you failed 1 test of 1 run. and later, but not related: Can't locate object method "message" via package "DBIx::Class::Exception" at t/db_dependent/Koha/Object.t line 264. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80834|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80857&action=edit Bug 21597: Incorrect decimal value: 't_value_bib639' for column 'price' Fix t/db_dependent/selenium/basic_workflow.t We want to send specific values depending on the data type in DB For instance integer, or varchar(10) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Straightforward fixes to tests. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Patches here pushed to master, will need an new omnibus or to adjust and reopen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #28)
Patches here pushed to master, will need an new omnibus or to adjust and reopen
With bug 21600 the tests should be ok. Others are not tests related (even if tests should have caught them!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21603, 21604, 21605, 21606, | |21601 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21601 [Bug 21601] Cannot create lists https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21603 [Bug 21603] Remove Group by clause in SearchCourses https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 [Bug 21604] Cannot add/edit funds, cannot add budgets https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605 [Bug 21605] Cannot create EDI account https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21606 [Bug 21606] Issues with matching rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21613 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21613 [Bug 21613] Turn strict SQL mode on for tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Bug 21597 depends on bug 20521, which changed state. Bug 20521 Summary: dev installations should run with problematic SQL modes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #31 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I pass for new default SQL modes in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Bug 21597 depends on bug 21599, which changed state. Bug 21599 Summary: Incorrect decimal value: '' for column 'defaultreplacecost' - Cannot create item type https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21599 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Bug 21597 depends on bug 21593, which changed state. Bug 21593 Summary: Remove Group by clause in GetAuthValueDropbox https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Bug 21597 depends on bug 21598, which changed state. Bug 21598 Summary: budget_parent_id isn't in GROUP BY - GetBudgetHierarchy https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21598 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Bug 21597 depends on bug 21596, which changed state. Bug 21596 Summary: Handle default values when storing Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21596 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 21594 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org