[Bug 31911] New: Headings are inconsistent in rotating collections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Bug ID: 31911 Summary: Headings are inconsistent in rotating collections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Headings are placed above the main action toolbar on the 'Add/remove items from collection' page of 'Rotating collections'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31770 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 [Bug 31770] Add 'page-section' to rotating collections page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142398&action=edit Bug 31911: Improve rotating collections item management This patch renames 'Add/remove items from collection' to just 'Manage items' in the button in the rotating collections list table, the page heading and the breadcrumbs. We also move the heading below the toolbar to be consistent with elsewhere, remove a superflous second level heading and wrap the content table in a page-section too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this is a good improvement, but I am in doubt about this heading: Total items: 2 It doesn't feel like a heading to me, but more like it should appear in the line below one. Maybe the heading could be: Items in collection ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142398|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142504&action=edit Bug 31911: Improve rotating collections item management This patch renames 'Add/remove items from collection' to just 'Manage items' in the button in the rotating collections list table, the page heading and the breadcrumbs. We also move the heading below the toolbar to be consistent with elsewhere, remove a superflous second level heading and wrap the content table in a page-section too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142505&action=edit Bug 31911: (follow-up) Rename second level heading This patch, as suggested, renames the second level heading to 'Items in collection' and move the 'Total items: {count}' into a paragraph. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142504|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 142558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142558&action=edit Bug 31911: Improve rotating collections item management This patch renames 'Add/remove items from collection' to just 'Manage items' in the button in the rotating collections list table, the page heading and the breadcrumbs. We also move the heading below the toolbar to be consistent with elsewhere, remove a superflous second level heading and wrap the content table in a page-section too. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142505|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 142559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142559&action=edit Bug 31911: (follow-up) Rename second level heading This patch, as suggested, renames the second level heading to 'Items in collection' and move the 'Total items: {count}' into a paragraph. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142558|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142560&action=edit Bug 31911: Improve rotating collections item management This patch renames 'Add/remove items from collection' to just 'Manage items' in the button in the rotating collections list table, the page heading and the breadcrumbs. We also move the heading below the toolbar to be consistent with elsewhere, remove a superflous second level heading and wrap the content table in a page-section too. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142559|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142561&action=edit Bug 31911: (follow-up) Rename second level heading This patch, as suggested, renames the second level heading to 'Items in collection' and move the 'Total items: {count}' into a paragraph. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 142562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142562&action=edit Screenshot - list of rotating collections Something minor (and maybe for another bug) - do we need to show 'Showing 1 to 2 of 2 entries' on a separate line? See the screenshot. I think on other screens (such as list of items for a record) we show on the same row as the DataTables header. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #9)
Created attachment 142562 [details] Screenshot - list of rotating collections
Something minor (and maybe for another bug) - do we need to show 'Showing 1 to 2 of 2 entries' on a separate line? See the screenshot.
I think on other screens (such as list of items for a record) we show on the same row as the DataTables header.
I think this has to do with today's changes to the datatable controls, unrelated to this bug. I see the same on the libraries page. I kinda like it, because the inofrmation was often missed before, but not sure if intentional or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It was bug 31861 and bug 31754. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 --- Comment #13 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #10)
(In reply to David Nind from comment #9)
Created attachment 142562 [details] Screenshot - list of rotating collections
Something minor (and maybe for another bug) - do we need to show 'Showing 1 to 2 of 2 entries' on a separate line? See the screenshot.
I think on other screens (such as list of items for a record) we show on the same row as the DataTables header.
I think this has to do with today's changes to the datatable controls, unrelated to this bug. I see the same on the libraries page.
I kinda like it, because the inofrmation was often missed before, but not sure if intentional or not.
Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Bug 31911 depends on bug 31770, which changed state. Bug 31770 Summary: Add 'page-section' to rotating collections page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31770 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31911 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org