[Bug 4276] New: "Related subjects" search is OPAC doesn't work with chained subject terms
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4276 Summary: "Related subjects" search is OPAC doesn't work with chained subject terms Product: Koha Version: rel_3_0 Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: pasi.korkalo@oululainen.com Estimated Hours: 0.0 Change sponsored?: --- Related subjects doesn't work right when using XSLTDetailsDisplay. Clicking on chained subject terms only does the search with the first term in the chain. For example clicking on "world-music Portugal" only searches with "su:world-music" instead of "su:world-music and su:Portugal" which is what you'd expect. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4276 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2010-02-26 15:07:07 --- This problem exists in both the OPAC and staff client XSL detail pages in HEAD. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4276 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard@myacpl.org |gmcharlt@gmail.com -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4276 Garry Collum <gcollum@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gcollum@gmail.com --- Comment #2 from Garry Collum <gcollum@gmail.com> 2010-02-28 21:08:06 --- I was able to get the desired affect by replacing <xsl:attribute name="href">/cgi/bin/koha/catalogue/search.pl?1=su:<xsl:value-of select="marc:subfield[@code='a']"/></xsl.attribute> in MARC21slim2intranetDetail.xsl with <xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=su:<xsl:call-template name="chopPunctuation"> <xsl:with-param name="chopString"> <xsl:call-template name="subfieldSelect"> <xsl:with-param name="codes">abcdvxyz</xsl:with-param> </xsl:call-template> </xsl:with-param> </xsl:call-template> </xsl:attribute> But if any keywords were added to the link, other than what was in 650 subfield a, no results were returned. Are other subfields in 650 indexed? Is it just my setup? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4276 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner@ptfs.com --- Comment #3 from Jane Wagner <jwagner@ptfs.com> 2010-03-19 18:15:46 --- We did some experimenting with manual searches and indexes today. Standard Koha seems to deliver all the 6xx fields indexed with all subfields, like this: melm 650 Subject,Subject:p We tried adding Subject:w as a setting, and reindexed. That didn't make any difference -- searching either su,phr: College teachers United States Periodicals or su: College teachers United States Periodicals does not get any results. I took a look at the way the non-XSLT search works, and it's rather questionable: su: College teachers and su: United States and su: Periodicals This works and gets results, but it doesn't limit the results to records with that as the entire subject entry "College teachers United States Periodicals" in different subfields. Rather, it's finding titles with a subject subfield of College Teachers and perhaps another subject subfield in a different 6xx of United States, etc. Is that the best approach? Isn't there any way to say only search for this entire string in one 6xx field? I haven't tried any code change yet with XSLT -- I want to understand how the search works first. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4276 --- Comment #4 from Garry Collum <gcollum@gmail.com> 2010-03-19 23:12:49 --- I was experimenting some more. The code above creates a url in the form of "search.pl?q=su:history+united+states+civil+war" and does not return any hits. If the url takes the form of "search.pl?idx=su&q=history+united+states+civil+war" hits are returned. This is getting closer to the desired affect, but a phrase search would be better. The keyword search would still produce some false hits. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4276 --- Comment #5 from Garry Collum <gcollum@gmail.com> 2010-03-20 01:21:38 --- Created an attachment (id=1751) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1751) Proposed patch. Here's a proposed patch. It also adds subfield b to a 710 (Corporate Author) link. I don't think we would need anything other than subfield b, but I'm not a cataloger. The Intranet still needs to be looked at, but it has some other problems. The links in the detail page are pointing to the opac. I've submitted a patch to fix this, but it has not yet been pushed. (bug 4285) -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4276 --- Comment #6 from Jane Wagner <jwagner@ptfs.com> 2010-03-22 18:56:25 --- collum, following up on our IRC discussion so it doesn't get lost -- there are a couple of problems with your patch as is. One is that if a subject string has a paren in it, like Science Study and teaching (Higher) United States, it doesn't find any results. The same string without the paren works -- Science Study and teaching Higher United States. I don't know if there are other special chars found in subject terms that should be stripped. Any catalogers around? The other problem has to do with including the 710 corporate author in the subject search. If I understood correctly, you did so to fix a similar problem with other authority links, but you were going to look at how to limit subjects to subject index, etc. Overall, it works nicely and is a big improvement. Thanks for your work! -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4276 --- Comment #7 from Garry Collum <gcollum@gmail.com> 2010-03-22 20:14:00 --- jwagner: The 710 is unrelated to the subject search. Sorry for the confusion. The search behavior of the subject links, the bug, is also present in other authority links. For instance, an author(700) that has the data ($a Feitelson, Lorser,$d 1898-), would not include the date, subfield d, in the url of the link, and currently if it did, it would not return results. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4276 --- Comment #8 from Jane Wagner <jwagner@ptfs.com> 2010-03-22 20:19:37 --- That's what I thought you were saying, thanks. I started looking at how to strip out parens (and anything else) but haven't gotten very far. I was pointed to this site http://www.w3schools.com/xpath/xpath_functions.asp#string for some XSLT string handling/substitution functions. I'll investigate further unless you beat me to it. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4276 Christopher Curry <ccurry@amphilsoc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ccurry@amphilsoc.org -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4276 Cookie Wolfrom <cookie.wolfrom@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cookie.wolfrom@liblime.com -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon@kohaorg.ec2.liblime.com