[Bug 9672] New: Replace YUI buttons on MARC editor page with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 Bug ID: 9672 Summary: Replace YUI buttons on MARC editor page with Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/addbiblio.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The toolbar buttons on the MARC editing page (addbiblio.pl) are constructed using YUI. They should use Bootstrap instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15568&action=edit Bug 9672 - Replace YUI buttons on MARC editor page with Bootstrap This patch converts the buttons on the MARC editor page to Bootstrap, replacing YUI button and menu code with Bootstrap markup. Various workflows must be tested to confirm that functionality remains unchanged: - Edit existing record. Clicking the "save" button should redirect you to the default "view" page for that record. - Create a new record. Clicking the "save" button should redirect you to the add/edit items screen. - When creating or editing a record, test the dropdown menu attached to the "save" button. Each function should work correctly. - Test using a user who does not have "edit items" permission. There should be no menu attached to the "save" button. - Test using fast cataloging through circulation. A single save button should appear, redirecting to items. In all cases validation should proceed before saving. Leave a required field empty to test. Testers should also confirm that Z39.50 button works as expected and changing frameworks still works as usual. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9676 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15568|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15595&action=edit [SIGNED-OFF] Bug 9672 - Replace YUI buttons on MARC editor page with Bootstrap This patch converts the buttons on the MARC editor page to Bootstrap, replacing YUI button and menu code with Bootstrap markup. Various workflows must be tested to confirm that functionality remains unchanged: - Edit existing record. Clicking the "save" button should redirect you to the default "view" page for that record. - Create a new record. Clicking the "save" button should redirect you to the add/edit items screen. - When creating or editing a record, test the dropdown menu attached to the "save" button. Each function should work correctly. - Test using a user who does not have "edit items" permission. There should be no menu attached to the "save" button. - Test using fast cataloging through circulation. A single save button should appear, redirecting to items. In all cases validation should proceed before saving. Leave a required field empty to test. Testers should also confirm that Z39.50 button works as expected and changing frameworks still works as usual. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: All workflows tested, with resticted and super user. All buttons worked as expected. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Also tested Z39.50 button and functionality, all works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15595|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15837&action=edit [PASSED QA] Bug 9672 - Replace YUI buttons on MARC editor page with Bootstrap This patch converts the buttons on the MARC editor page to Bootstrap, replacing YUI button and menu code with Bootstrap markup. Various workflows must be tested to confirm that functionality remains unchanged: - Edit existing record. Clicking the "save" button should redirect you to the default "view" page for that record. - Create a new record. Clicking the "save" button should redirect you to the add/edit items screen. - When creating or editing a record, test the dropdown menu attached to the "save" button. Each function should work correctly. - Test using a user who does not have "edit items" permission. There should be no menu attached to the "save" button. - Test using fast cataloging through circulation. A single save button should appear, redirecting to items. In all cases validation should proceed before saving. Leave a required field empty to test. Testers should also confirm that Z39.50 button works as expected and changing frameworks still works as usual. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: All workflows tested, with resticted and super user. All buttons worked as expected. No errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9672 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9534 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org