[Bug 17044] New: Wrong destination for 'api' directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 Bug ID: 17044 Summary: Wrong destination for 'api' directory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org To reproduce: - Make a standard install (for example in /usr/share/koha => FAIL: check /usr/share/koha/api/api exists - Make a single install (for example in /home/tcohen/koha-single) => FAIL: check /home/tcohen/koha-single/api/api exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com Depends on| |13799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 53964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53964&action=edit Bug 17044: Fix wrong destination for 'api' directory The original Makefile.PL tweak missed to trim the directory name thus repeating the 'api' directory like in 'api/api'. To test: - Make a standard install (for example in /usr/share/koha => FAIL: check /usr/share/koha/api/api exists - Make a single install (for example in /home/tcohen/koha-single) => FAIL: check /home/tcohen/koha-single/api/api exists - Apply the patch - Make a standard install (for example in /usr/share/koha => SUCCESS: check /usr/share/koha/api exists and doesn't contain a nested 'api' dir - Make a single install (for example in /home/tcohen/koha-single) => SUCCESS: check /home/tcohen/koha-single/api exists and doesn't contain a nested 'api' dir - Sign off :-D Note: this affects the packages too, as the standard install is used as a basis. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030 [Bug 17030] Configure the REST api on packages install -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53964|0 |1 is obsolete| | --- Comment #2 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 53974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53974&action=edit Bug 17044: Fix wrong destination for 'api' directory The original Makefile.PL tweak missed to trim the directory name thus repeating the 'api' directory like in 'api/api'. To test: - Make a standard install (for example in /usr/share/koha => FAIL: check /usr/share/koha/api/api exists - Make a single install (for example in /home/tcohen/koha-single) => FAIL: check /home/tcohen/koha-single/api/api exists - Apply the patch - Make a standard install (for example in /usr/share/koha => SUCCESS: check /usr/share/koha/api exists and doesn't contain a nested 'api' dir - Make a single install (for example in /home/tcohen/koha-single) => SUCCESS: check /home/tcohen/koha-single/api exists and doesn't contain a nested 'api' dir - Sign off :-D Note: this affects the packages too, as the standard install is used as a basis. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth@kul.oslo.k | |ommune.no Status|Needs Signoff |Signed Off --- Comment #3 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Good catch Thomas! Have been scratching my head on this one, and will remove my symlink as soon as this is in master ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Benjamin Rokseth from comment #3)
Good catch Thomas! Have been scratching my head on this one, and will remove my symlink as soon as this is in master ;)
Hehehe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53974|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54048&action=edit Bug 17044: Fix wrong destination for 'api' directory The original Makefile.PL tweak missed to trim the directory name thus repeating the 'api' directory like in 'api/api'. To test: - Make a standard install (for example in /usr/share/koha => FAIL: check /usr/share/koha/api/api exists - Make a single install (for example in /home/tcohen/koha-single) => FAIL: check /home/tcohen/koha-single/api/api exists - Apply the patch - Make a standard install (for example in /usr/share/koha => SUCCESS: check /usr/share/koha/api exists and doesn't contain a nested 'api' dir - Make a single install (for example in /home/tcohen/koha-single) => SUCCESS: check /home/tcohen/koha-single/api exists and doesn't contain a nested 'api' dir - Sign off :-D Note: this affects the packages too, as the standard install is used as a basis. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 Bug 17044 depends on bug 13799, which changed state. Bug 13799 Summary: Add base for building RESTful API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org