[Bug 30268] New: When creating an order from a staged file, mandatory item subfields that are empty do not block form submission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 Bug ID: 30268 Summary: When creating an order from a staged file, mandatory item subfields that are empty do not block form submission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Steps to reproduce: 1. Make sure you have mandatory item subfields in the MARC bibliographic framework used in acquisitions ("ACQ" if it exists, the default framework otherwise). 2. Use the "Stage MARC records for import" tool to upload a file. Do not import the bibliographic records. 3. Create a new acquisition basket ("Create items when:" must be set to "placing an order") and add a new order from a staged file 4. Select the file you just uploaded 5. In the "Items information" tab, make sure at least one mandatory subfield is empty 6. Try to submit the form. If there are errors about other mandatory fields (like the fund for instance), fix those errors and resubmit. You will be able to submit the form without filling the mandatory item subfields, but that should not be possible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 131557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131557&action=edit Bug 30268: Check mandatory fields in addorderiso2709.pl Test plan: 1. Make sure you have mandatory item subfields in the MARC bibliographic framework used in acquisitions ("ACQ" if it exists, the default framework otherwise). 2. Use the "Stage MARC records for import" tool to upload a file. Do not import the bibliographic records. 3. Create a new acquisition basket ("Create items when:" must be set to "placing an order") and add a new order from a staged file 4. Select the file you just uploaded 5. In the "Items information" tab, make sure at least one mandatory subfield is empty 6. Try to submit the form. If there are errors about other mandatory fields (like the fund for instance), fix those errors and resubmit. There should be an error message about mandatory item subfields. 7. Enter a value for the mandatory item subfields and resubmit the form. Verify that the order and the item have been correctly created. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131557|0 |1 is obsolete| | --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 136771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136771&action=edit Bug 30268: Check mandatory fields in addorderiso2709.pl Test plan: 1. Make sure you have mandatory item subfields in the MARC bibliographic framework used in acquisitions ("ACQ" if it exists, the default framework otherwise). 2. Use the "Stage MARC records for import" tool to upload a file. Do not import the bibliographic records. 3. Create a new acquisition basket ("Create items when:" must be set to "placing an order") and add a new order from a staged file 4. Select the file you just uploaded 5. In the "Items information" tab, make sure at least one mandatory subfield is empty 6. Try to submit the form. If there are errors about other mandatory fields (like the fund for instance), fix those errors and resubmit. There should be an error message about mandatory item subfields. 7. Enter a value for the mandatory item subfields and resubmit the form. Verify that the order and the item have been correctly created. Signed-off-by: Thibault Kero <thibault.keromnes@univ-paris8.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 Thibault Keromnès <thibault.keromnes@univ-paris8.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |thibault.keromnes@univ-pari | |s8.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136771|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137703&action=edit Bug 30268: Check mandatory fields in addorderiso2709.pl Test plan: 1. Make sure you have mandatory item subfields in the MARC bibliographic framework used in acquisitions ("ACQ" if it exists, the default framework otherwise). 2. Use the "Stage MARC records for import" tool to upload a file. Do not import the bibliographic records. 3. Create a new acquisition basket ("Create items when:" must be set to "placing an order") and add a new order from a staged file 4. Select the file you just uploaded 5. In the "Items information" tab, make sure at least one mandatory subfield is empty 6. Try to submit the form. If there are errors about other mandatory fields (like the fund for instance), fix those errors and resubmit. There should be an error message about mandatory item subfields. 7. Enter a value for the mandatory item subfields and resubmit the form. Verify that the order and the item have been correctly created. Signed-off-by: Thibault Kero <thibault.keromnes@univ-paris8.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice improvement, works as described. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org