[Bug 19772] New: Wrong success message if PATRON_NOTE is not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 Bug ID: 19772 Summary: Wrong success message if PATRON_NOTE is not defined Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: aleisha@catalyst.net.nz Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 14224 There is no PATRON_NOTE notice template created for new installation. If the pref (AllowCheckoutNotes) is set to on, a patron can let a note from the OPAC and the message "Your note about $TITLE / has been saved and sent to the library." is display to the screen. But actually the Koha logs mention "No circulation PATRON_NOTE letter transported by email at /home/vagrant/kohaclone/C4/Letters.pm line 697." and no notice is generated Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 [Bug 14224] patron notes about item shown at check in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- this will be fixed by the patch in bug 18915. *** This bug has been marked as a duplicate of bug 18915 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Sorry Jonathan, I can't actually reproduce this. When there is no notice called 'CHECKOUT_NOTE' (which is now what the notice is called), the note still saves and the title shows as expected (but obviously the notice isn't sent and the log shows that "No circulation CHECKOUT_NOTE letter transported by email at /home/vagrant/kohaclone/C4/Letters.pm line 697." message) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrong success message if |Wrong success message if |PATRON_NOTE is not defined |CHECKOUT_NOTE is not | |defined CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Aleisha, yes it is what I describe :) The message says "everything is ok and sent" whereas the email has not been sent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED Severity|major |normal --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Maybe we should disable the feature if the notice template is not configured. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi Jonathan, Sorry I think I'm understanding the problem now. I'll make a fix where the Checkout Notes feature can't be enabled unless the library also has a CHECKOUT_NOTE notice configured. Patch to come soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could there be a case where a library wants to activate the feature, but use it without email? We have some cases like the suggestions emails where you just delete the notice in that case. Maybe we could just adapt the text a little and remove the error/warning? Making the options dependent seems more hassle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #6)
Could there be a case where a library wants to activate the feature, but use it without email? We have some cases like the suggestions emails where you just delete the notice in that case. Maybe we could just adapt the text a little and remove the error/warning? Making the options dependent seems more hassle.
I'm still working on the patch for Bug 17698 where the checkout notes will be shown on the staff dashboard, similar to how patron modifications are shown. I could add a patch to this bug that depends on 17698 where, if no notice is defined, it will not try to send an email and instead just show the note on the staff dashboard? hope that makes sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14224 |17698 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Aleisha Amohia from comment #7)
(In reply to Katrin Fischer from comment #6)
Could there be a case where a library wants to activate the feature, but use it without email? We have some cases like the suggestions emails where you just delete the notice in that case. Maybe we could just adapt the text a little and remove the error/warning? Making the options dependent seems more hassle.
I'm still working on the patch for Bug 17698 where the checkout notes will be shown on the staff dashboard, similar to how patron modifications are shown. I could add a patch to this bug that depends on 17698 where, if no notice is defined, it will not try to send an email and instead just show the note on the staff dashboard? hope that makes sense.
Yep, makes sense to me! I have taken a look on bug 17698 and it looks promising. Linking both reports now. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 [Bug 14224] patron notes about item shown at check in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 [Bug 17698] Make patron notes show up on staff dashboard -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 Bug 19772 depends on bug 17698, which changed state. Bug 17698 Summary: Make patron notes show up on staff dashboard https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Looks like this got lost along the way -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org