[Bug 27643] New: Add CodeMirror custom syntax highlighting for SQL parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 Bug ID: 27643 Summary: Add CodeMirror custom syntax highlighting for SQL parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Reports Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I propose we add a basic syntax highlighting configuration for SQL parameters, defined as any string surrounded by double brackets: <<branches>>. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add CodeMirror custom |Add CodeMirror custom |syntax highlighting for SQL |syntax highlighting for SQL |parameters |runtime parameters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27644 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27644 [Bug 27644] Add button to SQL report editor for inserting runtime parameters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116432&action=edit Bug 27643: Add CodeMirror custom syntax highlighting for SQL runtime parameters This patch adds some additional configuration to CodeMirror so that runtime parameters have a distinct color in the CodeMirror SQL editor. To test, apply the patch and create or edit an SQL report which contains one or more runtime parameters, e.g. <<branches>>, <<categorycode>>, etc. Confirm that when editing the SQL, these parameters should appear as green text. Save your report and view it. The syntax highlighting should be updated in this view too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116432|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 116437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116437&action=edit Bug 27643: Add CodeMirror custom syntax highlighting for SQL runtime parameters This patch adds some additional configuration to CodeMirror so that runtime parameters have a distinct color in the CodeMirror SQL editor. To test, apply the patch and create or edit an SQL report which contains one or more runtime parameters, e.g. <<branches>>, <<categorycode>>, etc. Confirm that when editing the SQL, these parameters should appear as green text. Save your report and view it. The syntax highlighting should be updated in this view too. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116437|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116443&action=edit Bug 27643: Add CodeMirror custom syntax highlighting for SQL runtime parameters This patch adds some additional configuration to CodeMirror so that runtime parameters have a distinct color in the CodeMirror SQL editor. To test, apply the patch and create or edit an SQL report which contains one or more runtime parameters, e.g. <<branches>>, <<categorycode>>, etc. Confirm that when editing the SQL, these parameters should appear as green text. Save your report and view it. The syntax highlighting should be updated in this view too. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, please fill the release notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This patch modifies the release notes| |configuration of the | |reports module's SQL editor | |so that runtime parameters | |have their own syntax | |highlighting, setting them | |apart by color from other | |parts of the SQL code. --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #6)
Owen, please fill the release notes.
Done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27747 [Bug 27747] Add CodeMirror custom syntax highlighting for SQL runtime parameters -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org