https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50677&action=edit Bug 16344: [DO NOT PUSH] Schema changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50725&action=edit Bug 16344: Fix alignment between top and bottom columns -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50676|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53428&action=edit Bug 16344: Add a circ rule to limit the auto renewals given a specific This patch adds a new circulation rule (no_auto_renewal_after_hard_limit) to block/allow auto renewals after a given date. The idea is to stop renewals at a given date. That way the library will have time to send overdues and get the books back before the students do on holiday. Test plan: 0/ Execute the update DB entry 1/ Define a rule with no_auto_renewal_after_hard_limit set to tomorrow 2/ Modify the issues.issuedate, to simulate a checkout in the past: UPDATE issues SET issuedate = "yyyy-mm-dd hh:mm:ss" WHERE itemnumber = YOUR_ITEMNUMBER; with issuedate = 2 days before for instance 3/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed 4/ Modify the no_auto_renewal_after_hard_limit and set it to yesterday 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50725|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53430&action=edit Bug 16344: Fix alignment between top and bottom columns -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Liz Rea from comment #7)

Applying: Bug 16344: Add a circ rule to limit the auto renewals given a specific fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 16344: Add a circ rule to limit the auto renewals given a specific

:(

It applies cleanly on top of bug 15581. Please try again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53428|0 |1 is obsolete| | Attachment #53429|0 |1 is obsolete| | Attachment #53430|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56616&action=edit Bug 16344: Add a circ rule to limit the auto renewals given a specific This patch adds a new circulation rule (no_auto_renewal_after_hard_limit) to block/allow auto renewals after a given date. The idea is to stop renewals at a given date. That way the library will have time to send overdues and get the books back before the students do on holiday. Test plan: 0/ Execute the update DB entry 1/ Define a rule with no_auto_renewal_after_hard_limit set to tomorrow 2/ Modify the issues.issuedate, to simulate a checkout in the past: UPDATE issues SET issuedate = "yyyy-mm-dd hh:mm:ss" WHERE itemnumber = YOUR_ITEMNUMBER; with issuedate = 2 days before for instance 3/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed 4/ Modify the no_auto_renewal_after_hard_limit and set it to yesterday 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56618&action=edit Bug 16344: [DO NOT PUSH] Schema changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #14 from Michael Kuhn <mik@adminkuhn.ch> --- According to the test plan I did the following. I successfully applied patches 15581 and 16344. 0) I executed the update DB entry vagrant@kohadevbox:kohaclone(003)$ sudo koha-shell kohadev kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ perl installer/data/mysql/updatedatabase.pl DEV atomic update: bug_15581.sql DEV atomic update: bug_16344.sql 1) In Koha menu "Administration > Circulation and fine rules" I defined a rule for all categories and all item types: * Renewals allowed (count): 3 * No automatic renewal after (hard limit): 20/10/2016 Then I checked out the item with number 1 (otherwise it couldn't be updated with following statement). 2) I modified the table "issues" with issuedate two days before as followes: UPDATE issues SET issuedate = "2016-10-17 22:48:00" WHERE itemnumber=1; 3) I executed the renewals cronjob script as follows: vagrant@kohadevbox:kohaclone(003)$ sudo koha-shell kohadev kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ misc/cronjobs/automatic_renewals.pl I cannot confirm that the issue has been renewed. Instead, nothing has changed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56751&action=edit Bug 16344: Fix alignment between top and bottom columns -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #18 from Michael Kuhn <mik@adminkuhn.ch> --- According to the test plan I did the following. I successfully applied patches 15581 and 16344. 0) I executed the update DB entry vagrant@kohadevbox:kohaclone(002)$ sudo koha-shell kohadev kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ perl installer/data/mysql/updatedatabase.pl DEV atomic update: bug_15581.sql DEV atomic update: bug_16344.sql 1) In Koha menu "Administration > Circulation and fine rules" I defined a rule for all categories and all item types: * Renewals allowed (count): 3 * No automatic renewal after (hard limit): 27/10/2016 Then I checked out the item with number 1 (otherwise it couldn't be updated with following statement). 2) I modified the table "issues" with issuedate two days before as followes: UPDATE issues SET issuedate = "2016-10-24 14:48:00" WHERE itemnumber=1; 3) I executed the renewals cronjob script as follows: vagrant@kohadevbox:kohaclone(002)$ sudo koha-shell kohadev kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ misc/cronjobs/automatic_renewals.pl I still cannot confirm that the issue has been renewed. Instead, nothing has changed (the due date is still set to 25/10/2016). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #20 from Michael Kuhn <mik@adminkuhn.ch> --- mysql> SELECT issuelength, lengthunit, renewalperiod FROM issuingrules; +-------------+------------+---------------+ | issuelength | lengthunit | renewalperiod | +-------------+------------+---------------+ | NULL | days | 0 | +-------------+------------+---------------+ These are the standard values in the kohadevbox. Should I set these to different values? Which are these? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #22 from Michael Kuhn <mik@adminkuhn.ch> --- According to the test plan I did the following. I successfully applied patches 15581 and 16344. 0) I executed the update DB entry vagrant@kohadevbox:kohaclone(002)$ sudo koha-shell kohadev kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ perl installer/data/mysql/updatedatabase.pl DEV atomic update: bug_15581.sql DEV atomic update: bug_16344.sql 1) In Koha menu "Administration > Circulation and fine rules" I defined a rule for all categories and all item types: * Loan period: 3 * Unit: days * Renewals allowed (count): 3 * Renewal period: 5 * No automatic renewal after (hard limit): 27/10/2016 Then I checked out the item with number 1 (otherwise it couldn't be updated with following statement). It gets the due date of 29/10/2016. 2) I modified the table "issues" with issuedate two days before as followes: UPDATE issues SET issuedate = "2016-10-24 14:00:00" WHERE itemnumber=1; 3) I executed the renewals cronjob script as follows: vagrant@kohadevbox:kohaclone(002)$ sudo koha-shell kohadev kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ misc/cronjobs/automatic_renewals.pl Still I cannot confirm that the issue has been renewed. Instead, nothing has changed and the due date is still set to 29/10/2016. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #24 from Michael Kuhn <mik@adminkuhn.ch> --- Well, the test plan didn't say it can not be in the future... However as I know from my library days it is usual that users lend a book and they renew it as soon as possible, so they can keep it longer. Usually this is possible. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #26 from Michael Kuhn <mik@adminkuhn.ch> --- Today I executed the renewals cronjob script again as follows: vagrant@kohadevbox:kohaclone(002)$ sudo koha-shell kohadev kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ misc/cronjobs/automatic_renewals.pl Still I cannot confirm that the issue has been renewed. Instead, nothing has changed and the due date is still set to 29/10/2016. I will now definitely stop testing this case because it takes me far too much time for no result at all. I hope someone with better knowledge can successfully sign this off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #28 from Janet McGowan <janet.mcgowan@ptfs-europe.com> --- Hi, I've just signed this off using our Sandbox. My testing plan as follows: Test plan: 0) I executed the update DB entry 1) I defined a rule with no_auto_renewal_after_hard_limit set to tomorrow 01/11/2016 2) I modified issues.issuedate, to simulate a checkout in the past: UPDATE issues SET issuedate = "2016-10-29 23:59:00" WHERE itemnumber = '6'; For my test the due date = 2016-11-01 (ie. due tomorrow). With this example it is also necessary to set a No renewal before value - e.g. 1 day in the Circulation rule - to allow the item to be autorenewed 1 day before it is due. 3) I ran the misc/cronjobs/automatic_renewals.pl I confirmed that the issue is renewed until 22/11/2016 (following 21 days in the Circulation rule) 4) I modified the no_auto_renewal_after_hard_limit and set it to yesterday 30/10/2016 5) I ran the misc/cronjobs/automatic_renewals.pl This time the issue has not been renewed - in the staff client the Renew column displays: "Can no longer be auto-renewed - number of checkout days exceeded" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56751|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57736&action=edit Bug 16344: Fix alignment between top and bottom columns -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57735|0 |1 is obsolete| | Attachment #57736|0 |1 is obsolete| | Attachment #57737|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61074&action=edit Bug 16344: Add a circ rule to limit the auto renewals given a specific This patch adds a new circulation rule (no_auto_renewal_after_hard_limit) to block/allow auto renewals after a given date. The idea is to stop renewals at a given date. That way the library will have time to send overdues and get the books back before the students do on holiday. Test plan: 0/ Execute the update DB entry 1/ Define a rule with no_auto_renewal_after_hard_limit set to tomorrow 2/ Modify the issues.issuedate, to simulate a checkout in the past: UPDATE issues SET issuedate = "yyyy-mm-dd hh:mm:ss" WHERE itemnumber = YOUR_ITEMNUMBER; with issuedate = 2 days before for instance 3/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed 4/ Modify the no_auto_renewal_after_hard_limit and set it to yesterday 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61076&action=edit Bug 16344: [DO NOT PUSH] Schema changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61075|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 61512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61512&action=edit Bug 16344: Fix alignment between top and bottom columns Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> Signed-off-by: Janet McGowan <janet.mcgowan@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Acting as git gopher for Jonathan Field and Janet McGowan again here, they did the actual testing and signoff. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61511|0 |1 is obsolete| | Attachment #61512|0 |1 is obsolete| | Attachment #61513|0 |1 is obsolete| | --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62820&action=edit Bug 16344: Add a circ rule to limit the auto renewals given a specific This patch adds a new circulation rule (no_auto_renewal_after_hard_limit) to block/allow auto renewals after a given date. The idea is to stop renewals at a given date. That way the library will have time to send overdues and get the books back before the students do on holiday. Test plan: 0/ Execute the update DB entry 1/ Define a rule with no_auto_renewal_after_hard_limit set to tomorrow 2/ Modify the issues.issuedate, to simulate a checkout in the past: UPDATE issues SET issuedate = "yyyy-mm-dd hh:mm:ss" WHERE itemnumber = YOUR_ITEMNUMBER; with issuedate = 2 days before for instance 3/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed 4/ Modify the no_auto_renewal_after_hard_limit and set it to yesterday 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> Signed-off-by: Janet McGowan <janet.mcgowan@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #41 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62822&action=edit Bug 16344: [DO NOT PUSH] Schema changes Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> Signed-off-by: Janet McGowan <janet.mcgowan@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #44)

Created attachment 63707 [details] [review] Bug 16344: Fix test in GetHardDueDate.t

Pushed to master -- You are receiving this mail because: You are watching all bug changes.