[Bug 9722] New: Allow users to add notes when placing a hold in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Bug ID: 9722 Summary: Allow users to add notes when placing a hold in opac Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl CC: gmcharlt@gmail.com Allow users to add notes when placing a hold in opac. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9721 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 15752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15752&action=edit Bug 9722: Allow users to add notes when placing a hold in opac The option of adding a note is controlled by new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: 1 Verify if new pref is disabled by default. Place a hold. You can't add a note. 2 Enable the pref. Place a hold and add a note. Check in staff if you can see the note in Catalogue Detail/Holds tab. 3 Toggle SingleBranchmode, AllowHoldDateInFuture/OPACAllowHoldDateInFuture, OPACShowHoldQueueDetails, or OPACItemHolds. Check the display of columns when placing a hold from opac. 4 Place a few holds with notes from opac search results in one run (enable DisplayMultiPlaceHold). Check results in staff again. Remark: A few lines already refer to mandatory note reasons. This is handled in a subsequent report. No reason to worry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 15753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15753&action=edit Bug 9722: Allow users to add notes when placing a hold in opac Database revision for report 9722, adding new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15752|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15806&action=edit Bug 9722: Allow users to add notes when placing a hold in opac Database revision for report 9722, adding new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15753|0 |1 is obsolete| | Attachment #15806|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15807&action=edit Bug 9722: Allow users to add notes when placing a hold in opac The option of adding a note is controlled by new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: 1 Verify if new pref is disabled by default. Place a hold. You can't add a note. 2 Enable the pref. Place a hold and add a note. Check in staff if you can see the note in Catalogue Detail/Holds tab. 3 Toggle SingleBranchmode, AllowHoldDateInFuture/OPACAllowHoldDateInFuture, OPACShowHoldQueueDetails, or OPACItemHolds. Check the display of columns when placing a hold from opac. 4 Place a few holds with notes from opac search results in one run (enable DisplayMultiPlaceHold). Check results in staff again. Remark: A few lines already refer to mandatory note reasons. This is handled in a subsequent report. No reason to worry. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15808&action=edit Bug 9722: Allow users to add notes when placing a hold in opac Database revision for report 9722, adding new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Looks good but a couple things that should probably be taken care of before passing qa: 1) The "Show notes" buttons should probably be titled "Add notes" instead. 2) When doing a multi-hold, clicking one "Show notes" button hides the previously visible note textarea. This is jarring and may confuse patrons into thinking they can only have a note on one and only one of the holds. It would be better to make each "Show notes" button a toggle to hide it's own note textarea, and clear that textarea if it gets hidden. You could even change the text from "Add notes" to "Remove notes" when the textarea is visible. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15808|0 |1 is obsolete| | --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 15834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15834&action=edit Bug 9722: Allow users to add notes when placing a hold in opac (dbrev) Database revision for report 9722, adding new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 15836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15836&action=edit Bug 9722: Toggle display of hold notes with Edit notes button Small adjustments, requested by Kyle: 1) Rename Show notes button. It is called now: Edit notes. 2) Do not hide all other notes fields. The Edit button now only toggles the corresponding hold notes field. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #6)
1) The "Show notes" buttons should probably be titled "Add notes" instead. Changed it to Edit notes.
2) When doing a multi-hold, clicking one "Show notes" button hides the previously visible note textarea. This is jarring and may confuse patrons into thinking they can only have a note on one and only one of the holds. It would be better to make each "Show notes" button a toggle to hide it's own note textarea, and clear that textarea if it gets hidden. You could even change the text from "Add notes" to "Remove notes" when the textarea is visible. The button now only toggles its own textarea. I do not prefer to remove the notes with one click. Shift-select or Ctrl+A plus delete does the job well enough :)
Thanks for testing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9743 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15807|0 |1 is obsolete| | Attachment #15834|0 |1 is obsolete| | Attachment #15836|0 |1 is obsolete| | --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17717&action=edit Bug 9722: Allow users to add notes when placing a hold in opac The option of adding a note is controlled by new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: 1 Verify if new pref is disabled by default. Place a hold. You can't add a note. 2 Enable the pref. Place a hold and add a note. Check in staff if you can see the note in Catalogue Detail/Holds tab. 3 Toggle SingleBranchmode, AllowHoldDateInFuture/OPACAllowHoldDateInFuture, OPACShowHoldQueueDetails, or OPACItemHolds. Check the display of columns when placing a hold from opac. 4 Place a few holds with notes from opac search results in one run (enable DisplayMultiPlaceHold). Check results in staff again. Remark: A few lines already refer to mandatory note reasons. This is handled in a subsequent report. No reason to worry. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17718&action=edit Bug 9722: Allow users to add notes when placing a hold in opac (dbrev) Database revision for report 9722, adding new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17719&action=edit Bug 9722: Toggle display of hold notes with Edit notes button Small adjustments, requested by Kyle: 1) Rename Show notes button. It is called now: Edit notes. 2) Do not hide all other notes fields. The Edit button now only toggles the corresponding hold notes field. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased three patches (small merge conflicts). Kyle: The third patch is more or less a "string patch", but could formally use your signoff too. Could you add that please? Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17719|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17726&action=edit Bug 9722: Toggle display of hold notes with Edit notes button Small adjustments, requested by Kyle: 1) Rename Show notes button. It is called now: Edit notes. 2) Do not hide all other notes fields. The Edit button now only toggles the corresponding hold notes field. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Good integration into a really ugly code/page. 2 small remarks: - Maybe the new pref should be under the OPAC/Appearance instead of Features. All OPACShow* pref are under appearande. - The toggle stuff can be made with a simple $("#notesrow_"+biblioNum).toggle(); not blocker Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17717|0 |1 is obsolete| | Attachment #17718|0 |1 is obsolete| | Attachment #17726|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18342&action=edit Bug 9722: Allow users to add notes when placing a hold in opac The option of adding a note is controlled by new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: 1 Verify if new pref is disabled by default. Place a hold. You can't add a note. 2 Enable the pref. Place a hold and add a note. Check in staff if you can see the note in Catalogue Detail/Holds tab. 3 Toggle SingleBranchmode, AllowHoldDateInFuture/OPACAllowHoldDateInFuture, OPACShowHoldQueueDetails, or OPACItemHolds. Check the display of columns when placing a hold from opac. 4 Place a few holds with notes from opac search results in one run (enable DisplayMultiPlaceHold). Check results in staff again. Remark: A few lines already refer to mandatory note reasons. This is handled in a subsequent report. No reason to worry. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18343&action=edit Bug 9722: Allow users to add notes when placing a hold in opac (dbrev) Database revision for report 9722, adding new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18344&action=edit Bug 9722: Toggle display of hold notes with Edit notes button Small adjustments, requested by Kyle: 1) Rename Show notes button. It is called now: Edit notes. 2) Do not hide all other notes fields. The Edit button now only toggles the corresponding hold notes field. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master along with a follow up to allow the hold note to be displayed in the patron summary in the OPAC (as it doesn't make sense to allow patrons to set a note without being able to view it later, particularly if it's meant to later contain notes about requesting a specific part). Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #20 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #19)
Pushed to master along with a follow up to allow the hold note to be displayed in the patron summary in the OPAC (as it doesn't make sense to allow patrons to set a note without being able to view it later, particularly if it's meant to later contain notes about requesting a specific part).
Thanks for that, Galen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10321 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #21 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #15)
- Maybe the new pref should be under the OPAC/Appearance instead of Features. All OPACShow* pref are under appearande.
Thanks for QAing, Jonathan. I thought about moving it. But I think that this pref that allows or not allows adding notes should be under Features. But I agree that you have a point about the name of the pref. Probably, the name is somewhat misleading. Do you have a suggestion? Would OpacHoldNotes be an improvement? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #15)
- The toggle stuff can be made with a simple $("#notesrow_"+biblioNum).toggle();
Submitted small followup on bug 10321 for that. Thx. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #21)
(In reply to comment #15)
- Maybe the new pref should be under the OPAC/Appearance instead of Features. All OPACShow* pref are under appearande.
Thanks for QAing, Jonathan. I thought about moving it. But I think that this pref that allows or not allows adding notes should be under Features. But I agree that you have a point about the name of the pref. Probably, the name is somewhat misleading. Do you have a suggestion? Would OpacHoldNotes be an improvement?
OpacHoldNotes is probably more expressive. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9743 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org