https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #105 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. I see a new sub added to C4 without test coverage. Moreover it's c/ping a lot of code from LinkBibHeadingsToAuthorities (refactoring needed) 2. New images must be replaced by bootstrap icons 3. In authorities.pl, "require C4::Heading;" why require instead of use? 4. addbiblio needs permission editcatalogue and displays the "linker button", but cataloguing/automatic_linker.pl requires editauthorities. I think the button must be hidden if permission is not sufficient. 5. Hazardous indentation in some file, for instance: +function confirmnotdup(redirect){ + $("#confirm_not_duplicate").attr("value","1"); + $("#redirect").attr("value",redirect); + Check(); +} -- You are receiving this mail because: You are watching all bug changes.