[Bug 23210] New: login4tags should be a link and included in every search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Bug ID: 23210 Summary: login4tags should be a link and included in every search result Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- If a non-authenticated user goes to the search results page they will only see the login4tags (Log in to add tags ) text included with the first result. This should be included with every result. Furthermore this seems like it should be a link and it is not. This text should link to /cgi-bin/koha/opac-user.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's the expected behavior: 565 [% ELSIF ( loop.first ) %] 566 <span class="actions"><span id="login4tags">Log in to add tags.</span></span> 567 [% END # IF loggedinusername %]
From commit 4073b27c503f8192a144b4762e6ff5d40576627f
Wrap up Tags integration - add sysprefs for new installs. Note that when the user is not logged in, the Tags input box/button will not display. The user will see a message telling them to log in to add tags. However, in order to keep the results display clean, the message will display only once, utilizing the loop context variable "__first__". Useful stuff! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 91945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91945&action=edit Bug 23210: login4tags should be a link and included in every search result TEST PLAN: 1. Make sure TagsEnabled and TagsInputOnList are set to allow. 2. Don't be logged into the OPAC. 3. Make a search and notice the 'Log in to add tags' text is not a link on the results page. 4. Apply patch 5. Refresh OPAC results page 6. 'Log in to add tags' takes you to the login page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|login4tags should be a link |login4tags should be a link |and included in every | |search result | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- this patch only adds a link to the -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- this patch adds a link but does not attempt to add the button to every search results. As Jonathon noted that would keep the results page very clean. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91945|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91998&action=edit Bug 23210: login4tags should be a link and included in every search result TEST PLAN: 1. Make sure TagsEnabled and TagsInputOnList are set to allow. 2. Don't be logged into the OPAC. 3. Make a search and notice the 'Log in to add tags' text is not a link on the results page. 4. Apply patch 5. Refresh OPAC results page 6. 'Log in to add tags' takes you to the login page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91999&action=edit Bug 23210: (follow-up) Log in for tags link should trigger modal This patch modifies the "Log in to add tags" link on the OPAC search results page, adding the class which is used elsewhere in the OPAC templates for triggering the login modal. Also: Removed an unnecessary period. To test, apply the patch and follow the original test plan. Clicking the "Log in to add tags" link should trigger the login modal. After logging in you should be returned to the page you were on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91998|0 |1 is obsolete| | --- Comment #7 from Michal Denar <black23@gmail.com> --- Created attachment 92512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92512&action=edit Bug 23210: login4tags should be a link and included in every search result TEST PLAN: 1. Make sure TagsEnabled and TagsInputOnList are set to allow. 2. Don't be logged into the OPAC. 3. Make a search and notice the 'Log in to add tags' text is not a link on the results page. 4. Apply patch 5. Refresh OPAC results page 6. 'Log in to add tags' takes you to the login page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91999|0 |1 is obsolete| | --- Comment #8 from Michal Denar <black23@gmail.com> --- Created attachment 92513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92513&action=edit Bug 23210: (follow-up) Log in for tags link should trigger modal This patch modifies the "Log in to add tags" link on the OPAC search results page, adding the class which is used elsewhere in the OPAC templates for triggering the login modal. Also: Removed an unnecessary period. To test, apply the patch and follow the original test plan. Clicking the "Log in to add tags" link should trigger the login modal. After logging in you should be returned to the page you were on. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92512|0 |1 is obsolete| | Attachment #92513|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 92518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92518&action=edit Bug 23210: login4tags should be a link TEST PLAN: 1. Make sure TagsEnabled and TagsInputOnList are set to allow. 2. Don't be logged into the OPAC. 3. Make a search and notice the 'Log in to add tags' text is not a link on the results page. 4. Apply patch 5. Refresh OPAC results page 6. 'Log in to add tags' takes you to the login page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 92519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92519&action=edit Bug 23210: (follow-up) Log in for tags link should trigger modal This patch modifies the "Log in to add tags" link on the OPAC search results page, adding the class which is used elsewhere in the OPAC templates for triggering the login modal. Also: Removed an unnecessary period. To test, apply the patch and follow the original test plan. Clicking the "Log in to add tags" link should trigger the login modal. After logging in you should be returned to the page you were on. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92518|0 |1 is obsolete| | Attachment #92519|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92522&action=edit Bug 23210: login4tags should be a link and included in every search result TEST PLAN: 1. Make sure TagsEnabled and TagsInputOnList are set to allow. 2. Don't be logged into the OPAC. 3. Make a search and notice the 'Log in to add tags' text is not a link on the results page. 4. Apply patch 5. Refresh OPAC results page 6. 'Log in to add tags' takes you to the login page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92523&action=edit Bug 23210: (follow-up) Log in for tags link should trigger modal This patch modifies the "Log in to add tags" link on the OPAC search results page, adding the class which is used elsewhere in the OPAC templates for triggering the login modal. Also: Removed an unnecessary period. To test, apply the patch and follow the original test plan. Clicking the "Log in to add tags" link should trigger the login modal. After logging in you should be returned to the page you were on. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #0)
If a non-authenticated user goes to the search results page they will only see the login4tags (Log in to add tags ) text included with the first result. This should be included with every result.
This part is still not fixed - I've filed a new bug. Bug 23528 - Show 'log in to add tags' link on all search result entries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23528 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23528 [Bug 23528] Show 'log in to add tags' link on all search result entries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #15 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Version(s)|19.11.00,19.05.04 |19.11.00,19.05.04, 18.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org