[Bug 42099] New: Update patron clubs pages to use grid layout for forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Bug ID: 42099 Summary: Update patron clubs pages to use grid layout for forms Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 41823 - Course reserves -> New course - Course reserves -> Course -> Add reserves - Course reserves -> Course -> Batch add reserves - Course reserves -> Course -> Batch remove reserves Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41823 [Bug 41823] Update acquisitions admin pages to use grid layout for forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update patron clubs pages |Update course reserve pages |to use grid layout for |to use grid layout for |forms |forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 195460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195460&action=edit Bug 42099: Update course reserve pages to use grid layout for forms This patch updates course reserve templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Course reserves -> New course - Course reserves -> Course -> Add reserves - Course reserves -> Course -> Batch add reserves - Course reserves -> Course -> Batch remove reserves Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195460|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 195462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195462&action=edit Bug 42099: Update course reserve pages to use grid layout for forms This patch updates course reserve templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Course reserves -> New course - Course reserves -> Course -> Add reserves - Course reserves -> Course -> Batch add reserves - Course reserves -> Course -> Batch remove reserves Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195462|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 195841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195841&action=edit Bug 42099: Update course reserve pages to use grid layout for forms This patch updates course reserve templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Course reserves -> New course - Course reserves -> Course -> Add reserves - Course reserves -> Course -> Batch add reserves - Course reserves -> Course -> Batch remove reserves Sponsored-by: Athens County Public Libraries Signed-off-by: Gretchen Maxeiner <maxeinergl@gcc.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maxeinergl@gcc.edu --- Comment #4 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- I am signing off with a few comments/suggestions: 1. I believe Course reserves -> Course -> Batch remove reserves should be Course reserves - > Batch remove reserves? I didn't find this option within the Course screen. 2. The Staff note/Public note boxes are consistently small and seem to be a fixed width. It would be nice to see these more in line with the width of the other boxes on screen. (These are in New course, Add reserves- followup screen, and 2 places in Batch add reserves) 3. The checkboxes aren't positioned as nicely as before - rather than sitting in front of the drop box for Item type, Collection, etc., they now sit above it. They seem squished and don't seem in-line. The instructional text ("...box next to the field label...") also doesn't seem as accurate now. If it is possible to put those in-line with the dropbox rather than in front of it, I would prefer that. This display in in the Add reserves- followup screen, the Batch add reserves, and the edit reserve screen. 4. In Batch add reserves, could the text be changed from "Add items: scan barcodes" to "Add items by barcode" so it matches the text changes on the other screens? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|41823 |41842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41823 [Bug 41823] Update acquisitions admin pages to use grid layout for forms https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41842 [Bug 41842] Improve translation of course reserves headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Status|ASSIGNED |Needs Signoff Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195841|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199353&action=edit Bug 42099: Update course reserve pages to use grid layout for forms This patch updates course reserve templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Course reserves -> New course - Course reserves -> Course -> Add reserves - Course reserves -> Course -> Batch add reserves - Course reserves -> Course -> Batch remove reserves Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.mathevet@inLibro.com Status|Needs Signoff |Failed QA --- Comment #6 from Chris Mathevet <chris.mathevet@inLibro.com> --- Course reserves -> New course "Term" and "Instructors" texts should be aligned correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199534&action=edit Bug 42099: (follow-up) Fix alignment of label Patch from commit 840c9da -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 --- Comment #8 from Chris Mathevet <chris.mathevet@inLibro.com> --- Created attachment 199535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199535&action=edit Not properly aligned text when no TERM values defined If there are no TERM authorised values, the text is not aligned properly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199536&action=edit Screenshot of problem in main I don't believe we can expect everything to be pixel-perfect. The new layout is better than what we have now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 --- Comment #10 from Chris Mathevet <chris.mathevet@inLibro.com> --- (In reply to Owen Leonard from comment #9)
Created attachment 199536 [details] Screenshot of problem in main
I don't believe we can expect everything to be pixel-perfect. The new layout is better than what we have now.
Oh sure, I am going to sign this off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199534|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 --- Comment #11 from Chris Mathevet <chris.mathevet@inLibro.com> --- Created attachment 199537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199537&action=edit Bug 42099: (follow-up) Fix alignment of label Signed-off-by: Chris Mathevet <chris.mathevet@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42099 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org