[Bug 16215] New: Missing closing quote in checkout template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16215 Bug ID: 16215 Summary: Missing closing quote in checkout template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/circulation.pl?borrowernumber=X OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Circulation Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com There is a missing closing quote in circulation.tt on line 411: <button type="submit" class="deny"><i class="fa fa-times></i> Continue</button> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16215 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16215 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49976&action=edit Bug 16215 - Missing closing quote in checkout template This patch adds a missing closing quote to the circulation template. To see the affect of this bug: - Log in to Koha with an account which does not have the 'force_checkout' permission. - Locate a barcode which is checked out to a patron. - Open a different patron account for checkout. - Try to check out the barcode to that different patron. You see a "Cannot check out" dialog which breaks the structure of the rest of the page. To test, apply the patch and repeat the steps above. The issue should be fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16215 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16215 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49976|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 49996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49996&action=edit [SIGNED-OFF]Bug 16215: Missing closing quote in checkout template This patch adds a missing closing quote to the circulation template. To see the affect of this bug: - Log in to Koha with an account which does not have the 'force_checkout' permission. - Locate a barcode which is checked out to a patron. - Open a different patron account for checkout. - Try to check out the barcode to that different patron. You see a "Cannot check out" dialog which breaks the structure of the rest of the page. To test, apply the patch and repeat the steps above. The issue should be fixed. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16215 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16215 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |15821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 [Bug 15821] Use Font Awesome icons in confirmation dialogs - Circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16215 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16215 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49996|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50001&action=edit Bug 16215: Missing closing quote in checkout template This patch adds a missing closing quote to the circulation template. To see the affect of this bug: - Log in to Koha with an account which does not have the 'force_checkout' permission. - Locate a barcode which is checked out to a patron. - Open a different patron account for checkout. - Try to check out the barcode to that different patron. You see a "Cannot check out" dialog which breaks the structure of the rest of the page. To test, apply the patch and repeat the steps above. The issue should be fixed. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16215 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16215 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org