[Bug 37586] New: Masthead link accessibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Bug ID: 37586 Summary: Masthead link accessibility Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Accessibility Assignee: Laura.escamilla@bywatersolutions.com Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, oleonard@myacpl.org When the OPAC screen width is reduced, the link texts "Log in to your account", "Cart" and "Lists" are removed, causing the links to lose their text alternative. This violates accessibility guidelines which require that all links have a text alternative, even if it is not visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 170118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170118&action=edit Bug 37586: Added aria-labels to the masthead links. 1. **Check the OPAC Interface**: - Open the OPAC in a normal-sized browser window. - You’ll see the text next to the 'Cart' and 'Login' icons clearly. - Gradually reduce the window size until the text next to these icons disappears. - Inspect the icon elements. You’ll find that there is no alternative text (like `aria-label`) provided for these links. This lack of alternative text is an accessibility issue. 2. **Apply the Patch**: - Implement the provided patch to address the accessibility issue. - Restart_all 3. **Verify the Fix**: - Inspect the icons again. - For the 'Cart' icon, you should see an `aria-label` attribute with the text "View your shopping cart". - For the 'Login' icon, you should see an `aria-label` attribute with the text "Log in to your account". - These changes will improve accessibility for users relying on screen readers. 4. **Sign Off**: - Sign off and Have an amazing day! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Note: In my original description I listed the "Lists" icon as an issue but I was incorrect. It already has it's own aria-label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 170134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170134&action=edit Bug 37586: Updated aria-labels for masthead links Update to my last comment: The Lists aria-label had an accessibility issue as the label did not match the visible text. New test plan: Check the OPAC Interface: * Open the OPAC in a normal-sized browser window. * You’ll see the text next to the 'Cart', 'Lists', and 'Login' icons clearly. * Gradually reduce the window size until the text next to these icons disappears. * Inspect the icon elements. You’ll find that there is no alternative text (like aria-label) provided for 'Cart' and 'Login'. The aria-label for 'Lists' does not match the visible text. It currently says "Show dropdown with detailed list information". This lack of alternative text is an accessibility issue and labels should match visible text. Apply the Patch: * Apply the patch * Restart_all Verify the Fix: * Inspect the icons again. * For the 'Cart' icon, you should see an aria-label attribute with the text "View your shopping cart". * For the 'Login' icon, you should see an aria-label attribute with the text "Log in to your account". * For the 'Lists' icon, you should see an updated aria-label attribute with the new text of "Lists". * These changes will improve accessibility for users relying on screen readers. Sign Off: * Sign off and Have an amazing day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170118|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 170135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170135&action=edit Bug 37586: Added aria-label for Login icon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.hunstein@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #5 from Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> --- Hi Laura, the text I see in OPAC doesn't match to the test plan. Can you please check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Hi Nicholas, Were all the labels not matching or just a specific one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off --- Comment #7 from Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> --- Hello Laura, i don't see the new texts for all icons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |accessibility -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170134|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170472&action=edit Bug 37586: Updated aria-labels for masthead links Update to my last comment: The Lists aria-label had an accessibility issue as the label did not match the visible text. New test plan: Check the OPAC Interface: * Open the OPAC in a normal-sized browser window. * You’ll see the text next to the 'Cart', 'Lists', and 'Login' icons clearly. * Gradually reduce the window size until the text next to these icons disappears. * Inspect the icon elements. You’ll find that there is no alternative text (like aria-label) provided for 'Cart' and 'Login'. The aria-label for 'Lists' does not match the visible text. It currently says "Show dropdown with detailed list information". This lack of alternative text is an accessibility issue and labels should match visible text. Apply the Patch: * Apply the patch * Restart_all Verify the Fix: * Inspect the icons again. * For the 'Cart' icon, you should see an aria-label attribute with the text "View your shopping cart". * For the 'Login' icon, you should see an aria-label attribute with the text "Log in to your account". * For the 'Lists' icon, you should see an updated aria-label attribute with the new text of "Lists". * These changes will improve accessibility for users relying on screen readers. Sign Off: * Sign off and Have an amazing day! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170135|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170473&action=edit Bug 37586: Added aria-label for Login icon Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, it looks like something went wrong with the status here. I only see a sign-off from Lucas and Nicolas had trouble making the change visible (with me sitting next to him). Can we have another set of eyes please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170472|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170530&action=edit Bug 37586: Updated aria-labels for masthead links Update to my last comment: The Lists aria-label had an accessibility issue as the label did not match the visible text. New test plan: Check the OPAC Interface: * Open the OPAC in a normal-sized browser window. * You’ll see the text next to the 'Cart', 'Lists', and 'Login' icons clearly. * Gradually reduce the window size until the text next to these icons disappears. * Inspect the icon elements. You’ll find that there is no alternative text (like aria-label) provided for 'Cart' and 'Login'. The aria-label for 'Lists' does not match the visible text. It currently says "Show dropdown with detailed list information". This lack of alternative text is an accessibility issue and labels should match visible text. Apply the Patch: * Apply the patch * Restart_all Verify the Fix: * Inspect the icons again. * For the 'Cart' icon, you should see an aria-label attribute with the text "View your shopping cart". * For the 'Login' icon, you should see an aria-label attribute with the text "Log in to your account". * For the 'Lists' icon, you should see an updated aria-label attribute with the new text of "Lists". * These changes will improve accessibility for users relying on screen readers. Sign Off: * Sign off and Have an amazing day! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170473|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170531&action=edit Bug 37586: Added aria-label for Login icon Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great to see this getting looked at, thanks Laura. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Masthead link accessibility |Improve accessibility of | |top navigation in the OPAC | |with aria-labels -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.04 released in| | --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.04 |24.11.00,24.05.04,23.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m Patch complexity|--- |String patch Status|Pushed to stable |Pushed to oldstable --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #17 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #18 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37586 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |david@davidnind.com --- Comment #19 from David Nind <david@davidnind.com> --- No changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org