[Bug 22811] New: Add button to clear DataTables filtering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Bug ID: 22811 Summary: Add button to clear DataTables filtering Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Created attachment 89136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89136&action=edit Screen grab showing clear button interaction I propose that we add a "Clear filter" button to the global DataTables configuration which will be displayed if the table has a search form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89138&action=edit Bug 22811: Add button to clear DataTables filtering This patch adds a "clear filter" button to the global DataTables configuration. The button will appear if: - There is no custom DOM configuration applied to the DataTable instance. - The DataTable has the search form enabled. The new button should be disabled by default. Entering a search term in the form should enable it. To test, apply the patch and clear your browser cache if necessary. View various pages with various DataTables configurations and confirm that everything looks correct and the new "Clear filter" button doesn't appear when there is no DataTable search field. For example: - Administration -> Libraries - Administration -> Currencies - Reports -> Saved reports - Circulation -> Check out - Tools -> News -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89138|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89143&action=edit Bug 22811: Add button to clear DataTables filtering This patch adds a "clear filter" button to the global DataTables configuration. The button will appear if: - There is no custom DOM configuration applied to the DataTable instance. - The DataTable has the search form enabled. The new button should be disabled by default. Entering a search term in the form should enable it. To test, apply the patch and clear your browser cache if necessary. View various pages with various DataTables configurations and confirm that everything looks correct and the new "Clear filter" button doesn't appear when there is no DataTable search field. For example: - Administration -> Libraries - Administration -> Currencies - Reports -> Saved reports - Circulation -> Check out - Tools -> News Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Only thing maybe... I feel the buttons are a little big and the problem and I am sorry German translations will make it worse (why are our words so loooong?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89143|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89160&action=edit Bug 22811: Add button to clear DataTables filtering This patch adds a "clear filter" button to the global DataTables configuration. The button will appear if: - There is no custom DOM configuration applied to the DataTable instance. - The DataTable has the search form enabled. The new button should be disabled by default. Entering a search term in the form should enable it. To test, apply the patch and clear your browser cache if necessary. View various pages with various DataTables configurations and confirm that everything looks correct and the new "Clear filter" button doesn't appear when there is no DataTable search field. For example: - Administration -> Libraries - Administration -> Currencies - Reports -> Saved reports - Circulation -> Check out - Tools -> News Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22888 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22888 [Bug 22888] Use DataTables for Koha news table filtering -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org