[Bug 22318] New: Extend Koha news feature to include other content areas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Bug ID: 22318 Summary: Extend Koha news feature to include other content areas Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- There are many content areas in Koha where we currently use a single system preference to define a block of HTML which is embedded in the OPAC or Staff Client. Using system preferences for this requires that we either use only one language for the content or we use a convoluted system of CSS hiding/showing based on language. We already have a system in place for handling this better: The Koha news feature. We could add additional "display locations" for the various system preferences which could be migrated here: OpacNavRight, opacheader, OpacMainUserBlock, OPACMySummaryNote, OpacNav, OpacNavBottom, etc. This would allow libraries to define both language-specific and library-specific content for these areas of the interface. Being able to define start and end dates for content display would be really useful too. I imagine it would be inefficient to add multiple lines to, for instance, opac-main.pl for each "location," like so: my $OpacNavRight = GetNewsToDisplay( "OpacNavRight_".$news_lang, $homebranch ); Perhaps a template plugin and a block like this? [% PROCESS koha_news news => GetKohaNews( location => news_lang, library => homebranch ) %] I'd love to hear what y'all think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 85132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85132&action=edit Bug 22318: Extend Koha news feature to include other content areas This patch lays the groundwork for using the Koha news tool to replace OPAC system preferences which embed HTML content in the Koha interface. This will allow multiple translations of these content blocks to be created. This adds a new template plugin, KohaNews. It has a single subroutine, get(), which takes three parameters: - "location" -- the area of the template where the content will appear. This will correspond to the system preference it replaces: OpacMainUserBlock, OpacNavRight, etc. - "lang" -- the user's currently-selected language. - "library" -- the user's home library (if they are logged in) A new "koha_news_block" block is added to the OPAC templates' html_helpers include. The content area is activated in the template using this syntax: [% PROCESS koha_news_block news => KohaNews.get( location => "OpacNavRight", lang => news_lang, library => branchcode ) %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 85133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85133&action=edit Bug 22318: Example implementation: OpacNavRight system preference This patch implements a Koha news system replacement of the OpacNavRight system preference. The changes to koha-news.tt enable the selection of "OpacNavRight" as a location for the content. opac-main.pl is modified to ensure that the user's selected language is passed to the template for use by the KohaNews plugin. The database update process takes the contents of Koha's OpacNavRight system preference and adds it to the Koha news system. The OpacNavRight system preference is then removed from the database. When the new entry is added to Koha news, the language is set based on the top selected language in the "opaclanguages" preference. The entry is added to "All libraries" without an author, title, or expiration date. Note that this patch doesn't change the way OPAC news is displayed. I think it's best to keep existing markup and code for that since it handles details like branch selection and RSS. To test, apply the patch and run the database update. - In the staff client go to Tools -> News and confirm that there is now an entry with the location "OpacNavRight_en" (assuming an "en" English interface). - Confirm that the previous contents of OpacNavRight were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNavRight preference has been removed. - In the OPAC, confirm that the correct content is displayed in the region previously defined in the OpacNavRight system preference. - Test that the language and library-specific nature of news items is reflected in the behavior of this content area: - Define different text based on language and location. Confirm that switching translations and logging in to the OPAC both trigger the correct display of different content. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- One issue which these patches don't address is that if we move a system preference into the news system we lose the preference's description. That could probably be solved by adding some help information to the news entry template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- ...Another issue up for discussion is how the news system should be "rebranded" if we're adding general content management as a component. This will require a follow-up for that. "Content management" may carry too strong an implication that you can create whole pages. Content areas? Content blocks? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- But wait there's more: Some content blocks in the OPAC affect the layout of the page in such a way that it's necessary to check for the existence of the content in the template. How should that be handled? Another plugin method for counting results? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |black23@gmail.com --- Comment #6 from Michal Denar <black23@gmail.com> --- Hi, I tested patches on current master and get this errors: Falling back to patching base and 3-way merge... No changes -- Patch already applied. Applying: Bug 22318: Example implementation: OpacNavRight system preference Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt M opac/opac-main.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-main.pl CONFLICT (content): Merge conflict in opac/opac-main.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt Auto-merging installer/data/mysql/sysprefs.sql error: Failed to merge in the changes. Owen, can you rebase patches na master? Thank you -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85133|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86728&action=edit Bug 22318: Example implementation: OpacNavRight system preference This patch implements a Koha news system replacement of the OpacNavRight system preference. The changes to koha-news.tt enable the selection of "OpacNavRight" as a location for the content. opac-main.pl is modified to ensure that the user's selected language is passed to the template for use by the KohaNews plugin. The database update process takes the contents of Koha's OpacNavRight system preference and adds it to the Koha news system. The OpacNavRight system preference is then removed from the database. When the new entry is added to Koha news, the language is set based on the top selected language in the "opaclanguages" preference. The entry is added to "All libraries" without an author, title, or expiration date. Note that this patch doesn't change the way OPAC news is displayed. I think it's best to keep existing markup and code for that since it handles details like branch selection and RSS. To test, apply the patch and run the database update. - In the staff client go to Tools -> News and confirm that there is now an entry with the location "OpacNavRight_en" (assuming an "en" English interface). - Confirm that the previous contents of OpacNavRight were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNavRight preference has been removed. - In the OPAC, confirm that the correct content is displayed in the region previously defined in the OpacNavRight system preference. - Test that the language and library-specific nature of news items is reflected in the behavior of this content area: - Define different text based on language and location. Confirm that switching translations and logging in to the OPAC both trigger the correct display of different content. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Rebased on top of Bug 14272. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85132|0 |1 is obsolete| | Attachment #86728|0 |1 is obsolete| | --- Comment #9 from Michal Denar <black23@gmail.com> --- Created attachment 86730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86730&action=edit Bug 22318: Extend Koha news feature to include other content areas This patch lays the groundwork for using the Koha news tool to replace OPAC system preferences which embed HTML content in the Koha interface. This will allow multiple translations of these content blocks to be created. This adds a new template plugin, KohaNews. It has a single subroutine, get(), which takes three parameters: - "location" -- the area of the template where the content will appear. This will correspond to the system preference it replaces: OpacMainUserBlock, OpacNavRight, etc. - "lang" -- the user's currently-selected language. - "library" -- the user's home library (if they are logged in) A new "koha_news_block" block is added to the OPAC templates' html_helpers include. The content area is activated in the template using this syntax: [% PROCESS koha_news_block news => KohaNews.get( location => "OpacNavRight", lang => news_lang, library => branchcode ) %] Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #10 from Michal Denar <black23@gmail.com> --- Created attachment 86731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86731&action=edit Bug 22318: Example implementation: OpacNavRight system preference This patch implements a Koha news system replacement of the OpacNavRight system preference. The changes to koha-news.tt enable the selection of "OpacNavRight" as a location for the content. opac-main.pl is modified to ensure that the user's selected language is passed to the template for use by the KohaNews plugin. The database update process takes the contents of Koha's OpacNavRight system preference and adds it to the Koha news system. The OpacNavRight system preference is then removed from the database. When the new entry is added to Koha news, the language is set based on the top selected language in the "opaclanguages" preference. The entry is added to "All libraries" without an author, title, or expiration date. Note that this patch doesn't change the way OPAC news is displayed. I think it's best to keep existing markup and code for that since it handles details like branch selection and RSS. To test, apply the patch and run the database update. - In the staff client go to Tools -> News and confirm that there is now an entry with the location "OpacNavRight_en" (assuming an "en" English interface). - Confirm that the previous contents of OpacNavRight were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNavRight preference has been removed. - In the OPAC, confirm that the correct content is displayed in the region previously defined in the OpacNavRight system preference. - Test that the language and library-specific nature of news items is reflected in the behavior of this content area: - Define different text based on language and location. Confirm that switching translations and logging in to the OPAC both trigger the correct display of different content. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86730|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86733&action=edit Bug 22318: Extend Koha news feature to include other content areas This patch lays the groundwork for using the Koha news tool to replace OPAC system preferences which embed HTML content in the Koha interface. This will allow multiple translations of these content blocks to be created. This adds a new template plugin, KohaNews. It has a single subroutine, get(), which takes three parameters: - "location" -- the area of the template where the content will appear. This will correspond to the system preference it replaces: OpacMainUserBlock, OpacNavRight, etc. - "lang" -- the user's currently-selected language. - "library" -- the user's home library (if they are logged in) A new "koha_news_block" block is added to the OPAC templates' html_helpers include. The content area is activated in the template using this syntax: [% PROCESS koha_news_block news => KohaNews.get( location => "OpacNavRight", lang => news_lang, library => branchcode ) %] Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86731|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86734&action=edit Bug 22318: Example implementation: OpacNavRight system preference This patch implements a Koha news system replacement of the OpacNavRight system preference. The changes to koha-news.tt enable the selection of "OpacNavRight" as a location for the content. opac-main.pl is modified to ensure that the user's selected language is passed to the template for use by the KohaNews plugin. The database update process takes the contents of Koha's OpacNavRight system preference and adds it to the Koha news system. The OpacNavRight system preference is then removed from the database. When the new entry is added to Koha news, the language is set based on the top selected language in the "opaclanguages" preference. The entry is added to "All libraries" without an author, title, or expiration date. Note that this patch doesn't change the way OPAC news is displayed. I think it's best to keep existing markup and code for that since it handles details like branch selection and RSS. To test, apply the patch and run the database update. - In the staff client go to Tools -> News and confirm that there is now an entry with the location "OpacNavRight_en" (assuming an "en" English interface). - Confirm that the previous contents of OpacNavRight were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNavRight preference has been removed. - In the OPAC, confirm that the correct content is displayed in the region previously defined in the OpacNavRight system preference. - Test that the language and library-specific nature of news items is reflected in the behavior of this content area: - Define different text based on language and location. Confirm that switching translations and logging in to the OPAC both trigger the correct display of different content. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Sorry, I found one issue here: On news list page, the filter above datatable does not contain OpacNavRight location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86743&action=edit Bug 22318: (follow-up) Add new options to new table filter form This patch adds the new language/location options to the form for filtering entries in the table of news items. Since this markup is duplicated twice in the template, its contents have been moved to a BLOCK. To test, apply the patch and go to Tools -> News. At the top of the table of news items the "Display location" form should show all options including OpacNavRight for all your enabled languages. Confirm that location/language selection still works correctly upon adding and editing news items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86743|0 |1 is obsolete| | --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86771&action=edit Bug 22318: (follow-up) Add new options to new table filter form This patch adds the new language/location options to the form for filtering entries in the table of news items. Since this markup is duplicated twice in the template, its contents have been moved to a BLOCK. To test, apply the patch and go to Tools -> News. At the top of the table of news items the "Display location" form should show all options including OpacNavRight for all your enabled languages. Confirm that location/language selection still works correctly upon adding and editing news items. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #14)
Created attachment 86743 [details] [review] Bug 22318: (follow-up) Add new options to new table filter form
Thanks for quick and nice follow-up Owen. Looking good. Passing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 [Bug 22544] Move C4:.NewsChannels to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m, | |jonathan.druart@bugs.koha-c | |ommunity.org, | |julian.maurice@biblibre.com | |, katrin.fischer@bsz-bw.de, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- I like this one, but I just want to make sure it has had enough eyes on it, can I get some more viewpoints on this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86733|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87490&action=edit Bug 22318: Extend Koha news feature to include other content areas This patch lays the groundwork for using the Koha news tool to replace OPAC system preferences which embed HTML content in the Koha interface. This will allow multiple translations of these content blocks to be created. This adds a new template plugin, KohaNews. It has a single subroutine, get(), which takes three parameters: - "location" -- the area of the template where the content will appear. This will correspond to the system preference it replaces: OpacMainUserBlock, OpacNavRight, etc. - "lang" -- the user's currently-selected language. - "library" -- the user's home library (if they are logged in) A new "koha_news_block" block is added to the OPAC templates' html_helpers include. The content area is activated in the template using this syntax: [% PROCESS koha_news_block news => KohaNews.get( location => "OpacNavRight", lang => news_lang, library => branchcode ) %] Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86734|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87491&action=edit Bug 22318: Example implementation: OpacNavRight system preference This patch implements a Koha news system replacement of the OpacNavRight system preference. The changes to koha-news.tt enable the selection of "OpacNavRight" as a location for the content. opac-main.pl is modified to ensure that the user's selected language is passed to the template for use by the KohaNews plugin. The database update process takes the contents of Koha's OpacNavRight system preference and adds it to the Koha news system. The OpacNavRight system preference is then removed from the database. When the new entry is added to Koha news, the language is set based on the top selected language in the "opaclanguages" preference. The entry is added to "All libraries" without an author, title, or expiration date. Note that this patch doesn't change the way OPAC news is displayed. I think it's best to keep existing markup and code for that since it handles details like branch selection and RSS. To test, apply the patch and run the database update. - In the staff client go to Tools -> News and confirm that there is now an entry with the location "OpacNavRight_en" (assuming an "en" English interface). - Confirm that the previous contents of OpacNavRight were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNavRight preference has been removed. - In the OPAC, confirm that the correct content is displayed in the region previously defined in the OpacNavRight system preference. - Test that the language and library-specific nature of news items is reflected in the behavior of this content area: - Define different text based on language and location. Confirm that switching translations and logging in to the OPAC both trigger the correct display of different content. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86771|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87492&action=edit Bug 22318: (follow-up) Add new options to new table filter form This patch adds the new language/location options to the form for filtering entries in the table of news items. Since this markup is duplicated twice in the template, its contents have been moved to a BLOCK. To test, apply the patch and go to Tools -> News. At the top of the table of news items the "Display location" form should show all options including OpacNavRight for all your enabled languages. Confirm that location/language selection still works correctly upon adding and editing news items. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87493&action=edit Bug 22318: (QA follow-up) Correct name of atomicupdate Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is really nice.. I've given it a second QA run as Nick requested.. I agree with everything Owen has said, it would be nice to rebrand 'News' to 'Content' or something as we're extending it's use.. but that can be a followup. It would be also be nice to add additional help to show where a 'location' is displayed.. I'm thinking a diagram with blocks highlighted.. either in the manual or right there in the news form template (but again, this could be a followup) Generally I really like this and it's a great start that could lead on to bigger things. It would be great to have a tree of bugs to convert each of the relevant sysprefs to this system. Passed QA (Again) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I took a quick look and I like it. 2 concerns maybe: The HTML editor of news editor is not very nice. For people now working with HTML and having complicated content in the prefs this will be a little harder to handle than before. I think once we move more prefs we should split display location into location and language, so the list is not as long. Having the location as 'group' and the languages below instead of the language as group could also help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The thing I dislike about the editor is that it has the modal for the HTML editor that requires you to 'update' and then 'save'. That adds a lot of steps for just seeing what you did. Not sure what we can do about it, but noting. Maybe we coudl add an option to work in plain text HTML not using the editor and Code Mirror highlighting instead? That's all for separate bugs - willing to file them later too if you agree :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I was secretly hoping a codemirror html editing mode might come as a followup for this.. I'm sure Owen was already working on using codemirror for the relevent sysprefs so it sort of follows they we could do that here too (again in a followup) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22659 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22660 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really like Code Mirror for SQL, I think it would be great to have it as an option here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22663 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11251 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8067 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 paxed <pasi.kallinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@koha-suomi.fi --- Comment #28 from paxed <pasi.kallinen@koha-suomi.fi> --- This is not picked up by the translation toolchain: koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt: [% SET location = "OPAC news" %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Just a note: there is bug 20307 that could have handled the translation part. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #30 from paxed <pasi.kallinen@koha-suomi.fi> --- or something like [% SET location = BLOCK %]OPAC news[% END %] would let the text be translatable while still being assigned into a variable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great new enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22783 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 [Bug 22783] 'Location' not picked up by translation toolchain -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22880 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 [Bug 22880] Convert opacheader system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement begins release notes| |work to move system | |preferences that include | |displayed text to the | |'News' module - this allows | |the user to define text in | |various languages and add | |ability for these | |preferences to show | |correctly in translated | |OPACs. | | | |Specifically, this | |patch set moves the | |'OPACNavRight' preference | |into the 'News' module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Kris Sinnaeve <kris.sinnaeve@etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |kris.sinnaeve@etf.edu Resolution|FIXED |--- --- Comment #32 from Kris Sinnaeve <kris.sinnaeve@etf.edu> --- Moving the contents of OpacNavRight to opac_news fails due to improper (no?) escaping: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+' at line 1 [for Statement "INSERT INTO opac_news (branchcode, lang, title, content ) VALUES (NULL, 'OpacNavRight_en', '', ' <a class="twitter-timeline" href="https://twitter.com/ETFLibrary" data-widget-id="702160486524186624">Tweets by @ETFLibrary</a> <script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+"://platform.twitter.com/widgets.js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script> ')"] at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 18220. In this example, OpacNavRight contains a script to embed a Twitter timeline. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23093 [Bug 23093] Error during upgrade of OpacNavRight preference to Koha news -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Kris Sinnaeve from comment #32)
Moving the contents of OpacNavRight to opac_news fails due to improper (no?) escaping
This issue belongs in a new bug report since this one has already been pushed to master: Bug 23093. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23253 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23253 [Bug 23253] OpacNavRight does not display if opacuserlogin disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794 [Bug 23794] Convert OpacMainUserBlock system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23795 [Bug 23795] Convert OpacCredits system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23796 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 [Bug 23796] Convert OpacCustomSearch system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797 [Bug 23797] Convert OpacLoginInstructions system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23798 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23798 [Bug 23798] Convert OpacMaintenanceNotice system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 11251 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24399 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24399 [Bug 24399] New permission to edit "system-level" news items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24766 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24766 [Bug 24766] Provide an option to show news blocks for all available languages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #35 from David Cook <dcook@prosentient.com.au> --- While I agree about moving the HTML system preferences out of the system preferences, wouldn't it make sense to re-brand the "News" to "Customize user interface" or "HTML Content Editor" or something like that? I imagine putting things under the "News" banner might just confuse library staff more than they're already confused. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug added: 25001 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25001 [Bug 25001] 'News' should be renamed now we are migrating other content blocks to it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #37 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #36)
Bug added: 25001
Cheers, Martin. You're a legend :). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24766 Depends on|24766 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24766 [Bug 24766] Provide an option to show news blocks for all available languages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26050 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 [Bug 26050] [OMNIBUS] Convert system preferences to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26467 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ruth@hiruthie.me --- Comment #38 from David Cook <dcook@prosentient.com.au> --- *** Bug 8067 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org