[Bug 13305] New: Fix tab order on three item editor forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 Bug ID: 13305 Summary: Fix tab order on three item editor forms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 33731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33731&action=edit Bug 13305: Fix tab order on three item editor forms While working on bug 10480, I stumbled over the tab order on the forms serials-edit, acqui/addorderiso2709 and services/itemrecorddisplay. They all depend on C4::Items::PrepareItemrecordDisplay. Most of the inputs get a tabindex=1, but some don't. This creates a rather weird tab order for keyboard users (like me). By adjusting one input from C4::Items and the select in those three templates, the tab order is fixed. Test plan: [1] Set system preference AcqCreateItem to "placing an order". [2] Tab through the item fields on addorderiso2709. To do so, go to the Acquisition module, open a basket and add an order from a staged file. Click Add orders, go to Item information. [3] Tab through items fields on services/itemrecorddisplay. You could do this by creating a URL with biblionumber and itemnumber. But you can also test it via Acquisition. The script additem.js calls this perl script to create the item blocks on neworderempty. So again add an order to a basket, but choose for "From a new empty record". [4] Tab through item fields on serials-edit. Go to subscription detail. Click Receive. Choose "Click to add item". (Note that this subscription should create an item record when receiving this serial.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10480 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Is there any valid reason for having a tabindex value attached to any of these fields? I would prefer a solution which removed 'tabindex="1"' from the generated code rather than one which adds it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #2)
Is there any valid reason for having a tabindex value attached to any of these fields? I would prefer a solution which removed 'tabindex="1"' from the generated code rather than one which adds it.
Removing it everywhere involves more code changes. This touches just four lines now. So you are theoretically right, but I chose the pragmatic approach here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Summary|Fix tab order on three item |Fix tab order in |editor forms |cataloguing/item editor --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Will try to submit the more complete one as a follow-up on work for bug 10480. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10480 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10480 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33731|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org