[Bug 22630] New: Allow to change homebranch in course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Bug ID: 22630 Summary: Allow to change homebranch in course reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 87355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87355&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87355|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87369&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This seems to work well, but something seems not right with course reserves so I couldn't test fully. I have filed bug 22652. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 [Bug 22652] Editing Course reserves is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hello, I 've seen that the problem mentionned in bug22652 also occured here for Shelving location and Home library. And we can't retrieve the field "home library" when we use the batch to add reserve course (gi-bin/koha/course_reserves/batch_add_items.pl), which is not consistent. Sonia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Status|Failed QA |Signed Off --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- With 22652 pushed maybe time to retest this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hello Liz, I've just test it few hours ago on a sandbox, so it was apllied on master. It doesn't work for me... but I'm looking forward to see it signed off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87369|0 |1 is obsolete| | --- Comment #7 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89037&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Have just retested this on a dockerbox, all looks ok by me, item is modified as I expected (on top of 22652) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, I did: - Apply the patch - restart_all - updatedatabase - dbic - restart_all Then I added 2 items to course reserves: 1) Leaving all unchanged - Everything shows up in the table correctly - OK - When editing, they all show "Leave unchanged" - OK - But: change all settings, they are not saved! - BOO! Logs show: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) [for Statement "UPDATE items SET itype=?,homebranch=?,holdingbranch=?,ccode=?,permanent_location=?,location=? WHERE itemnumber=?" with ParamValues: 0="", 1="", 2="", 3="", 4="", 5="", 6=14] at /home/vagrant/kohaclone/C4/Items.pm line 1811. ERROR in _koha_modify_item UPDATE items SET itype=?,homebranch=?,holdingbranch=?,ccode=?,permanent_location=?,location=? WHERE itemnumber=?: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at /home/vagrant/kohaclone/C4/Items.pm line 1814. 2) Change all values - The location is missing from the display summary table (empty) - BOO! - When editing, the home library shows as 'unchanged' - BOO! Sorry for the BOOs, but I think this still needs some work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #10 from Liz Rea <wizzyrea@gmail.com> --- (In reply to Katrin Fischer from comment #9)
Ok, I did:
- Apply the patch - restart_all - updatedatabase - dbic - restart_all
Then I added 2 items to course reserves:
1) Leaving all unchanged - Everything shows up in the table correctly - OK - When editing, they all show "Leave unchanged" - OK - But: change all settings, they are not saved! - BOO!
I just tested this again, and they were saved?
Logs show:
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) [for Statement "UPDATE items SET itype=?,homebranch=?,holdingbranch=?,ccode=?,permanent_location=?,location=? WHERE itemnumber=?" with ParamValues: 0="", 1="", 2="", 3="", 4="", 5="", 6=14] at /home/vagrant/kohaclone/C4/Items.pm line 1811. ERROR in _koha_modify_item UPDATE items SET itype=?,homebranch=?,holdingbranch=?,ccode=?,permanent_location=?,location=? WHERE itemnumber=?: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at /home/vagrant/kohaclone/C4/Items.pm line 1814.
I did not receive this message.
2) Change all values - The location is missing from the display summary table (empty) - BOO!
This appears on my screen, between collection and home library?
- When editing, the home library shows as 'unchanged' - BOO!
Legit, I missed this. :(
Sorry for the BOOs, but I think this still needs some work.
It does, but possibly not as much as all of this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89037|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 89741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89741&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 89742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89742&action=edit Bug 22630: Do not modify item fields if course reserve item says LEAVE UNCHANGED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 89743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89743&action=edit Bug 22630: Fix homebranch select's value in course item edit page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Initial patch rebased on master. The last two patches should fix mentioned issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22970 [Bug 22970] Allow to change homebranch in batch add course reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #15 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89741|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89742|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89743|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #16 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 90023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90023&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #17 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 90024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90024&action=edit Bug 22630: Do not modify item fields if course reserve item says LEAVE UNCHANGED Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #18 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 90025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90025&action=edit Bug 22630: Fix homebranch select's value in course item edit page Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #19 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90023|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90024|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90025|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #20 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 90026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90026&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #21 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 90027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90027&action=edit Bug 22630: Do not modify item fields if course reserve item says LEAVE UNCHANGED Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #22 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 90028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90028&action=edit Bug 22630: Fix homebranch select's value in course item edit page Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #23 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I have followed the test plan and everything was OK. I have also tested the situation where you remove one item from the course : the item's homebranch is reset to his initial value. But I haven't done the 7th step : prove t/db_dependent/CourseReserves/CourseItems.t Don't know how to do that.... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Liz Rea <wizzyrea@gmail.com> --- Hi, I was ready to sign this off but we have a test failure: # Failed test 'Item ccode should be set back to empty' # at t/db_dependent/CourseReserves/CourseItems.t line 167. # got: 'DVD' # expected: '' Have a look? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23083 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Andrew <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #25 from Andrew <andrew@bywatersolutions.com> --- *** Bug 23083 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 2 problems here, this is failed QA as an enhancement, but also happens to fix a critical bug - bug 23083. Could the bug fix be separated from the bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90026|0 |1 is obsolete| | --- Comment #27 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 91177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91177&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Sponsored-by: Université de Lyon 3 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90027|0 |1 is obsolete| | --- Comment #28 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 91178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91178&action=edit Bug 22630: Do not modify item fields if course reserve item says LEAVE UNCHANGED Sponsored-by: Université de Lyon 3 Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90028|0 |1 is obsolete| | --- Comment #29 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 91179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91179&action=edit Bug 22630: Fix homebranch select's value in course item edit page Sponsored-by: Université de Lyon 3 Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #30 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 91180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91180&action=edit Bug 22630: Allow _RevertFields to set an empty value to item field Sponsored-by: Université de Lyon 3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #31 from Maryse Simard <maryse.simard@inlibro.com> --- Applying: Bug 22630: Allow to change homebranch in course reserves Using index info to reconstruct a base tree... M C4/CourseReserves.pm M t/db_dependent/CourseReserves/CourseItems.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/CourseReserves/CourseItems.t CONFLICT (content): Merge conflict in t/db_dependent/CourseReserves/CourseItems.t Auto-merging C4/CourseReserves.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 22630: Allow to change homebranch in course reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91177|0 |1 is obsolete| | --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 91575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91575&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Sponsored-by: Université de Lyon 3 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91178|0 |1 is obsolete| | --- Comment #33 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 91576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91576&action=edit Bug 22630: Do not modify item fields if course reserve item says LEAVE UNCHANGED Sponsored-by: Université de Lyon 3 Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91179|0 |1 is obsolete| | --- Comment #34 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 91577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91577&action=edit Bug 22630: Fix homebranch select's value in course item edit page Sponsored-by: Université de Lyon 3 Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91180|0 |1 is obsolete| | --- Comment #35 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 91578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91578&action=edit Bug 22630: Allow _RevertFields to set an empty value to item field Sponsored-by: Université de Lyon 3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #36 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hello, there was a conflict when I tryed to install it on a sandbox : CONFLICT (content): Merge conflict in t/db_dependent/CourseReserves/CourseItems.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91575|0 |1 is obsolete| | Attachment #91576|0 |1 is obsolete| | Attachment #91577|0 |1 is obsolete| | Attachment #91578|0 |1 is obsolete| | --- Comment #37 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 92579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92579&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Sponsored-by: Université de Lyon 3 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #38 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 92580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92580&action=edit Bug 22630: Fix homebranch select's value in course item edit page Sponsored-by: Université de Lyon 3 Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #39 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased on master. Removed two patches because a similar fix was pushed in bug 22142 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #40 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I tested it according to the plan test and everything was fine. I also tried to modify the value changed by the reserve course, to delete one item in the course and to delete a course. Everything works fine, the value of the item return to their original values. It's OK for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #41 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by sonia bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #42 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 92603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92603&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Sponsored-by: Université de Lyon 3 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: sonia bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #43 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 92604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92604&action=edit Bug 22630: Fix homebranch select's value in course item edit page Sponsored-by: Université de Lyon 3 Signed-off-by: SONIA BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: sonia bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 [Bug 23727] Editing course reserve items is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED Keywords|Academy |rel_19_11_candidate --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The behaviour when editing items is really weird atm, I have filed a new bug 23727 - once this if fixed, this should be pretty straight forward. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tiny thing: Capitalization on course summary page needs to be fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd love for this to move now we got 23727 fixed, but sadly this no longer applies :( Could we get a rebase please? CONFLICT (content): Merge conflict in t/db_dependent/CourseReserves/CourseItems.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging course_reserves/add_items.pl CONFLICT (content): Merge conflict in course_reserves/add_items.pl Auto-merging C4/CourseReserves.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92603|0 |1 is obsolete| | Attachment #92604|0 |1 is obsolete| | --- Comment #47 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 103556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103556&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Sponsored-by: Université de Lyon 3 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #48 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Forgot to comment earlier, there is a QA tool fail about the boolean/tinyint. Can you please check/fix? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #50 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 103634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103634&action=edit Bug 22630: Update Koha::Schema::Result::CourseItem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #51 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 103635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103635&action=edit Bug 22630: Set is_boolean flag for course_items.homebranch_enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103556|0 |1 is obsolete| | --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103733&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Sponsored-by: Université de Lyon 3 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103634|0 |1 is obsolete| | --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103734&action=edit Bug 22630: Update Koha::Schema::Result::CourseItem Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103635|0 |1 is obsolete| | --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103735&action=edit Bug 22630: Set is_boolean flag for course_items.homebranch_enabled Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103736&action=edit Bug 22630: Fix capitalization Home Library -> Home library Holding Library -> Holding library Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is not a big change actually as it follows what is done for homebranch already. I'd be happy to see this in 20.05 as for the issues with the item editing in course reserves it already missed a few releases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #58 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow to change homebranch |Add ability to change the |in course reserves |homebranch in course | |reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105324&action=edit Bug 22630: Display correct "in storage" value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords|rel_20_11_target |additional_work_needed, | |rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #59)
Created attachment 105324 [details] [review] Bug 22630: Display correct "in storage" value
Last patch pushed to master for 20.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30585 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30585 [Bug 30585] Table settings for course_reserves_table are wrong due to lack of "Holding library" option -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org