[Bug 13095] New: An email will be sent shortly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 Bug ID: 13095 Summary: An email will be sent shortly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 32402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32402&action=edit Bug 13095: An email will be sent shortly This patch adjusts two instances where Koha says that an email has been sent while it is just enqueued (put in the message queue). The crontab example still suggests to run process_message_queue once an hour and the manual even speaks about 1-4 hours. In the process of selfregistration and sharing a shelf, I have adjusted the text "has been sent" to "will be sent shortly". This covers imo the one-hour frequency. When writing this patch, I have examined all calls of EnqueueLetter; I only found these two occurrences to be of interest. Note: I would recommend to increase this frequency in the documentation, but consider that for now to be outside the scope of this report. Test plan: [1] Self-register a new user with verification by email required. Look at the text when you submit your data. [2] Share a list with someone else. Look at the text when you submit the invitation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Notices |OPAC Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32402|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32640&action=edit Bug 13095: An email will be sent shortly This patch adjusts two instances where Koha says that an email has been sent while it is just enqueued (put in the message queue). The crontab example still suggests to run process_message_queue once an hour and the manual even speaks about 1-4 hours. In the process of selfregistration and sharing a shelf, I have adjusted the text "has been sent" to "will be sent shortly". This covers imo the one-hour frequency. When writing this patch, I have examined all calls of EnqueueLetter; I only found these two occurrences to be of interest. Note: I would recommend to increase this frequency in the documentation, but consider that for now to be outside the scope of this report. Test plan: [1] Self-register a new user with verification by email required. Look at the text when you submit your data. [2] Share a list with someone else. Look at the text when you submit the invitation. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32640|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32647&action=edit [PASSED QA] Bug 13095: An email will be sent shortly This patch adjusts two instances where Koha says that an email has been sent while it is just enqueued (put in the message queue). The crontab example still suggests to run process_message_queue once an hour and the manual even speaks about 1-4 hours. In the process of selfregistration and sharing a shelf, I have adjusted the text "has been sent" to "will be sent shortly". This covers imo the one-hour frequency. When writing this patch, I have examined all calls of EnqueueLetter; I only found these two occurrences to be of interest. Note: I would recommend to increase this frequency in the documentation, but consider that for now to be outside the scope of this report. Test plan: [1] Self-register a new user with verification by email required. Look at the text when you submit your data. [2] Share a list with someone else. Look at the text when you submit the invitation. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, small string change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org