https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20558 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20558 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #0)

What are the consequences of this?

There are no consequences. This is dead code. There are several issues here: [1] We should not allow to edit an authorised value to a field higher than 010 in MARC21. That make no sense ! [2] The template does not make a distinction between control fields lower than 010 and other ones. Look e.g. here: <span>Tab:[% subfield.tab | html %]</span> | $[% subfield.tagsubfield | html %] [% subfield.liblibrarian | html %] [% IF ( subfield.kohafield ) %][% subfield.kohafield | html %][% END %][% IF ( subfield.repeatable ) %], <span>repeatable</span>[% END %][% IF ( subfield.mandatory ) %], <span>Mandatory</span>[% END %][% IF ( subfield.seealso ) %], <span>See [% subfield.seealso | html %]</span>[% END %][% IF ( subfield.authorised_value ) %], [% subfield.authorised_value | html %][% END %][% IF ( subfield.authtypecode ) %], [% subfield.authtypecode | html %][% END %][% IF ( subfield.value_builder ) %], [% subfield.value_builder | html %][% END %] If a subfield has an AV it is listed, but if a controlfield<10 has one, it is not listed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20558 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- Yeah, that particular typo isn't dead code, it's obscure code displaying a selection for dead code in one particular instance. Steps to reproduce: 1. Administration - MARC bibliographic framework - Default framework - Actions - MARC Structure 2. For 000, Actions - Edit Tag 3. For Authorized value, select any defined one (doesn't matter, it doesn't do anything) and note the hint that "(if you select a value here, the indicators will be limited to the authorized value list)" 4. Save changes 5. Note that in the table of tags you were returned to, the AV you chose is listed in the Auth value column 6. Check the checkbox for "Display only used tags/subfields" 7. Note that the AV you chose is no longer shown in the Auth value column Per bug 2280, the AV you chose hasn't actually done anything since at least 2008, and thus probably has never done anything. And were someone to implement it (which they wouldn't, since a single AV for both indicators wouldn't ever actually be useful), they would need to implement the opposite of comment 1, since for indicators you want to disallow setting it for <10, not disallow setting it for >= 10. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.