[Bug 16378] New: Check-in of a barcode 1 leads to Error 500
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Bug ID: 16378 Summary: Check-in of a barcode 1 leads to Error 500 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To reproduce: - Go to cgi-bin/koha/circ/returns.pl (Home > Circulation > Check in) - Enter 2, hit Submit => Result: Check in message: No item with barcode 2 Nothing in intranet-error.log - Enter 1, hit Submit => Result: An error has occurred! Error 500 Intranet-error.log: returns.pl: No property outstanding! at /usr/share/kohaclone/Koha/Object.pm line 188 ...and about 10 more lines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Check-in of a barcode 1 |Overdues.pm: Can't call |leads to Error 500 |method "store" without a | |package or object reference --- Comment #1 from Marc Véron <veron@veron.ch> --- Ok, it's not related to the barcode 1. I had an item with barcode 1. Changed the barcode to 111. It is checked out to patron A. Returnig leads to the error as in comment above. Trying to check out to a patron B leads to: Software error Can't call method "store" without a package or object reference at /usr/share/kohaclone/C4/Overdues.pm line 584. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 --- Comment #2 from Marc Véron <veron@veron.ch> --- Found: Overdues.pm line 588 tries to do an $accountline->set with column outstanding instead of amountoutstanding. Patch follows. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 50888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50888&action=edit Bug 16378: Overdues.pm: Can't call method "store" without a package or object reference Overdues.pm line 588 tries to do an $accountline->set with column outstanding instead of amountoutstanding. This patch fixes it. To test: - Verify that code change is correct. - Try to trigger a situation where an existing fine is updated (see comment in line 574 in C4/Overdues.pm) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50888|0 |1 is obsolete| | --- Comment #4 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 50894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50894&action=edit Bug 16378: Overdues.pm: Can't call method "store" without a package or object reference Overdues.pm line 588 tries to do an $accountline->set with column outstanding instead of amountoutstanding. This patch fixes it. To test: - Verify that code change is correct. - Try to trigger a situation where an existing fine is updated (see comment in line 574 in C4/Overdues.pm) Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |blocker --- Comment #5 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- This bug can be triggered as well when trying to run misc/cronjobs/fines.pl (on some database with overdued items): No property outstanding! at /home/koha/devkohaclone/C4/Overdues.pm line 584 Can't call method "store" without a package or object reference at /home/koha/devkohaclone/C4/Overdues.pm line 584. Without the patch, fine calculations are pretty much completely broken, overdued items are unreturnable and so on. Upping severity to 'blocker'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15675 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15675 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 [Bug 15675] Add issue_id column to accountlines and use it for updating fines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |abl@biblos.pk.edu.pl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50894|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 50905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50905&action=edit Bug 16378: Overdues.pm: Can't call method "store" without a package or object reference Overdues.pm line 588 tries to do an $accountline->set with column outstanding instead of amountoutstanding. This patch fixes it. To test: - Verify that code change is correct. - Try to trigger a situation where an existing fine is updated (see comment in line 574 in C4/Overdues.pm) Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16378 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |julian.maurice@biblibre.com Resolution|--- |FIXED --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org