[Bug 13496] New: Wrong Koha version on installer title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Bug ID: 13496 Summary: Wrong Koha version on installer title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Steps to reproduce: - Launch the webinstaller (I deleted my DB to do it) - The login screen shows => FAIL: "Koha 3.0 Installer" is hidden inside the code. It seems to be intended for screen readers to tell it (I cannot test that feature) but I think it is showing the wrong version, and it shouldn't. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 34777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34777&action=edit Bug 13496: add a method for the templates to print Koha version as desired This patch introduces a simple template plugin function that returns the Koha version number in different suitable formats. It introduces unit tests for the new function. They are run with To test: - Apply the patch - Run $ prove t/Koha_Template_Plugin_Koha.t => SUCCESS: the tests pass. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 34778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34778&action=edit Bug 13496: make auth.tt use a template plugin to get the Koha version This patch makes the installer login template use the new Koha.Version template plugin to get the correct Koha version. This way we don't need to maintain the auth.tt file on each version change, and are sure screen readers tell the correct version. To test: - Create a situation where the login screen from the installer shows - Navigate the HTML code (Ctrl+u) => FAIL: "Koha 3.0 Installer" shows on the HTML code - Apply the patch - Reload the page => SUCCESS: The correct version number is shown. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34777|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34852&action=edit Bug 13496: add a method for the templates to print Koha version as desired This patch introduces a simple template plugin function that returns the Koha version number in different suitable formats. It introduces unit tests for the new function. They are run with To test: - Apply the patch - Run $ prove t/Koha_Template_Plugin_Koha.t => SUCCESS: the tests pass. - Sign off :-D Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34778|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34853&action=edit Bug 13496: make auth.tt use a template plugin to get the Koha version This patch makes the installer login template use the new Koha.Version template plugin to get the correct Koha version. This way we don't need to maintain the auth.tt file on each version change, and are sure screen readers tell the correct version. To test: - Create a situation where the login screen from the installer shows - Navigate the HTML code (Ctrl+u) => FAIL: "Koha 3.0 Installer" shows on the HTML code - Apply the patch - Reload the page => SUCCESS: The correct version number is shown. - Sign off :-D Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34852|0 |1 is obsolete| | Attachment #34853|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34899&action=edit [PASSED QA] Bug 13496: add a method for the templates to print Koha version as desired This patch introduces a simple template plugin function that returns the Koha version number in different suitable formats. It introduces unit tests for the new function. They are run with To test: - Apply the patch - Run $ prove t/Koha_Template_Plugin_Koha.t => SUCCESS: the tests pass. - Sign off :-D Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34900&action=edit [PASSED QA] Bug 13496: make auth.tt use a template plugin to get the Koha version This patch makes the installer login template use the new Koha.Version template plugin to get the correct Koha version. This way we don't need to maintain the auth.tt file on each version change, and are sure screen readers tell the correct version. To test: - Create a situation where the login screen from the installer shows - Navigate the HTML code (Ctrl+u) => FAIL: "Koha 3.0 Installer" shows on the HTML code - Apply the patch - Reload the page => SUCCESS: The correct version number is shown. - Sign off :-D Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org