https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Version|24.11 |Main --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Test plan: 1) Enable ERMModule 2) Visit ERM: <staff_url>/cgi-bin/koha/erm/erm.pl 3) Notice you now have a 'dashboard' homepage showing 4 different widgets 4) Click 'Open Widget Picker'. Remove and add different widgets. Close 5) Drag and drop the widgets around the dashboard, from left to right, top to bottom 6) Click the context menu (vertical dots) on each of the widgets. Click 'move to right', 'move to left', 'remove'. 7) On the 'Licenses needing action', notice there is a 'Settings' item option. Click that, test different settings values. Close settings. 8) Using the widget picker or context menu for the respective widgets, remove all widgets except one. Click away i.e. 'Agreements' on the left menu. Go back to home by clicking 'Home'. Notice your dashboard is as you left it. 9) Enable all widgets, rearrange them by dragging and dropping in different places. Repeat the previous exercise. Notice the dashboard keeps the widgets arranged as you left them. 10) Add some test data, on k-t-d run: bash <(curl -s https://gist.githubusercontent.com/ammopt/8d74feff048b0732ed0362a204c3d8cd/r...) 11) Refresh the homepage dashboard, check the 'Counts' are correct and links work, check that the 'Latest SUSHI Counter jobs' table now populates and links to the data provider as well as respective job. 12) For 'Licenses needing action', test different settings values and confirm the table filters the results as expected. 13) As before, click away and comeback to ERM home. Notice your 'Licenses needing actions' settings are kept as you left them. 14) For the 'eUsage report' widget, notice it says 'No saved reports are availble to run'. Create a new usage report at: <staff_url>/cgi-bin/koha/erm/eusage/reports 15) Click the 'Create report' tab, input the mandatory fields and enter a report name at the bottom of the page. Click 'Save report'. 16) Come back to ERM home. Notice the 'eUsage report' widget now shows a dropdown with a disabled 'Run' button. Pick the report you just created. Notice the 'Run' button is now enabled. Click 'Run'. Notice you get the report results screen (will show nothing as there is no usage data in this test exercise). 17) k-t-d: Run cypress tests (reset_all beforehand to clear test data): cypress run --spec t/cypress/integration/ERM/ModuleDashboard_spec.ts -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- This looks wrong: fetch/background-jobs-api-client.js + endpoint: "agreements", Actually there is no filtering on the SUSHI Counter jobs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #5 from Mathieu Saby <mathsabypro@gmail.com> --- It could of course be useful to ad a widget "agreements needing action". It was too complex to add ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Ludovic from comment #6)

This is a great idea and a very promising proposal! Creating a customizable dashboard for the ERM module would be a real asset for improving user experience and highlighting key data. However, there is currently no patch attached to this bug, so it’s not possible to proceed with testing or signoff. Could you please add the relevant patch

Hi Ludovic, the development is the linked branch: https://github.com/openfifth/koha/commits/bug_39320 I'm updating the status here to BLOCKED to reflect the fact that this bug is waiting on bug 38201 so it can be picked up again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #8 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187513&action=edit Bug 39320: Add new npm dependencies: vue-draggable-next vue-cookies -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #10 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187515&action=edit Bug 39320: Preparation: Add base and wrapper components As well as wrapper support components base-widget.js composable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #12 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187517&action=edit Bug 39320: Add ERM specific dashboard widgets -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #14 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187519&action=edit Bug 39320: Add FA icons to ERM Wwould be great to improve the way we load icons to be available everywhere in Vue instead of just the specific module but on a different scope. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #16 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187521&action=edit Bug 39320: Add Cypress tests Test plan: 1) Enable ERMModule 2) Visit ERM: <staff_url>/cgi-bin/koha/erm/erm.pl 3) Notice you now have a 'dashboard' homepage showing 4 different widgets 4) Click 'Open Widget Picker'. Remove and add different widgets. Close 5) Drag and drop the widgets around the dashboard, from left to right, top to bottom 6) Click the context menu (vertical dots) on each of the widgets. Click 'move to right', 'move to left', 'remove'. 7) On the 'Licenses needing action', notice there is a 'Settings' item option. Click that, test different settings values. Close settings. 8) Using the widget picker or context menu for the respective widgets, remove all widgets except one. Click away i.e. 'Agreements' on the left menu. Go back to home by clicking 'Home'. Notice your dashboard is as you left it. 9) Enable all widgets, rearrange them by dragging and dropping in different places. Repeat the previous exercise. Notice the dashboard keeps the widgets arranged as you left them. 10) Add some test data, on k-t-d run: bash <(curl -s https://gist.githubusercontent.com/ammopt/8d74feff048b0732ed0362a204c3d8cd/r...) 11) Refresh the homepage dashboard, check the 'Counts' are correct and links work, check that the 'Latest SUSHI Counter jobs' table now populates and links to the data provider as well as respective job. 12) For 'Licenses needing action', test different settings values and confirm the table filters the results as expected. 13) As before, click away and comeback to ERM home. Notice your 'Licenses needing actions' settings are kept as you left them. 14) For the 'eUsage report' widget, notice it says 'No saved reports are availble to run'. Create a new usage report at: <staff_url>/cgi-bin/koha/erm/eusage/reports 15) Click the 'Create report' tab, input the mandatory fields and enter a report name at the bottom of the page. Click 'Save report'. 16) Come back to ERM home. Notice the 'eUsage report' widget now shows a dropdown with a disabled 'Run' button. Pick the report you just created. Notice the 'Run' button is now enabled. Click 'Run'. Notice you get the report results screen (will show nothing as there is no usage data in this test exercise). 17) k-t-d: Run cypress tests (reset_all beforehand to clear test data): cypress run --spec t/cypress/integration/ERM/ModuleDashboard_spec.ts -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | URL|https://github.com/PTFS-Eur | |ope/koha/commits/bug_39320/ | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187515|0 |1 is obsolete| | --- Comment #18 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187522&action=edit Bug 39320: Preparation: Add base and wrapper components As well as wrapper support components base-widget.js composable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32277 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #20 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 187568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187568&action=edit Bug 39320: Remove 'extends' from the Home component -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187513|0 |1 is obsolete| | --- Comment #22 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187635&action=edit Bug 39320: Add new npm dependencies: vue-draggable-next vue-cookies Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187516|0 |1 is obsolete| | --- Comment #24 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187637&action=edit Bug 39320: Preparation: ERM counts API endpoint Required for the follow-up ERMCounts widget Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187518|0 |1 is obsolete| | --- Comment #26 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187639&action=edit Bug 39320: Add dashboard to ERM home Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187520|0 |1 is obsolete| | --- Comment #28 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187641&action=edit Bug 39320: Add 'home' left menu item to ERM This is a bit hacky, but after hours of fighting with this I wasn't able to come up with a better soltuion. I suspect stores/navigation.js is doing too much and changing too much of the default router-link behaviour but I may be wrong. Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187522|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187643&action=edit Bug 39320: Preparation: Add base and wrapper components As well as wrapper support components base-widget.js composable Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187568|0 |1 is obsolete| | --- Comment #32 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187645&action=edit Bug 39320: Remove 'extends' from the Home component Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #33 from Jonathan Druart <jonathan.druart@gmail.com> --- QA comments: 1. :deep CSS rules should be removed (or moved to css/vue.css) 2. Do we really need the /erm/counts route. It needs tests (missing btw), swagger spec, Mojo controller. When we could just hit /agreements count=1 and retrieve the X-Base-Total-Count headers. 3. Why store in cookie when you can use localstorage? (and don't need the new deps vue-cookies) 4. drag&drop - you cannot select something in a box, it automatically drag the box. Cannot we have a dedicated zone/icon for that drag&drop behaviour? 5. From the "Counts" widget the links are "#", we should link to eg. /agreements instead. It also generates a vue warning: """ [Vue Router warn]: history.state seems to have been manually replaced without preserving the necessary values. Make sure to preserve existing history state if you are manually calling history.replaceState: history.replaceState(history.state, '', url) """ 6. Links from the "Licenses needed action" are correct (http://localhost:8081/cgi-bin/koha/erm/licenses/1), but it fully reloads the app 7. ModuleDashboard/Widgets/ERMCounts.vue {{ $__("There are") }} It won't be correctly translatable, use placeholder (%s and format) instead. By the way I don't think you should use definition.labelSingular and definition.labelPlural here. It won't be translatable correctly in some languages. I don't have a suggestion to fix this and keep it in a loop however. 8. Widgets/ERMLatestSUSHIJobs.vue a. 117 0: ["show"], What's that? I see that in the second column: <a href="/cgi-bin/koha/erm/eusage/usage_data_providers/undefined" class="show" draggable="false"></a> b. The "View" job button: you are using a "viewJob" function. I think you should use the callback instead, see Vendors/VendorResource.vue, "Receive shipments" 712 callback: ({ id }, dt, event) => { 713 event.preventDefault(); 714 window.location.href = `/cgi-bin/koha/acqui/parcels.pl?booksellerid=${id}`; 715 }, 9. Job status Widgets/ERMLatestSUSHIJobs.vue 44 const job_statuses = [ 53 function get_job_status(status) { 54 const status_lib = job_statuses.find(s => s._id === status); 55 return status_lib ? status_lib._str : status; 56 } If we add a new status we will obviously forget this place. I wouldn't silently ignore an unknown status. Either we implement +string for /jobs or we raise an error. Also we are using the only occurrence of escapeHtml in all vue files, I would use escape_str (`return get_job_status(row.status).escapeHtml();`) 10. Cypress tests are failing: 1) ERM Module Dashboard Run eUsage report: AssertionError: Timed out retrying after 10000ms: Expected to find element: `.widget#ERMRunUsageReport .widget-content`, but never found it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #36 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188095&action=edit Bug 39320: (QA follow-up): Add counts API tests prove t/db_dependent/api/v1/erm_counts.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #38 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188097&action=edit Bug 39320: (QA follow-up): Fix counts links Use router-link instead of href='#' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #40 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188099&action=edit Bug 39320: (QA follow-up): Use %s and format for 'There are' translatability -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #42 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188101&action=edit Bug 39320: (QA follow-up): Fix cypress These tests have always passed for me running cypress on UI, before and after this patch. CLI tests however, were flaky and often times failed. It appears this is because each module refresh was flooding the server with HTTP requests causing the whole thing to bottleneck (?) With this patch, all widget requests are stubbed for every widget test, and tests now pass on CLI consistently. Passed 10/10 for me, whereas before it failed more often than passed. Run this: for i in {1..10}; do cypress run --spec t/cypress/integration/ERM/ModuleDashboard_spec.ts; done -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #44 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188103&action=edit Bug 39320: (QA follow-up): Add a handler for drag and drop -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #45 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188104&action=edit Bug 39320: (QA follow-up): Use escape_str instead of .escapeHtml -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #47 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim from comment #46) Thanks for the quick follow-ups!

...

2. Do we really need the /erm/counts route. It needs tests (missing btw), swagger spec, Mojo controller. When we could just hit /agreements count=1 and retrieve the X-Base-Total-Count headers.

Patch with tests added. Yes we need, otherwise it's 6 HTTP requests instead of 1 just to get counts.

Not convince. I'd like Tomas's POV on /counts.

...

5. From the "Counts" widget the links are "#", we should link to eg. /agreements instead. It also generates a vue warning: """ [Vue Router warn]: history.state seems to have been manually replaced without preserving the necessary values. Make sure to preserve existing history state if you are manually calling history.replaceState:

history.replaceState(history.state, '', url) """

Patch added. I've not seen the vue router warn before or after.

I've seen it again, then didn't recreate. I also got "[Vue Router warn]: Discarded invalid param(s) "agreement_id" when navigating." when moving from /agreements to /home. Logging it here for the records, not blocker.

...

7. ModuleDashboard/Widgets/ERMCounts.vue {{ $__("There are") }} It won't be correctly translatable, use placeholder (%s and format) instead. By the way I don't think you should use definition.labelSingular and definition.labelPlural here. It won't be translatable correctly in some languages. I don't have a suggestion to fix this and keep it in a loop however.

Patch added.

``` 120 const joined = parts.join(", "); 121 return $__("There are %s.").format(joined); ``` this is still impossible to translate I have no idea how to fix that, or... we cheat? what about moving the list to ul/li? ``` There are: 1 agreement 0 license etc. ```

...

8. Widgets/ERMLatestSUSHIJobs.vue b. The "View" job button: you are using a "viewJob" function. I think you should use the callback instead, see Vendors/VendorResource.vue, "Receive shipments" 712 callback: ({ id }, dt, event) => { 713 event.preventDefault(); 714 window.location.href = `/cgi-bin/koha/acqui/parcels.pl?booksellerid=${id}`; 715 },

Using viewJob is the same as using 'show' which is what we're using elsewhere in the framework for KohaTable action buttons.

Yes, but it's more verbose... Not blocker.

...

9. Job status Widgets/ERMLatestSUSHIJobs.vue 44 const job_statuses = [

53 function get_job_status(status) { 54 const status_lib = job_statuses.find(s => s._id === status); 55 return status_lib ? status_lib._str : status; 56 }

If we add a new status we will obviously forget this place. I wouldn't silently ignore an unknown status.

It's not silently ignoring an unknown status. It prints the untranslatable status code if it doesn't find a match.

Yes, so it's not visible, and for me it means it's ignored :) We are supposed to have this list updated when we add a new status to the job table. If we add "paused", devs will look at the regular pl/pm/tt, but for sure forget this vue file. I would display "Status unknown" or "Status unknown: ${status}" (or even alert) so we clearly see there is something missing in the code. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #49 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188151&action=edit Bug 39320: (follow-up) Add counts API tests Prevent tests to fail if data in DB -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #50 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188279&action=edit Bug 39320: (QA follow-up): Add an empty drop area placeholder -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #52 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188281&action=edit Bug 39320: (QA follow-up): Fix ERMCounts translatability -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #54 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Jonathan Druart from comment #47)

``` 120 const joined = parts.join(", "); 121 return $__("There are %s.").format(joined); ```

this is still impossible to translate

I have no idea how to fix that, or... we cheat?

what about moving the list to ul/li?

``` There are:

1 agreement 0 license etc. ```

Fixed by: 1) Dropped the previous 'Use %s and format for 'There are' translatability' patch. 2) New patch 'Fix ERMCounts translatability' + 'Style new ERMCounts list' patches

Yes, so it's not visible, and for me it means it's ignored :) We are supposed to have this list updated when we add a new status to the job table. If we add "paused", devs will look at the regular pl/pm/tt, but for sure forget this vue file. I would display "Status unknown" or "Status unknown: ${status}" (or even alert) so we clearly see there is something missing in the code.

Patch 'Display Uknown status' added. (In reply to Jonathan Druart from comment #48)

11. drap&drop If all widgets are on the left you cannot drop in the right column.

Not true, you can, but maybe it's visually obvious. Patch 'Add an empty drop area placeholder' added. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188281|0 |1 is obsolete| | --- Comment #56 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188283&action=edit Bug 39320: (QA follow-up): Fix ERMCounts translatability -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188283|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #58 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188285&action=edit Bug 39320: (QA follow-up): Style new ERMCounts list -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #60 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188312&action=edit Bug 39320: Use __n for languages with 3 plural forms (or more) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #62 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #61)

(In reply to Pedro Amorim from comment #54)

...

(In reply to Jonathan Druart from comment #48)

...

11. drap&drop If all widgets are on the left you cannot drop in the right column.

Not true, you can, but maybe it's visually obvious. Patch 'Add an empty drop area placeholder' added.

I can assure you that I couldn't drop a widget to the right when they were all on the left.

Now with the last patches we have a "Drop widget here" area that is always displayed. IMO it should be displayed only when dragging.

There is the "move right" workaround. We can move that to a separate bug if it is not trivial (but then I would suggest to obsolete 'Add an empty drop area placeholder') -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #64 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #47)

(In reply to Pedro Amorim from comment #46)

...

...

2. Do we really need the /erm/counts route. It needs tests (missing btw), swagger spec, Mojo controller. When we could just hit /agreements count=1 and retrieve the X-Base-Total-Count headers.

Patch with tests added. Yes we need, otherwise it's 6 HTTP requests instead of 1 just to get counts.

Not convince. I'd like Tomas's POV on /counts.

Tomas, we are still waiting for you here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #66 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188372&action=edit Bug 39320: (QA follow-up): Remove big 'Processing...' when loading table widgets This prevents the big centered 'Processing...' from showing when moving widgets around the dashboard. Keeps the 'Loading...' at the widget level for table widgets, same as any other widget. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188375|0 |1 is obsolete| | --- Comment #68 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188376&action=edit Bug 39320: (QA follow-up): Fix widget with settings This was broken from the rewrite into bug 38201. Fixed here. Without this patch, if you click 'settings' on the licenses widgets and pick different values, you get errors on the console and everything breaks. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #70 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188637&action=edit Bug 39320: (ERMCounts QA follow-up): Use existing count method from the API client -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #72 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188639&action=edit Bug 39320: (ERMCounts QA follow-up): Reimplement loading. Now present 'Loading' for each resource count that's waiting, rather than hang the whole widget waiting for all responses -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #74 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188641&action=edit Bug 39320: (ERMCounts QA follow-up): Clean-up previous ERMCounts implementation -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #76 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188830&action=edit Bug 39320: Add new npm dependencies: vue-draggable-next vue-cookies Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #78 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188832&action=edit Bug 39320: Preparation: ERM counts API endpoint Required for the follow-up ERMCounts widget Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #80 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188834&action=edit Bug 39320: Add dashboard to ERM home Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #82 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188836&action=edit Bug 39320: Add 'home' left menu item to ERM This is a bit hacky, but after hours of fighting with this I wasn't able to come up with a better soltuion. I suspect stores/navigation.js is doing too much and changing too much of the default router-link behaviour but I may be wrong. Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #84 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188838&action=edit Bug 39320: Preparation: Add base and wrapper components As well as wrapper support components base-widget.js composable Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #86 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188840&action=edit Bug 39320: Remove 'extends' from the Home component Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #88 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188842&action=edit Bug 39320: (QA follow-up): Add counts API tests prove t/db_dependent/api/v1/erm_counts.t Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #90 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188844&action=edit Bug 39320: (QA follow-up): Fix counts links Use router-link instead of href='#' Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #92 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188846&action=edit Bug 39320: (QA follow-up): Removed unused show event Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #94 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188848&action=edit Bug 39320: (QA follow-up): Add a handler for drag and drop Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #96 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188850&action=edit Bug 39320: (follow-up) Add counts API tests Prevent tests to fail if data in DB Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #98 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188852&action=edit Bug 39320: (QA follow-up): Display 'Uknown status' if not one of the expected job statuses Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #100 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188854&action=edit Bug 39320: (QA follow-up): Style new ERMCounts list Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #102 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188856&action=edit Bug 39320: (QA follow-up): Only show 'drop widgets here' area when actively dragging Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #104 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188858&action=edit Bug 39320: (QA follow-up): Fix widget with settings This was broken from the rewrite into bug 38201. Fixed here. Without this patch, if you click 'settings' on the licenses widgets and pick different values, you get errors on the console and everything breaks. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #106 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188860&action=edit Bug 39320: (QA follow-up): Remove documents as an endpoint for listing that does not exist Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #108 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188862&action=edit Bug 39320: (QA follow-up): Update Cypress cypress run --spec t/cypress/integration/ERM/ModuleDashboard_spec.ts Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #110 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188864&action=edit Bug 39320: Fix ERM breadcrumb causing page reload The main ERM route was missing a 'name' property, causing the navigation store to treat it as an external path (.pl extension). This resulted in breadcrumb links using href instead of router-link, causing unwanted page reloads. To test: 1. Navigate to ERM module 2. Go to any sub-section (Agreements, Licenses, etc.) 3. Click on 'E-resource management' in the breadcrumb => FAIL: Notice the page reloads! 4. Apply the patch 5. Repeat steps 1-3 => SUCCES: Verify the page doesn't reload and navigation works smoothly 6. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187636|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187638|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187640|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187642|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187645|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188095|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188097|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188100|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188151|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188280|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188285|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188315|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188376|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188638|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188640|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Ludovic <ludovic.julien@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ludovic.julien@inLibro.com | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #113 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- I'm getting an error now when applying these patches: UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe1 in position 459: invalid continuation byte I think it may be because 'á' in 'Tomás' on the commit message but I'm not sure, not seen this before. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #115 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim from comment #113)

I'm getting an error now when applying these patches:

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe1 in position 459: invalid continuation byte

I think it may be because 'á' in 'Tomás' on the commit message but I'm not sure, not seen this before.

Reported https://gitlab.com/koha-community/perl-git-bz/-/issues/7 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188831|0 |1 is obsolete| | --- Comment #117 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188886&action=edit Bug 39320: VueJS framework: Add option to have a component in dialog Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188833|0 |1 is obsolete| | --- Comment #119 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188888&action=edit Bug 39320: Add ERM specific dashboard widgets Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188835|0 |1 is obsolete| | --- Comment #121 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188890&action=edit Bug 39320: Add FA icons to ERM Would be great to improve the way we load icons to be available everywhere in Vue instead of just the specific module but on a different scope. Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188837|0 |1 is obsolete| | --- Comment #123 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188892&action=edit Bug 39320: Add Cypress tests Test plan: 1) Enable ERMModule 2) Visit ERM: <staff_url>/cgi-bin/koha/erm/erm.pl 3) Notice you now have a 'dashboard' homepage showing 4 different widgets 4) Click 'Open Widget Picker'. Remove and add different widgets. Close 5) Drag and drop the widgets around the dashboard, from left to right, top to bottom 6) Click the context menu (vertical dots) on each of the widgets. Click 'move to right', 'move to left', 'remove'. 7) On the 'Licenses needing action', notice there is a 'Settings' item option. Click that, test different settings values. Close settings. 8) Using the widget picker or context menu for the respective widgets, remove all widgets except one. Click away i.e. 'Agreements' on the left menu. Go back to home by clicking 'Home'. Notice your dashboard is as you left it. 9) Enable all widgets, rearrange them by dragging and dropping in different places. Repeat the previous exercise. Notice the dashboard keeps the widgets arranged as you left them. 10) Add some test data, on k-t-d run: bash <(curl -s https://gist.githubusercontent.com/ammopt/8d74feff048b0732ed0362a204c3d8cd/r...) 11) Refresh the homepage dashboard, check the 'Counts' are correct and links work, check that the 'Latest SUSHI Counter jobs' table now populates and links to the data provider as well as respective job. 12) For 'Licenses needing action', test different settings values and confirm the table filters the results as expected. 13) As before, click away and comeback to ERM home. Notice your 'Licenses needing actions' settings are kept as you left them. 14) For the 'eUsage report' widget, notice it says 'No saved reports are availble to run'. Create a new usage report at: <staff_url>/cgi-bin/koha/erm/eusage/reports 15) Click the 'Create report' tab, input the mandatory fields and enter a report name at the bottom of the page. Click 'Save report'. 16) Come back to ERM home. Notice the 'eUsage report' widget now shows a dropdown with a disabled 'Run' button. Pick the report you just created. Notice the 'Run' button is now enabled. Click 'Run'. Notice you get the report results screen (will show nothing as there is no usage data in this test exercise). 17) k-t-d: Run cypress tests (reset_all beforehand to clear test data): cypress run --spec t/cypress/integration/ERM/ModuleDashboard_spec.ts Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #125 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188894&action=edit Bug 39320: Follow-up: Add 'move up' and 'move down' options Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188841|0 |1 is obsolete| | --- Comment #127 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188896&action=edit Bug 39320: (QA follow-up): Remove deep CSS rules This CSS is in vue.css anyway Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188843|0 |1 is obsolete| | --- Comment #129 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188898&action=edit Bug 39320: (QA follow-up): Use localStorage instead of vue-cookies Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188845|0 |1 is obsolete| | --- Comment #131 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188900&action=edit Bug 39320: (QA follow-up) Prevent full page reload when clicking a license Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188847|0 |1 is obsolete| | --- Comment #133 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188902&action=edit Bug 39320: (QA follow-up): Fix cypress These tests have always passed for me running cypress on UI, before and after this patch. CLI tests however, were flaky and often times failed. It appears this is because each module refresh was flooding the server with HTTP requests causing the whole thing to bottleneck (?) With this patch, all widget requests are stubbed for every widget test, and tests now pass on CLI consistently. Passed 10/10 for me, whereas before it failed more often than passed. Run this: for i in {1..10}; do cypress run --spec t/cypress/integration/ERM/ModuleDashboard_spec.ts; done Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188849|0 |1 is obsolete| | --- Comment #135 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188904&action=edit Bug 39320: (QA follow-up): Use escape_str instead of .escapeHtml Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188851|0 |1 is obsolete| | --- Comment #137 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188906&action=edit Bug 39320: (QA follow-up): Add an empty drop area placeholder Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188853|0 |1 is obsolete| | --- Comment #139 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188908&action=edit Bug 39320: (QA follow-up): Fix ERMCounts translatability Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188855|0 |1 is obsolete| | --- Comment #141 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188910&action=edit Bug 39320: Use __n for languages with 3 plural forms (or more) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188857|0 |1 is obsolete| | --- Comment #143 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188912&action=edit Bug 39320: (QA follow-up): Remove big 'Processing...' when loading table widgets This prevents the big centered 'Processing...' from showing when moving widgets around the dashboard. Keeps the 'Loading...' at the widget level for table widgets, same as any other widget. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #145 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188914&action=edit Bug 39320: (ERMCounts QA follow-up): Use existing count method from the API client Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #147 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188916&action=edit Bug 39320: (ERMCounts QA follow-up): Reimplement loading. Now present 'Loading' for each resource count that's waiting, rather than hang the whole widget waiting for all responses -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #149 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188918&action=edit Bug 39320: (ERMCounts QA follow-up): Clean-up previous ERMCounts implementation -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188839|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188860|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188862|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #151 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #111)

I wasn't able to run the tests successfully

I'm fairly certain this is a resource usage problem. For each of the widgets the full dashboard and all widgets are loaded every time. I've already stubbed all API requests which improved this massively but tests still sometimes fail if CPU is under heavy usage (from my testing). If I restart my laptop and immediately run the tests in headless they all pass every time. When running tests using the browser, all tests pass because oddly enough Cypress appears to use more resources when in headless mode. Adding this to e2e section in cypress.config.ts has also massively improved this but still stometimes (very rarely) fail: video: false, screenshotOnRunFailure: false, numTestsKeptInMemory: 0, In short, I believe there's nothing wrong with the tests, it's just they run too fast and use too many resources and sometimes fail because of it. Other opinions / approaches are welcome here of course. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #153 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #152)

Should we enable those options by default? It seems many problems we have with Cypress are related to this.

I'd say it's definitely worth having a discussion around it, for sure, but possibly in a different bug? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #155 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim from comment #153)

(In reply to Tomás Cohen Arazi (tcohen) from comment #152)

...

Should we enable those options by default? It seems many problems we have with Cypress are related to this.

I'd say it's definitely worth having a discussion around it, for sure, but possibly in a different bug?

It's already what is suggested on the wiki https://wiki.koha-community.org/wiki/Continuous_Integration#Run_a_specific_C... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188885|0 |1 is obsolete| | Attachment #188886|0 |1 is obsolete| | Attachment #188887|0 |1 is obsolete| | Attachment #188888|0 |1 is obsolete| | Attachment #188889|0 |1 is obsolete| | Attachment #188890|0 |1 is obsolete| | Attachment #188891|0 |1 is obsolete| | Attachment #188892|0 |1 is obsolete| | Attachment #188893|0 |1 is obsolete| | Attachment #188894|0 |1 is obsolete| | Attachment #188895|0 |1 is obsolete| | Attachment #188896|0 |1 is obsolete| | Attachment #188897|0 |1 is obsolete| | Attachment #188898|0 |1 is obsolete| | Attachment #188899|0 |1 is obsolete| | Attachment #188900|0 |1 is obsolete| | Attachment #188901|0 |1 is obsolete| | Attachment #188902|0 |1 is obsolete| | Attachment #188903|0 |1 is obsolete| | Attachment #188904|0 |1 is obsolete| | Attachment #188905|0 |1 is obsolete| | Attachment #188906|0 |1 is obsolete| | Attachment #188907|0 |1 is obsolete| | Attachment #188908|0 |1 is obsolete| | Attachment #188909|0 |1 is obsolete| | Attachment #188910|0 |1 is obsolete| | Attachment #188911|0 |1 is obsolete| | Attachment #188912|0 |1 is obsolete| | Attachment #188913|0 |1 is obsolete| | Attachment #188914|0 |1 is obsolete| | Attachment #188915|0 |1 is obsolete| | Attachment #188916|0 |1 is obsolete| | Attachment #188917|0 |1 is obsolete| | Attachment #188918|0 |1 is obsolete| | Attachment #188919|0 |1 is obsolete| | Attachment #188932|0 |1 is obsolete| | --- Comment #157 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188938&action=edit Bug 39320: Add new npm dependencies: vue-draggable-next vue-cookies Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #159 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188940&action=edit Bug 39320: Preparation: ERM counts API endpoint Required for the follow-up ERMCounts widget Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #161 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188942&action=edit Bug 39320: Add dashboard to ERM home Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 --- Comment #163 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188944&action=edit Bug 39320: Add 'home' left menu item to ERM This is a bit hacky, but after hours of fighting with this I wasn't able to come up with a better soltuion. I suspect stores/navigation.js is doing too much and changing too much of the default router-link behaviour but I may be wrong. Sponsored-by: UKHSA (UK Health Security Agency) Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.