https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This is the string that is causing the problem #. %1$s: itemtypeloo.translated_description | html #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:374 #, c-format msgid "%s (All)" msgstr "%s (Toutes)" If I add fuzzy to the last commented line and reapply the translation, the problem goes away. #. %1$s: itemtypeloo.translated_description | html #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:374 #, fuzzy,c-format msgid "%s (All)" msgstr "%s (Toutes)" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #2 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 133364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133364&action=edit Bug 30517: Translation breaks editing parent type circulation rule fix Test plan: 1. Install another language in the staff interface 1. ./translate install xx-XX 2. Check the box of the language in the 'language' system preference 3. Refresh 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type (I created a 'Children's books' type and assigned 'Books' as its parent) 3. Create a circulation rule for the parent type (I created All/Books, with 10 checkouts allowed) 4. Create a circulation rule for All/All (I created All/All with 30 checkouts allowed) 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row stays on 'All' 9. Modify the number of checkouts allowed (e.g. 88) --> The All/All rule is modified 10. Apply the patch and refresh 11. Do step 8-9 again and notice it now behaves as it should -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #3 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 133404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133404&action=edit Bug 30517: Translation breaks editing parent type circulation rule fix Test plan: 1. Install another language in the staff interface 1. ./translate install xx-XX 2. Check the box of the language in the 'language' system preference 3. Refresh 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type (I created a 'Children's books' type and assigned 'Books' as its parent) 3. Create a circulation rule for the parent type (I created All/Books, with 10 checkouts allowed) 4. Create a circulation rule for All/All (I created All/All with 30 checkouts allowed) 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row stays on 'All' 9. Modify the number of checkouts allowed (e.g. 88) --> The All/All rule is modified 10. Apply the patch and refresh 11. Do step 8-9 again and notice it now behaves as it should -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, should this be Needs Signoff? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |shi-yao.wang@inLibro.com |ity.org | --- Comment #5 from Blou <philippe.blouin@inlibro.com> --- no interest? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Did you install the translations before or after the patch was applied? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #8 from Emmanuel Bétemps <e.betemps@gmail.com> --- (In reply to Katrin Fischer from comment #7)

Did you install the translations before or after the patch was applied?

I just followed the test plan : translation (french) installed before applying the patch. I can try applying the patch before installing the language. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133404|0 |1 is obsolete| | --- Comment #10 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139718&action=edit Bug 30517: Translation breaks editing parent type circulation rule fix Test plan: 1. Install another language in the staff interface 1. in commandline: `cd misc/translator/; ./translate install xx-XX` 2. Check the box of the language in the 'language' system preference and save 3. Refresh and you should be able to choose languages 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type (I created a 'Children's books' type and assigned 'Books' as its parent) 3. Create a circulation rule for the parent type (I created All/Books, with 10 checkouts allowed) 4. Create a circulation rule for All/All (I created All/All with 30 checkouts allowed) 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row stays on 'All' 9. Modify the number of checkouts allowed (e.g. 88) --> The All/All rule is modified 10. Apply the patch, translate again and refresh the page 11. Do step 8-9 again and notice it now behaves as it should -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Emmanuel Bétemps from comment #9)

I tested applying the patch and, after, installing the language.

Patch works better but some things bother me

1.I click on "Circulation and fines rules" 2.I click on the Edit button to modify "All / Books" 3. I save my changes -> I really modify "All / Books" -> the bottom line (i.e the one where we write our changes) resets

But sometimes, if I don't want to save my changes, I click on another line to edit (Koha asks me then if I am sure) but it doesn't change the bottom line.

When you install a language it copies the templates and files. So if you install the patch first, you'll look at unchanged/old templates that don't have the patch. You probably also need to make sure that "all" has been translated to something else in that language. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #15 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 140091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140091&action=edit Bottom line doesn't edit the chosen line -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139718|0 |1 is obsolete| | --- Comment #17 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 140193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140193&action=edit Bug 30517: Translation breaks editing parent type circulation rule fix Test plan: 1. Install another language in the staff interface 1. in commandline: `cd misc/translator/; ./translate install xx-XX` 2. Check the box of the language in the 'language' system preference and save 3. Refresh and you should be able to choose languages 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type (I created a 'Children's books' type and assigned 'Books' as its parent) 3. Create a circulation rule for the parent type (I created All/Books, with 10 checkouts allowed) 4. Create a circulation rule for All/All (I created All/All with 30 checkouts allowed) 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row stays on 'All' 9. Modify the number of checkouts allowed (e.g. 88) --> The All/All rule is modified 10. Apply the patch, translate again and refresh the page 11. Do step 8-9 again and notice it now behaves as it should Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Overall I am not super happy about the way we rely on a regex here, but have not managed to break behavior in my tests. So this fix works and that's the most important as this bug has been there for too long causing potential data loss. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldoldstable |Pushed to oldoldoldstable Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15 |21.11.15, 21.05.22 --- Comment #24 from wainuiwitikapark@catalyst.net.nz --- Backported to 21.05.x for 21.05.22 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldoldstable |RESOLVED --- Comment #26 from wainuiwitikapark@catalyst.net.nz --- (In reply to wainuiwitikapark from comment #25)

Not released in 21.05.22

Reverted from 21.05 branch -- You are receiving this mail because: You are watching all bug changes.