[Bug 39774] New: OPAC ILL Unauthenticated request details table not styled correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 Bug ID: 39774 Summary: OPAC ILL Unauthenticated request details table not styled correctly Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: pedro.amorim@openfifth.co.uk Reporter: pedro.amorim@openfifth.co.uk QA Contact: tomascohen@gmail.com CC: pedro.amorim@openfifth.co.uk, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181654&action=edit Bug 39774: Add id to wrapper This makes it so that the established styling (seen from request details page on OPAC, authenticated) is also applied here. To test, before applying patch: 1) Enabled ILLModule and ILLOpacUnauthenticatedRequest 2) Create an unauth OPAC request: logout and visit: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form 3) Enter the required fields, select type = 'Chapter', add some metadata info such as 'Place of publication', 'Publisher' and others. 4) Notice how the 'Request details' table is rendered, 'Place of publication' and 'Publisher' and misaligned. Apply patch. Refresh. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181654|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 181664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181664&action=edit Bug 39774: Add id to wrapper This makes it so that the established styling (seen from request details page on OPAC, authenticated) is also applied here. To test, before applying patch: 1) Enabled ILLModule and ILLOpacUnauthenticatedRequest 2) Create an unauth OPAC request: logout and visit: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form 3) Enter the required fields, select type = 'Chapter', add some metadata info such as 'Place of publication', 'Publisher' and others. 4) Notice how the 'Request details' table is rendered, 'Place of publication' and 'Publisher' and misaligned. Apply patch. Refresh. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 181665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181665&action=edit Screenshot - ILL request page after the patch I've signed off, as this improves the page. Is the data supposed to be aligned in the centre and formatted as a table, or should it be like the rest of the request above? (See screenshot.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181667&action=edit OPAC logged in request page (In reply to David Nind from comment #3)
I've signed off, as this improves the page.
Is the data supposed to be aligned in the centre and formatted as a table, or should it be like the rest of the request above? (See screenshot.)
Thank you David. The purpose of the patch is to bring the unauthenticated request page in line with the regular authenticated one (submitted as attachment). Further improvements can be discussed but that was not my goal with that patch specifically. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36197 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 [Bug 36197] Allow unauthenticated ILL requests in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to Pedro Amorim from comment #4)
Created attachment 181667 [details] OPAC logged in request page
(In reply to David Nind from comment #3)
I've signed off, as this improves the page.
Is the data supposed to be aligned in the centre and formatted as a table, or should it be like the rest of the request above? (See screenshot.)
Thank you David.
The purpose of the patch is to bring the unauthenticated request page in line with the regular authenticated one (submitted as attachment). Further improvements can be discussed but that was not my goal with that patch specifically.
That makes sense! Thanks. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181664|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 182225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182225&action=edit Bug 39774: Add id to wrapper This makes it so that the established styling (seen from request details page on OPAC, authenticated) is also applied here. To test, before applying patch: 1) Enabled ILLModule and ILLOpacUnauthenticatedRequest 2) Create an unauth OPAC request: logout and visit: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form 3) Enter the required fields, select type = 'Chapter', add some metadata info such as 'Place of publication', 'Publisher' and others. 4) Notice how the 'Request details' table is rendered, 'Place of publication' and 'Publisher' and misaligned. Apply patch. Refresh. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 36197 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |aude.charillon@openfifth.co | |.uk Resolution|--- |FIXED --- Comment #9 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No update to the Koha Manual needed. Screenshot with correct style will be added when documenting Bug 36197. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39774 Bug 39774 depends on bug 36197, which changed state. Bug 36197 Summary: Allow unauthenticated ILL requests in the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org