[Bug 17346] New: Enable the check in option in Columns settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Bug ID: 17346 Summary: Enable the check in option in Columns settings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: T.Reimann95@gmx.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Enable the option to disable the check-in column under Columns settings. This option is under the index tab : circulation and patrons. This option should be enabled, because the check-in is not necessary at this places, so if a library want to hide it, they should get the possibility. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |T.Reimann95@gmx.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tobias, This can be easily achieve by removing the 2 flags cannot_be_toggled and cannot_be_modified in the admin/columns_settings.yml Are you able to provide such a patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 61003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61003&action=edit Bug 17346: Make checkin column hidable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org Status|NEW |Needs Signoff --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Hope you don't mind. I took the liberty to write the patch. To test: 1) Go to columns_settings.pl --> Circulation --> issues-table and note that you cannot change the settings for checkin. 2) Go to columns_settings.pl --> Patrons --> issues-table and note that you cannot change the settings for checkin. 3) Apply the patch. 4) Go to both tables again and note that you can now change the settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61003|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 61012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61012&action=edit Bug 17346: Make checkin column hidable To test: 1) Go to columns_settings.pl --> Circulation --> issues-table and note that you cannot change the settings for checkin. 2) Go to columns_settings.pl --> Patrons --> issues-table and note that you cannot change the settings for checkin. 3) Apply the patch. 4) Go to both tables again and note that you can now change the settings. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|T.Reimann95@gmx.de |cbrannon@cdalibrary.org CC| |veron@veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I finally remember why the action columns were not modifiable. There is something wrong happening if you select checkin hidden by default and can be toggled. When you show it, the tr element "Today's checkouts" does not display correctly. Not sure how to fix that cleanly... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Jonathan Druart from comment #5)
I finally remember why the action columns were not modifiable. There is something wrong happening if you select checkin hidden by default and can be toggled. When you show it, the tr element "Today's checkouts" does not display correctly.
Not sure how to fix that cleanly...
I will look into it, but if I can't find a resolution, at least we can still lock the option to toggle it. That would be a reasonable compromise. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- Please QA again. It appears this is a pre-existing condition, and will happen with any column that is hidden by default and then toggled on. I will open a new ticket for this condition. Christopher -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61012|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61372&action=edit Bug 17346: Make checkin column hidable To test: 1) Go to columns_settings.pl --> Circulation --> issues-table and note that you cannot change the settings for checkin. 2) Go to columns_settings.pl --> Patrons --> issues-table and note that you cannot change the settings for checkin. 3) Apply the patch. 4) Go to both tables again and note that you can now change the settings. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18257 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Christopher! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Holding back on this because of comment#5 for the stable release. Please link the new bug with this one once opened. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #10)
Holding back on this because of comment#5 for the stable release. Please link the new bug with this one once opened.
Comment 5 was wrong and the behavior I described is not added by this patch. New bug is linked already, it's bug 18257. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |croseburg@ncrl.org --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 15441 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tiny change - I have decided to push this to 16.11.x. This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #14 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org