[Bug 29805] New: Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Bug ID: 29805 Summary: Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com It looks like this important database update is failing for MySql 5.7 because it lacks support of REGEXP_REPLACE. Upgrade to 21.05.00.016 [14:16:28]: Bug 24387 - Rename opac_news with additional_contents ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: FUNCTION koha.biblioteca.REGEXP_REPLACE does not exist at /usr/share/koha/lib/C4/Installer.pm line 738 Are we still supporting 5.7? If not, should we highlight that somewhere? We currently only list MariaDB versions on the wiki linked from release notes: https://wiki.koha-community.org/wiki/System_requirements_and_recommendations We are still listing MySQL here: https://koha-community.org/download-koha/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 5.7 is in Ubuntu Bionic/18.04: https://packages.ubuntu.com/search?keywords=mysql&searchon=names&suite=all§ion=all -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29778 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 [Bug 29778] Deleting additional_contents leaves entries for additional languages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129050&action=edit Bug 29805: Fix 21.05.00.016 for MySQL 5.7 MySQL 5.7 is in Ubuntu 18.04 and does not support REGEXP_REPLACE. We can easily rewrite it in Perl instead of dropping support on this Ubuntu LTS version. Test plan: checkout a commit prior to 21.05.00.016 Create a notice template with <<opac_news.content>> [%opac_news.content %] << opac_news.content>> [% opac_news.content %] Note that ISSUESLIP has already occurrence of 'opac_news.' git checkout a branch with master + this patch Run `updatedatabase` and notice that the 'opac_news.' occurrences have been replaced with 'additional_contents.' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129050|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129074&action=edit Bug 29805: Fix 21.05.00.016 for MySQL 5.7 MySQL 5.7 is in Ubuntu 18.04 and does not support REGEXP_REPLACE. We can easily rewrite it in Perl instead of dropping support on this Ubuntu LTS version. Test plan: checkout a commit prior to 21.05.00.016 Create a notice template with <<opac_news.content>> [%opac_news.content %] << opac_news.content>> [% opac_news.content %] Note that ISSUESLIP has already occurrence of 'opac_news.' git checkout a branch with master + this patch Run `updatedatabase` and notice that the 'opac_news.' occurrences have been replaced with 'additional_contents.' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29828 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Bug 29805 depends on bug 29778, which changed state. Bug 29778 Summary: Deleting additional_contents leaves entries for additional languages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tried to test but having trouble with ktd :( Checked out v20.11.13 and did a reset_all but ending up with errors not being able to access the GUI. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #4)
Tried to test but having trouble with ktd :( Checked out v20.11.13 and did a reset_all but ending up with errors not being able to access the GUI.
Maybe fixed - will try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Tried to test but having trouble with ktd :(
Was this ran before starting ktd? export KOHA_IMAGE=20.11-buster; So it's starts the Linux install OS (here Debian 10, Buster) with the perl deps installed that match the right Koha version. When switching from master to an older branch of Koha, one must stop ktd. Then sent the right KOHA_IMAGE because the default one if for master. And then start ktd. reset_all doesn't allow major version changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #6)
Tried to test but having trouble with ktd :(
Was this ran before starting ktd?
export KOHA_IMAGE=20.11-buster;
So it's starts the Linux install OS (here Debian 10, Buster) with the perl deps installed that match the right Koha version.
When switching from master to an older branch of Koha, one must stop ktd. Then sent the right KOHA_IMAGE because the default one if for master. And then start ktd. reset_all doesn't allow major version changes.
Hi Victor, thx for your help! I just switched to ktd and still learning. In this case, it was wrong permissions on my git repository that seemed to have cause the issue, something I need to figure out (but not on this bug :) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Signoff please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nick@bywatersolutions.com --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- We tested this on a sandbox we were upgrading - the upgrade failed but the DB still had opac_news in the letter content -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Katrin Fischer from comment #0)
Are we still supporting 5.7?
If not, should we highlight that somewhere?
We currently only list MariaDB versions on the wiki linked from release notes: https://wiki.koha-community.org/wiki/System_requirements_and_recommendations
We are still listing MySQL here: https://koha-community.org/download-koha/
Woops I only understand now why I was CCed here. The only CI running MySQL is for Master with MySQL 8 Since more than a year anything could break with MySQL 5.7 and we wouldn't notice it in any release. So maybe we didn't formally decided to not support it but the current state is not a support one. I added the question to the next meeting: https://wiki.koha-community.org/wiki/Development_IRC_meeting_3_August_2022 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |koha-bugs@lists.koha-commun |com |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32162 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38906 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org