[Bug 41903] New: Overdues reports in circulation module are too resource intensive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Bug ID: 41903 Summary: Overdues reports in circulation module are too resource intensive Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com The circ module includes reports "Overdues" and "Overdues with fines." Both are sufficiently resources intensive as to cause noticeable slowdowns on large systems when used during business hours. They should be rewritten using APIs and VUE to improve performance. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199008&action=edit Bug 41903: [DO NOT PUSH] Data script Patch from commit 9c17c3e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199009&action=edit Bug 41903: Add checkout GET endpoints to the api-client Patch from commit f6d67fa -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199010&action=edit Bug 41903: Add the base Vue app Patch from commit c6616b1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199011&action=edit Bug 41903: Add the controllers and templates to load the vue app Patch from commit a769ec7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199012&action=edit Bug 41903: Add an indented_subfields option to FormElement Patch from commit eadbdc4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199013&action=edit Bug 41903: Allow any field to be clearable or repeatable Patch from commit 7118e4e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199014&action=edit Bug 41903: Add a library API client Patch from commit 6e527b1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199015&action=edit Bug 41903: Add the filter menu and form fields for Overdues Patch from commit 475a4d0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199016&action=edit Bug 41903: Add a config endpoint and table columns Patch from commit 33d516f -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199017&action=edit Bug 41903: Preserve filters when reloading the page Patch from commit c89210c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199018&action=edit Bug 41903: Handle table filtering Patch from commit ea8e6c1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199019&action=edit Bug 41903: Add cypress tests Patch from commit c9609a2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199020&action=edit Bug 41903: Convert the circ-nav menu to a Vue island Patch from commit 369be0b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199021&action=edit Bug 41903: Add the branch overdues components and plumbing Patch from commit 2be92f7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199022&action=edit Bug 41903: Lazy load alternate menus into LeftMenu.vue Patch from commit d9eef22 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199023&action=edit Bug 41903: Allow resources to populate slots Patch from commit 3bed1b5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 199024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199024&action=edit Bug 41903: Add location filter to branch overdues Test plan: This is a reproduction of the original page functionality but using a Datatables implementaiton with server side pagination to improve performance. As such a step by step test plan is challenging. A test script has been provided to add a lot of overdues to a KTD environment. I would suggest running this before applying the patches and verifying the slow loading times of the original implementation. Then apply the patches and verify that the page loads much quicker than before. Test the filtering and searching options on the table including the left menu filters to verify they are working Run the cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex@rcls.org --- Comment #18 from Alex Carver [Acerock7] <alex@rcls.org> --- Hiya Matt-- Loading the overdues via the script populates the values and I count roughly 11 seconds for the overdues.pl page to load. However, applying the patches results in 404 errors for me when trying to click either "Overdues" or "Overdues with Fines" in the Circulation module. Cypress tests also fail 27/27 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #19 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Hi Alex, thanks for testing. You will need to run a reset_all to trigger the apache redirect to the new pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #20 from Alex Carver [Acerock7] <alex@rcls.org> --- Thanks Matt. Ok the page loads in less than 2 seconds now. All of the filters seem to work. Cypress all specs passed. Also not sure if this is intentional, but the free text "Name or Card Number" filter doesn't work with preferred names or middle names, even though preferred names and middle names are shown in the "Patron" column. Surnames and first names work as expected. Signing Off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199009|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199010|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199011|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199012|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199013|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199014|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199015|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199016|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199017|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199018|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199020|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199021|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199022|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199023|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199024|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #21 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199126&action=edit Bug 41903: Add checkout GET endpoints to the api-client Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #22 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199127&action=edit Bug 41903: Add the base Vue app Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #23 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199128&action=edit Bug 41903: Add the controllers and templates to load the vue app Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #24 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199129&action=edit Bug 41903: Add an indented_subfields option to FormElement Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #25 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199130&action=edit Bug 41903: Allow any field to be clearable or repeatable Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #26 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199131&action=edit Bug 41903: Add a library API client Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #27 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199132&action=edit Bug 41903: Add the filter menu and form fields for Overdues Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #28 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199133&action=edit Bug 41903: Add a config endpoint and table columns Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #29 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199134&action=edit Bug 41903: Preserve filters when reloading the page Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #30 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199135&action=edit Bug 41903: Handle table filtering Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #31 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199136&action=edit Bug 41903: Add cypress tests Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #32 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199137&action=edit Bug 41903: Convert the circ-nav menu to a Vue island Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #33 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199138&action=edit Bug 41903: Add the branch overdues components and plumbing Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #34 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199139&action=edit Bug 41903: Lazy load alternate menus into LeftMenu.vue Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #35 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199140&action=edit Bug 41903: Allow resources to populate slots Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #36 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199141&action=edit Bug 41903: Add location filter to branch overdues Test plan: This is a reproduction of the original page functionality but using a Datatables implementaiton with server side pagination to improve performance. As such a step by step test plan is challenging. A test script has been provided to add a lot of overdues to a KTD environment. I would suggest running this before applying the patches and verifying the slow loading times of the original implementation. Then apply the patches and verify that the page loads much quicker than before. Test the filtering and searching options on the table including the left menu filters to verify they are working Run the cypress tests Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #37 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- (In reply to Alex Carver [Acerock7] from comment #20)
Thanks Matt. Ok the page loads in less than 2 seconds now. All of the filters seem to work. Cypress all specs passed.
Also not sure if this is intentional, but the free text "Name or Card Number" filter doesn't work with preferred names or middle names, even though preferred names and middle names are shown in the "Patron" column. Surnames and first names work as expected.
Signing Off.
Just checked the old version in main and this is the current behaviour $strsth .= " AND (borrowers.firstname like ? or borrowers.surname like ? or borrowers.cardnumber like ?)"; I aimed where possible to completely replicate the old functionality but with the added pagination and performance improvement. If we want to add the extra filtering there then it should be doable but probably best served as a follow-up bug to make it easier to compare the two versions during QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #38 from Alex Carver [Acerock7] <alex@rcls.org> --- Ok understood. Agreed that follow-up bug is best place to address preferred and middle, if desired. Nice work! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #39 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Without the patches: -2k overdues load in an average of 15 seconds With the patches: -First paginated page loads in about 187ms. -If I attempt to load all 2000 results it takes an average of 34 seconds, so slower than before Other things Ive noticed: -Overdue.pl needs the propr permissions [FAIL] circ/overdue.pl FAIL file_permissions File must have the exec flag -xt/check_apache_conf.t fails: xt/check_apache_conf.t .......................... # Failed test 'All RewriteRule and RewriteCond directives must be copied to etc/koha-httpd.conf' # at xt/check_apache_conf.t line 46. # got: '1' # expected: '0' # RewriteRule ^/cgi-bin/koha/circulation/overdues(.*)?$ /cgi-bin/koha/circ/overdue.pl$1 [PT] -api.t failes: xt/api.t ........................................ 1/8 # Failed test 'No tag errors in the spec' # at xt/api.t line 131. # Structures begin differing at: # $got->[0] = 'get /overdues/config -> uses tag 'overdues_config' not present in top level list' # $expected->[0] = Does not exist get /overdues/config -> uses tag 'overdues_config' not present in top level list # Looks like you failed 1 test of 1. # Failed test 'tags tests' # at xt/api.t line 136. Question: Should moving circ-menu to a Vue island be done on a separate bug report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m --- Comment #40 from Lisette Scheer <lisette@bywatersolutions.com> --- In the API description, overdues_config says: List of sysprefs used for the ERM module Similarly to Lucas, my time to run with 2000 records/all records went from 45 seconds to 2.5 minutes (about 3x as long) but just the page of results was less than a second. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42643 [Bug 42643] [OMNIBUS] Assorted performance and stability work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #41 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- What is the purpose of loading all 2000 results? Is that to extract reports? If that still needs to be possible and have the performance improved I'll need to dig a bit deeper -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com --- Comment #42 from hebah@bywatersolutions.com --- Academic libraries often like to see at the end of the semester what's all still checked out, and the overdues report of all checkouts is a nice built-in report that doesn't need to be custom SQL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Strategic theme|--- |Performance Summary|Overdues reports in |Improve performance of the |circulation module are too |overdues reports when |resource intensive |working with a high volume | |of overdues Comma delimited| |ByWater Solutions list of Sponsors| | Initiative type|--- |Epic Target Milestone|--- |26.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #43 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Lucas made some specific technical observations that need addressing, but it seems like we're mostly stuck here around speed when retrieving many/all overdues. Could we sidestep that issue a bit by adding a "Download all" option that sidesteps loading everything into the UI? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43017 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43017 [Bug 43017] [OMNIBUS] Interface optimization -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|42643 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42643 [Bug 42643] [OMNIBUS] Assorted performance and stability work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #44 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- I've been playing around with reducing the time when downloading all of them but ultimately it is still a large dataset with many joined tables - how often are requests being made for all of the results? The current pagination massively improves day to day usage of the report through faster loading - I can add a 'Download all' button with a slightly improved version of the previous non-api code but is it worth it if a request for all of the results is only being made a few times a year? We'd have two separate sets of overdue reporting code to maintain -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41903 --- Comment #45 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Bug 43241 fixes an issue causing API date queries to skip the index and instead look at all rows, causing a significant slowdown. That fix would likely make this code faster, possibly to the point that we don't need a separate "download all" option. But the patches here no longer apply cleanly so I cannot confirm. Matt, would you be amenable to rebasing this as-is to test with 43241 before you dive into adding a "download all"? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org