[Bug 10862] New: Add an search history for the staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Bug ID: 10862 Summary: Add an search history for the staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Like OPAC, the search history will be available for the staff interface. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20953&action=edit Bug 10862: Add an search history for the intranet interface Like OPAC, the search history is now available for intranet. Test plan: 1/ Switch on the 'EnableSearchHistory' syspref. 3/ Launch some biblio and authority searches. 4/ Go on your search history page (top right, under "Set library"). 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Play with the 4 delete links (current / previous and biblio / authority). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Depends on| |10807 Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- - Seems to be missing History.pm? - Database update message refers to "MT12541" rather than Bug 10862. - Typically new features like this are not enabled by default. - Preference description says "...patron search history in the OPAC." It should say "staff client." - catalogue/search-history.tt should use new datatables include file (Bug 10649) - The search history page title and breadcrumbs say "History search" where it should say "Search history" - I suggest that we use the term "catalog" instead of "biblio." "biblio" isn't really a word in English, although we use it Koha some places. I think naming the tabs "Catalog" and "Authority" would be clear: "Your catalog search history is empty." "Delete your current catalog search history" "Delete your previous catalog search history" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20982&action=edit Bug 10862: Followup: fix a couple of issues This followup fixes a couple of issues: - disable the feature by default. - use the datatables include file. - fix the syspref description. - replace "History search" with "Search history". - replace biblio with catalog -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Owen Leonard from comment #2)
- Seems to be missing History.pm? - Database update message refers to "MT12541" rather than Bug 10862. - Typically new features like this are not enabled by default. - Preference description says "...patron search history in the OPAC." It should say "staff client." - catalogue/search-history.tt should use new datatables include file (Bug 10649) - The search history page title and breadcrumbs say "History search" where it should say "Search history" - I suggest that we use the term "catalog" instead of "biblio." "biblio" isn't really a word in English, although we use it Koha some places. I think naming the tabs "Catalog" and "Authority" would be clear:
"Your catalog search history is empty." "Delete your current catalog search history" "Delete your previous catalog search history"
Owen, Thanks for testing! The History.pm module is added by the bug 10807. All others requests are fixed in the followup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #4)
The History.pm module is added by the bug 10807.
Whoops, sorry--I missed the dependency! Now that I can test it for real I see a couple more things: 1) search-history.tt lacks [% INCLUDE 'doc-head-open.inc' %] at the top of the page 2) Not blocking, but strange: If my search returns one hit and I'm redirected to the detail page for that title the search doesn't appear in my history. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21005&action=edit Bug 10862: FIX if the query returns 1 result, it does not appears in the history -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20953|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 21047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21047&action=edit [SIGNED-OFF] Bug 10862: Add an search history for the intranet interface Like OPAC, the search history is now available for intranet. Test plan: 1/ Switch on the 'EnableSearchHistory' syspref. 3/ Launch some biblio and authority searches. 4/ Go on your search history page (top right, under "Set library"). 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Play with the 4 delete links (current / previous and biblio / authority). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20982|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 21048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21048&action=edit [SIGNED-OFF] Bug 10862: Followup: fix a couple of issues This followup fixes a couple of issues: - disable the feature by default. - use the datatables include file. - fix the syspref description. - replace "History search" with "Search history". - replace biblio with catalog Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21005|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 21049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21049&action=edit [SIGNED-OFF] Bug 10862: FIX if the query returns 1 result, it does not appears in the history Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21047|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 22100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22100&action=edit Bug 10862: Add an search history for the intranet interface Like OPAC, the search history is now available for intranet. Test plan: 1/ Switch on the 'EnableSearchHistory' syspref. 3/ Launch some biblio and authority searches. 4/ Go on your search history page (top right, under "Set library"). 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Play with the 4 delete links (current / previous and biblio / authority). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21048|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 22101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22101&action=edit Bug 10862: Followup: fix a couple of issues This followup fixes a couple of issues: - disable the feature by default. - use the datatables include file. - fix the syspref description. - replace "History search" with "Search history". - replace biblio with catalog Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21049|0 |1 is obsolete| | --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 22102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22102&action=edit Bug 10862: FIX if the query returns 1 result, it does not appears in the history Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11430 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED CC| |gmcharlt@gmail.com --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Setting to blocked until such time as bug 10807 passes QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Bug 10862 depends on bug 10807, which changed state. Bug 10807 Summary: OPAC: There is no authority search history http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org