[Bug 26093] New: Markup error after Bug 24279 creates formatting problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Bug ID: 26093 Summary: Markup error after Bug 24279 creates formatting problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: andrew@bywatersolutions.com, bwsdonna@gmail.com, gmcharlt@gmail.com, jonathan.druart@bugs.koha-community.org, katrin.fischer@bsz-bw.de, kelly@bywatersolutions.com, kyle.m.hall@gmail.com, kyle@bywatersolutions.com, m.de.rooy@rijksmuseum.nl, martin.renvoize@ptfs-europe.com Depends on: 24279 After Bug 24279 the "Statuses" section on the item detail page (moredetail.pl) isn't formatted correctly. The ordered list no longer has the correct CSS applied because the container changed from <div> to <span> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 107534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107534&action=edit Bug 26093: Markup error after Bug 24279 creates formatting problem This patch makes a few minor changes to the markup of the item detail page in order for everything to be valid and styled correctly: - Remove unnecessary and invalid <br clear="both"/> - Move heading inside container so that floats clear correctly - Change <span> tag back to <div> to enable the correct style. To test, apply the patch and view the item details page for a title with multiple items. - Each section starting with "Barcode" should be bordered above by a two-pixel gray line - The "statuses" section should be styled like the areas above and below, not as an ordered list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107534|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 107575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107575&action=edit Bug 26093: Markup error after Bug 24279 creates formatting problem This patch makes a few minor changes to the markup of the item detail page in order for everything to be valid and styled correctly: - Remove unnecessary and invalid <br clear="both"/> - Move heading inside container so that floats clear correctly - Change <span> tag back to <div> to enable the correct style. To test, apply the patch and view the item details page for a title with multiple items. - Each section starting with "Barcode" should be bordered above by a two-pixel gray line - The "statuses" section should be styled like the areas above and below, not as an ordered list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107575|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 107578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107578&action=edit Bug 26093: Markup error after Bug 24279 creates formatting problem This patch makes a few minor changes to the markup of the item detail page in order for everything to be valid and styled correctly: - Remove unnecessary and invalid <br clear="both"/> - Move heading inside container so that floats clear correctly - Change <span> tag back to <div> to enable the correct style. To test, apply the patch and view the item details page for a title with multiple items. - Each section starting with "Barcode" should be bordered above by a two-pixel gray line - The "statuses" section should be styled like the areas above and below, not as an ordered list. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107578|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107610&action=edit Bug 26093: Markup error after Bug 24279 creates formatting problem This patch makes a few minor changes to the markup of the item detail page in order for everything to be valid and styled correctly: - Remove unnecessary and invalid <br clear="both"/> - Move heading inside container so that floats clear correctly - Change <span> tag back to <div> to enable the correct style. To test, apply the patch and view the item details page for a title with multiple items. - Each section starting with "Barcode" should be bordered above by a two-pixel gray line - The "statuses" section should be styled like the areas above and below, not as an ordered list. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- missing 20.05.x dependency, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org