[Bug 35871] New: Adding a merge_delete_authorities subpermission for editauthorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 Bug ID: 35871 Summary: Adding a merge_delete_authorities subpermission for editauthorities Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: wainuiwitikapark@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |wainuiwitikapark@catalyst.n |ity.org |et.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 --- Comment #1 from wainuiwitikapark@catalyst.net.nz --- Created attachment 161263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161263&action=edit Bug 35871: Adding new subpermission merge_delete_authorities Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161263|0 |1 is obsolete| | --- Comment #2 from wainuiwitikapark@catalyst.net.nz --- Created attachment 161318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161318&action=edit Bug 35871: Adding new subpermission merge_delete_authorities Test plan: - apply patch - login to staff client with your personal user - make a new test user - set the new test user's permissions to catalogue so they can access the staff client - logout and log back in to the staff client as the new test user - go to Authorities - do a search - notice there is no drop down next to each authority search result - logout and log back in to the staff client as your personal user - edit the new test user - add permission editauthorities and subpermission merge_delete_authorities - logout and log back in to the staff client as the test user - go to Authorities - do a search - notice how you there is an "Actions" dropdown next to each of the authority search results - click the Action dropdown and notice you can merge - check you can merge results - also check you can delete a result that has 0 records Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161318|0 |1 is obsolete| | --- Comment #3 from wainuiwitikapark@catalyst.net.nz --- Created attachment 161319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161319&action=edit Bug 35871: Adding new subpermission merge_delete_authorities Test plan: - apply patch from Bug 35870 - apply patch - login to staff client with your personal user - make a new test user - set the new test user's permissions to catalogue so they can access the staff client - also set the new test user's permissions to subpermission edit_authorities, but not merge_delete_auhtorities - logout and log back in to the staff client as the new test user - go to Authorities - do a search - notice there is an 'Actions' drop down next to each authority search result - notice that the drop down does not give you the option to choose Merge or Delete - logout and log back in to the staff client as your personal user - edit the new test user - add subpermission merge_delete_authorities - logout and log back in to the staff client as the test user - go to Authorities - do a search - notice how you there is an 'Actions' dropdown next to each of the authority search results - click the Action dropdown and notice you can merge - check you can merge results - also check you can delete a result that has 0 records Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35870 [Bug 35870] Adding an edit_authorities subpermission for editauthorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27319, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31197 CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.rault@biblibre.com Status|Needs Signoff |Failed QA --- Comment #4 from Laurence Rault <laurence.rault@biblibre.com> --- Patch does not apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161319|0 |1 is obsolete| | --- Comment #5 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Created attachment 177209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177209&action=edit Bug 35871: Adding new subpermission merge_delete_authorities Test plan: - apply patch from Bug 35870 - apply patch - login to staff client with your personal user - make a new test user - set the new test user's permissions to catalogue so they can access the staff client - also set the new test user's permissions to subpermission edit_authorities, but not merge_delete_auhtorities - logout and log back in to the staff client as the new test user - go to Authorities - do a search - notice there is an 'Actions' drop down next to each authority search result - notice that the drop down does not give you the option to choose Merge or Delete - logout and log back in to the staff client as your personal user - edit the new test user - add subpermission merge_delete_authorities - logout and log back in to the staff client as the test user - go to Authorities - do a search - notice how you there is an 'Actions' dropdown next to each of the authority search results - click the Action dropdown and notice you can merge - check you can merge results - also check you can delete a result that has 0 records Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to Laurence Rault from comment #4)
Patch does not apply
thanks, I have added a new one now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from David Nind <david@davidnind.com> --- The patch still applies, however the database update to add the new permission doesn't work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 177495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177495&action=edit Bug 35871: Add new subpermission merge_delete_authorities Add a new sub permission for merging and deleting authority records. Test plan: 1. Apply the patch (including bug 35870). 2. Update the database. 3. Login to the staff interface as a superlibrarian. 4. Add or edit an existing staff patron. 5. Set the patron's permissions to catalogue so they can access the staff interface. 6. Also add the edit_authorities permission, but not merge_delete_authorities. 7. Logout and log back in to the staff interface as the patron. 8. Go to Authorities. 9. Search for an authority record, for example search for 'a'. 10. Notice that there is an 'Actions' dropdown next to each authority search result. 11. Notice that the dropdown does not give you the option to choose Merge or Delete 12. Logout and log back in to the staff interface as a superlibrarian. 13. Edit the staff patron - add the sub permission merge_delete_authorities. 14. Logout and log back in to the staff interface as the staff patron. 15. Repeat steps 8 to 9. 16. Click the Action dropdown and notice you can merge. 17. Check that you can merge authority records. 18. Also check you can delete a search result that has 0 records. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177209|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 --- Comment #9 from David Nind <david@davidnind.com> --- I fixed the database update (using bug 35870 as a pattern) and updated the commit message. However, I got login and CSRF errors when attempting to merge a record - so I have left the status as Failed QA. Bug 36192. I also think the colour/style needs changing for the merge message box with the bootstrap 5 update and styles for the different types of information boxes - see bug 35402 and bug 38519. To replicate: 1. Log in with the staff patron with edit_authorities and merge_delete_authorities. 2. Go to Authorities. 3. Search for an authority record, for example, 'a'. 4. For one record, from the 'Actions' select 'Merge' 5. A blue message box appears with "Merging with authority....". 6. For another term (of the same type) select Action > Merge. 7. The two record titles are displayed and you can select which one and then Next. 8. Note that you get the log in box with: Error: Session timed out. Please log in again 9. Log in again, you get the pages to select some tags from each record so that there is material in the destination record. 10. Click "Merge". 11. You get an error: An error has occurred! Error 403 The form submission failed (Wrong CSRF token). Try to come back, refresh the page, then try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to David Nind from comment #9)
I fixed the database update (using bug 35870 as a pattern) and updated the commit message. Thank you for that!
However, I got login and CSRF errors when attempting to merge a record - so I have left the status as Failed QA. Bug 36192.
I also think the colour/style needs changing for the merge message box with the bootstrap 5 update and styles for the different types of information boxes - see bug 35402 and bug 38519. Do you think that should be done in this bug report or a separate one?
To replicate:
1. Log in with the staff patron with edit_authorities and merge_delete_authorities. 2. Go to Authorities. 3. Search for an authority record, for example, 'a'. 4. For one record, from the 'Actions' select 'Merge' 5. A blue message box appears with "Merging with authority....". 6. For another term (of the same type) select Action > Merge. 7. The two record titles are displayed and you can select which one and then Next. 8. Note that you get the log in box with: Error: Session timed out. Please log in again 9. Log in again, you get the pages to select some tags from each record so that there is material in the destination record. 10. Click "Merge". 11. You get an error: An error has occurred! Error 403 The form submission failed (Wrong CSRF token). Try to come back, refresh the page, then try again.
Hmm, I am not getting the same output, I am not getting step 8. I am able to successfully merge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to David Nind from comment #9)
I fixed the database update (using bug 35870 as a pattern) and updated the commit message.
However, I got login and CSRF errors when attempting to merge a record - so I have left the status as Failed QA. Bug 36192.
I also think the colour/style needs changing for the merge message box with the bootstrap 5 update and styles for the different types of information boxes - see bug 35402 and bug 38519.
To replicate:
1. Log in with the staff patron with edit_authorities and merge_delete_authorities. 2. Go to Authorities. 3. Search for an authority record, for example, 'a'. 4. For one record, from the 'Actions' select 'Merge' 5. A blue message box appears with "Merging with authority....". 6. For another term (of the same type) select Action > Merge. 7. The two record titles are displayed and you can select which one and then Next. 8. Note that you get the log in box with: Error: Session timed out. Please log in again 9. Log in again, you get the pages to select some tags from each record so that there is material in the destination record. 10. Click "Merge". 11. You get an error: An error has occurred! Error 403 The form submission failed (Wrong CSRF token). Try to come back, refresh the page, then try again.
Kia ora David! Just wondering if you are able to confirm you are still getting this output? I was not getting step 8. I was able to successfully merge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 --- Comment #12 from David Nind <david@davidnind.com> --- I can no longer apply to test, sorry. I applied patch 35870, now 35871 doesn't apply cleanly: git bz apply 35871 Bug 35871 Depends on bug 35870 (Needs Signoff) Follow? [(y)es, (n)o] n Bug 35871 - Adding a merge_delete_authorities subpermission for editauthorities 177495 - Bug 35871: Add new subpermission merge_delete_authorities Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35871: Add new subpermission merge_delete_authorities Using index info to reconstruct a base tree... M authorities/merge.pl M koha-tmpl/intranet-tmpl/prog/en/includes/authorities-toolbar.inc M koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc M koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt M koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/authorities-toolbar.inc Auto-merging authorities/merge.pl CONFLICT (content): Merge conflict in authorities/merge.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 35871: Add new subpermission merge_delete_authorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177495|0 |1 is obsolete| | --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Created attachment 180608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180608&action=edit Bug 35871: Add new subpermission merge_delete_authorities Add a new sub permission for merging and deleting authority records. Test plan: 1. Apply the patch (including bug 35870). 2. Update the database. 3. Login to the staff interface as a superlibrarian. 4. Add or edit an existing staff patron. 5. Set the patron's permissions to catalogue so they can access the staff interface. 6. Also add the edit_authorities permission, but not merge_delete_authorities. 7. Logout and log back in to the staff interface as the patron. 8. Go to Authorities. 9. Search for an authority record, for example search for 'a'. 10. Notice that there is an 'Actions' dropdown next to each authority search result. 11. Notice that the dropdown does not give you the option to choose Merge or Delete 12. Logout and log back in to the staff interface as a superlibrarian. 13. Edit the staff patron - add the sub permission merge_delete_authorities. 14. Logout and log back in to the staff interface as the staff patron. 15. Repeat steps 8 to 9. 16. Click the Action dropdown and notice you can merge. 17. Check that you can merge authority records. 18. Also check you can delete a search result that has 0 records. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to David Nind from comment #12)
I can no longer apply to test, sorry.
I applied patch 35870, now 35871 doesn't apply cleanly:
git bz apply 35871
Bug 35871 Depends on bug 35870 (Needs Signoff) Follow? [(y)es, (n)o] n
Bug 35871 - Adding a merge_delete_authorities subpermission for editauthorities
177495 - Bug 35871: Add new subpermission merge_delete_authorities
Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35871: Add new subpermission merge_delete_authorities Using index info to reconstruct a base tree... M authorities/merge.pl M koha-tmpl/intranet-tmpl/prog/en/includes/authorities-toolbar.inc M koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc M koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt M koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/authorities-toolbar.inc Auto-merging authorities/merge.pl CONFLICT (content): Merge conflict in authorities/merge.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 35871: Add new subpermission merge_delete_authorities
Thanks David! I couldn't get it to work either so I manually made the changes again. However, I am now getting the errors that you were in Comment 9. I will ask our client if they would like to sponsor more time towards this bug patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org