[Bug 8113] New: Item return fails using SIP2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 Priority: P3 Change sponsored?: --- Bug ID: 8113 Assignee: colin.campbell@ptfs-europe.com Summary: Item return fails using SIP2 Severity: major Classification: Unclassified OS: Linux Reporter: hlib@lloydminster.info Hardware: PC Status: NEW Version: rel_3_8 Component: SIP2 Product: Koha I have been testing Koha's SIP2 service using both the 3M software and an actual self-check device. When attempting to return an item loaned using the Koha circulation interface through the 3m software I receive a message that communications has failed while the following message appears in my sip.err file: Use of uninitialized value $var in hash element at /usr/share/koha/lib/C4/Context.pm line 1026 Undefined subroutine &C4::Circulation::GetItemnumberFromBarcode called at /usr/share/koha/lib/C4/Circulation.pm line 1541 Note that this error is similar to the one reported in bug 7684 today -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 Ron Gillies <hlib@lloydminster.info> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7684 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- This is only triggered if the item needs to be transferred, so will be sporadic. But can be reliably recreated on by returning an item that needs to be transferred. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 --- Comment #2 from Ron Gillies <hlib@lloydminster.info> --- (In reply to comment #1)
This is only triggered if the item needs to be transferred, so will be sporadic. But can be reliably recreated on by returning an item that needs to be transferred.
Odd as the item was from branch MAIN and was being returned to branch MAIN -- no other branches currently defined on my test system (and only a small number <25) of items -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- I have a suspicion this is to do with bug 6875, but I have to go to a user day now so can't investigate more. And it may be checking if it needs transfer. A quick fix ron, change line 1541 to read my $itemnumber = C4::Items::GetItemnumberFromBarcode( $barcode ); instead of my $itemnumber = GetItemnumberFromBarcode( $barcode ); This will work while we track down the root cause and fix it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 --- Comment #4 from Ron Gillies <hlib@lloydminster.info> --- (In reply to comment #3)
I have a suspicion this is to do with bug 6875, but I have to go to a user day now so can't investigate more.
And it may be checking if it needs transfer. A quick fix ron, change line 1541 to read
my $itemnumber = C4::Items::GetItemnumberFromBarcode( $barcode );
instead of
my $itemnumber = GetItemnumberFromBarcode( $barcode );
This will work while we track down the root cause and fix it
Made the change that you suggested at line 1541 Error continues with a slight change in the location Undefined subroutine &C4::Circulation::GetItemnumberFromBarcode called at /usr/share/koha/lib/C4/Circulation.pm line 1563 GetItem is used at that point and a note references the fact that it should work because GetItemnumberFromBarcode worked I will leave this as is for the moment as it may need eyes more familiar with the code than mine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- That should be C4::Items->GetItemnumberFromBarcode not C4::Items::GetItemnumberFromBarcode The latter expects a GetItemnumberFromBarcode.pm file, whereas the former expects a function inside of C4::Items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #5)
That should be C4::Items->GetItemnumberFromBarcode not C4::Items::GetItemnumberFromBarcode
The latter expects a GetItemnumberFromBarcode.pm file, whereas the former expects a function inside of C4::Items.
Not true. C4::Items::GetItemnumberFromBarcode() calls the GetItemnumberFromBarcode subroutine in C4/Items.pm If you notice Ron's other comment, it is now the same error further in the file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mtompset@hotmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 Bilgi Küflü <bilgi@biltera.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bilgi@biltera.com.tr --- Comment #7 from Bilgi Küflü <bilgi@biltera.com.tr> --- Anybody has a solution for this bug?? I am experiencing the same error even at Checkout/CheckIn. The connection is closed with the same error : Use of uninitialized value $var in hash element at /home/koha/kohaclone/C4/Context.pm line 1026 Undefined subroutine &C4::Circulation::GetItemnumberFromBarcode called at /home/koha/kohaclone/C4/Circulation.pm line 1541 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 --- Comment #8 from Bilgi Küflü <bilgi@biltera.com.tr> --- Sorry the line number is wrong on my previous mail. The correct one is Undefined subroutine &C4::Circulation::GetItemnumberFromBarcode called at /home/koha/kohaclone/C4/Circulation.pm line 671 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, this does not sound like a nice bug - I still haven't figured out how to test SIP properly, can someone else take a look maybe? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 --- Comment #10 from Colin Campbell <colin.campbell@ptfs-europe.com> --- The call does not occur in current versions of C4::Circulation.pm is this specific to a particular release of 3.8 ? Can someone who can reproduce this try with a later release -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Colin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Fixed in later versions -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org