[Bug 25418] New: Backdated check out date loses time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Bug ID: 25418 Summary: Backdated check out date loses time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1 - Select a date before today at checkout, leaving time at 23:59 2 - Note the alert box has only the date 3 - Confirm the checkout 4 - Item is due at 00:00 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104521&action=edit Bug 25418: (bug 25133 follow-up) Display due date with hours And not as due date, it's not a display-only info, but an input. This patch is a follow-up of Bug 25133: Fix time part of due date for 12hr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please test the different combinations of: Backdate and not 12 and 24hr timeformat 23:59 and others -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25133 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133 [Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- 1. Did I understood well the params for the combinations? 2. Is the other value of the time relevant? (11:59) should there be other values of the time? == Draft of test plan == - tomorrow 23:59 12h timeformat syspref - backdate 23:59 12h timeformat syspref - tomorrow 11:59 12h timeformat syspref - backdate 11:59 12h timeformat syspref - tomorrow 23:59 24h timeformat syspref - backdate 23:59 24h timeformat syspref - tomorrow 23:59 24h timeformat syspref - backdate 11:59 24h timeformat syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- and minutes != 59 (to make the time part != 23:59) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104521|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104705&action=edit Bug 25418: (bug 25133 follow-up) Display due date with hours And not as due date, it's not a display-only info, but an input. This patch is a follow-up of Bug 25133: Fix time part of due date for 12hr == Test plan == 1. create checkouts with the following params and results 2. tomorrow 11:59 PM timeformat syspref: 12h - item is due without a specific time, only date (after-checkout green box) 3. backdate 11:59 PM timeformat syspref: 12h - note the yellow confirm box has only the date - item is due at 12:00 PM (after-checkout green box) 4. tomorrow 11:23 AM timeformat syspref: 12h - item is due at 11:23 AM (after-checkout green box) 5. backdate 11:23 AM timeformat syspref: 12h - note the yellow confirm box has the date and time - item is due 11:23 AM (after-checkout green box) 6. tomorrow 23:59 timeformat syspref: 24h - item is due without a specific time, only date (after-checkout green box) 7. backdate 23:59 timeformat syspref: 24h - note the yellow confirm box has only the date - item is due at 00:00 (after-checkout green box) 8. tomorrow 11:23 timeformat syspref: 24h - item is due at 11:23 (after-checkout green box) 9. backdate 11:23 timeformat syspref: 24h - note the yellow confirm box has the date and time - item is due 11:23 (after-checkout green box) 10. apply patch 11. create checkouts with the following params and results 12. tomorrow 11:59 PM timeformat syspref: 12h - item is due without a specific time, only date (after-checkout green box) 13. backdate 11:59 PM timeformat syspref: 12h - note the yellow confirm box has the date and time - CHANGE COMPARED TO BEFORE THE PATCH - item is due without a specific time, only date (after-checkout green box) - CHANGE COMPARED TO BEFORE THE PATCH 14. tomorrow 11:23 AM timeformat syspref: 12h - item is due 11:23 AM (after-checkout green box) 15. backdate 11:23 AM timeformat syspref: 12h - note the yellow confirm box has the date and time - item is due 11:23 AM (after-checkout green box) 16. tomorrow 23:59 timeformat syspref: 24h - item is due without a specific time, only date (after-checkout green box) 17. backdate 23:59 timeformat syspref: 24h - note the yellow confirm box has the date and time - CHANGE COMPARED TO BEFORE THE PATCH - item is due without a specific time, only date (after-checkout green box) - CHANGE COMPARED TO BEFORE THE PATCH 18. tomorrow 11:23 timeformat syspref: 24h - item is due at 11:23 (after-checkout green box) 19. backdate 11:23 timeformat syspref: 24h - note the yellow confirm box has the date and time - item is due 11:23 (after-checkout green box) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I've noted (in caps in the test plan) 4 changes compared to before and after the patch. Looks good to me. Though I'm not sure if that's enough. Like if the after-checkout green box should always display the time. And if other times than 23:59 and 11:23 should be tested. Jonathan or QA: do you confirm that the results show well the issues and that the patch addresses them successfully? Signing off because there is no doubt it fixed the issues described in comment 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Victor, we store a "date" without the time part with "23:59". If a time part is passed, then we store it. When we display a "due date", we display it without 23:59 if the time part is "23:59", which means the user has to check the item in that specific day (without hour constraint). This is done using the TT plugin KohaDates, with the as_due_date flag turned on. The 23:59 is only removed for display purpose, if the due date is displayed in an input field (like the green confirmation box), then the time part has to be visible (for technical purpose only actually, to make the JS plugin work correctly). Hope it clarifies why it's sometimes visible and sometimes not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Yep, thanks :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104705|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 104709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104709&action=edit Bug 25418: (bug 25133 follow-up) Display due date with hours And not as due date, it's not a display-only info, but an input. This patch is a follow-up of Bug 25133: Fix time part of due date for 12hr == Test plan == 1. create checkouts with the following params and results 2. tomorrow 11:59 PM timeformat syspref: 12h - item is due without a specific time, only date (after-checkout green box) 3. backdate 11:59 PM timeformat syspref: 12h - note the yellow confirm box has only the date - item is due at 12:00 PM (after-checkout green box) 4. tomorrow 11:23 AM timeformat syspref: 12h - item is due at 11:23 AM (after-checkout green box) 5. backdate 11:23 AM timeformat syspref: 12h - note the yellow confirm box has the date and time - item is due 11:23 AM (after-checkout green box) 6. tomorrow 23:59 timeformat syspref: 24h - item is due without a specific time, only date (after-checkout green box) 7. backdate 23:59 timeformat syspref: 24h - note the yellow confirm box has only the date - item is due at 00:00 (after-checkout green box) 8. tomorrow 11:23 timeformat syspref: 24h - item is due at 11:23 (after-checkout green box) 9. backdate 11:23 timeformat syspref: 24h - note the yellow confirm box has the date and time - item is due 11:23 (after-checkout green box) 10. apply patch 11. create checkouts with the following params and results 12. tomorrow 11:59 PM timeformat syspref: 12h - item is due without a specific time, only date (after-checkout green box) 13. backdate 11:59 PM timeformat syspref: 12h - note the yellow confirm box has the date and time - CHANGE COMPARED TO BEFORE THE PATCH - item is due without a specific time, only date (after-checkout green box) - CHANGE COMPARED TO BEFORE THE PATCH 14. tomorrow 11:23 AM timeformat syspref: 12h - item is due 11:23 AM (after-checkout green box) 15. backdate 11:23 AM timeformat syspref: 12h - note the yellow confirm box has the date and time - item is due 11:23 AM (after-checkout green box) 16. tomorrow 23:59 timeformat syspref: 24h - item is due without a specific time, only date (after-checkout green box) 17. backdate 23:59 timeformat syspref: 24h - note the yellow confirm box has the date and time - CHANGE COMPARED TO BEFORE THE PATCH - item is due without a specific time, only date (after-checkout green box) - CHANGE COMPARED TO BEFORE THE PATCH 18. tomorrow 11:23 timeformat syspref: 24h - item is due at 11:23 (after-checkout green box) 19. backdate 11:23 timeformat syspref: 24h - note the yellow confirm box has the date and time - item is due 11:23 (after-checkout green box) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 104710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104710&action=edit Bug 25418: (QA follow-up) Raise size of input box In twelve hour format the length of the string is 20 characters we need the box to fit all of them Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- pushed to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org