[Bug 7261] New: System Preference to select the first day of week (Sunday or Monday) to use in the calendar (OPAC and Intranet)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Bug #: 7261 Summary: System Preference to select the first day of week (Sunday or Monday) to use in the calendar (OPAC and Intranet) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration AssignedTo: paul.poulain@biblibre.com ReportedBy: juan.sieira@xercode.es QAContact: ian.walls@bywatersolutions.com CC: gmcharlt@gmail.com Created attachment 6393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6393 Patch System Preference to select the first day of week (Sunday or Monday) to use in the calendar (OPAC and Intranet). To test the patch, run updatedatabase.pl to insert the new syspref and then use the calendar, for example in Tools->Calendar or opac-reserve in OPAC. Change the new syspref under Administration->Interface options->CalendarFirstDayOfWeek -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Juan Romay Sieira <juan.sieira@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Juan Romay Sieira <juan.sieira@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|paul.poulain@biblibre.com |juan.sieira@xercode.es -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6393|0 |1 is obsolete| | --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-12-06 16:03:11 UTC --- Created attachment 6601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6601 Signed-off patch Works as advertised. Nice internationalization enhancement. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QAContact|ian.walls@bywatersolutions. |m.de.rooy@rijksmuseum.nl |com | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-04 15:17:07 UTC --- Just a few questions/remarks before finishing QA: 1 Would it not be better to move this pref to Internationalization tab instead of Administration? 2 I would recommend to make the two tests on the preference in Auth.pm identical. Currently, it works, but things can change. 3 Is opac-reserve template the only one needing the firstDay parameter on the opac side? I notice that at the staff side the same change is in a common calendar-setup file. For the rest, things look very good to me. Could you clarify or send a follow up for the points above? Thanks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2012-01-04 15:41:34 UTC ---
3 Is opac-reserve template the only one needing the firstDay parameter on the opac side? I notice that at the staff side the same change is in a common calendar-setup file.
I noticed the same thing, and submitted a follow-up to Bug 2307. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-13 15:16:47 UTC --- Changing status to reflect pending state. See comment 2. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Juan Romay Sieira <juan.sieira@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6601|0 |1 is obsolete| | --- Comment #5 from Juan Romay Sieira <juan.sieira@xercode.es> 2012-02-09 18:15:31 UTC --- Created attachment 7538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7538 Patch to apply in current master This patch applies to current master. The syspref was moved from Administration to Internationalization tab. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Juan Romay Sieira <juan.sieira@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 --- Comment #6 from Juan Romay Sieira <juan.sieira@xercode.es> 2012-02-09 18:19:41 UTC --- (In reply to comment #2)
Just a few questions/remarks before finishing QA:
1 Would it not be better to move this pref to Internationalization tab instead of Administration? I changed it to the tab you mentioned above.
2 I would recommend to make the two tests on the preference in Auth.pm identical. Currently, it works, but things can change. 3 Is opac-reserve template the only one needing the firstDay parameter on the opac side? I notice that at the staff side the same change is in a common calendar-setup file. I did a search over the opac templates and I only found it in opac-reserve.tt
For the rest, things look very good to me. Could you clarify or send a follow up for the points above? Thanks.
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7538|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 7999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7999&action=edit Bug 7261 System Preference to select the first day of week Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P4 Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 8183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8183&action=edit Followup to make tests consistent -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Marking it as Passed QA, while adding a followup to make the two tests in Auth.pm the same. Trivial merge conflict in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- I'm not sure this syspref won't be deprecated by the datepicker change to switch to a jquery datepicker, but until then... patch pushed ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- In fact we may be able to tie the configuration of the datepicker to the current localization settings. There are a lot of options built in: http://jqueryui.com/demos/datepicker/#localization -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #12 from Nicole C. Engard <nengard@gmail.com> --- This says it was pushed to master, but changing this preference's value in master doesn't seem to do anything for me .... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Nicole, try clearing your browser cache. The patch includes changes to js files which might need to be refreshed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 --- Comment #14 from Nicole C. Engard <nengard@gmail.com> --- Bingo! and good tip to include in the manual. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED Version|3.8 |master Assignee|juan.sieira@xercode.es |oleonard@myacpl.org --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Working in the staff client, not on opac-reserve.pl. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9166 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Looks like this is working in master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org