[Bug 35408] New: ERM > Titles > Import from a list gives an invalid link to the import job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 Bug ID: 35408 Summary: ERM > Titles > Import from a list gives an invalid link to the import job Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: victor@tuxayo.net CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com Test plan 1. enable ERMModule syspref 2. create a new list and add one or more records to it 4. go to eHoldings > Local > Titles > Import from a list 5. start import 6. click on the link to job 7. 404 :o link is http://localhost:8081/cgi-bin/koha/admin/background_jobs/1 instead of http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl?op=view&id=1 It happened to me once, then I tried to reproduce and the link was correct... And now it happened again. No idea how to make it consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159284&action=edit Bug 35408: Fix import job link After importing titles from a list there is a link to the background job that is displayed. This link points to /cgi-bin/koha/admin/background_jobs/:id There is a route to this path in routes/erm.js, to redirect to the correct URI /cgi-bin/koha/admin/background_jobs.pl?op=view&id=:id However this link will not work if we are accessing it from outside the ERM app/module, or if we are opening it in a new tab/window. The idea was interesting, but does not work... Test plan: Create a new ERM local package, a new list (virtual shelf), add some items to the list. Go to E-resource management > eHoldings > Local > Titles > Import from a list Click "import" Notice the "see job" link and click it => Confirm that with this patch applied you can open it in a new tab without getting a 404 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32030 Severity|minor |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159284|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159309&action=edit Bug 35408: Fix import job link After importing titles from a list there is a link to the background job that is displayed. This link points to /cgi-bin/koha/admin/background_jobs/:id There is a route to this path in routes/erm.js, to redirect to the correct URI /cgi-bin/koha/admin/background_jobs.pl?op=view&id=:id However this link will not work if we are accessing it from outside the ERM app/module, or if we are opening it in a new tab/window. The idea was interesting, but does not work... Test plan: Create a new ERM local package, a new list (virtual shelf), add some items to the list. Go to E-resource management > eHoldings > Local > Titles > Import from a list Click "import" Notice the "see job" link and click it => Confirm that with this patch applied you can open it in a new tab without getting a 404 Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159309|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 159371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159371&action=edit Bug 35408: Fix import job link After importing titles from a list there is a link to the background job that is displayed. This link points to /cgi-bin/koha/admin/background_jobs/:id There is a route to this path in routes/erm.js, to redirect to the correct URI /cgi-bin/koha/admin/background_jobs.pl?op=view&id=:id However this link will not work if we are accessing it from outside the ERM app/module, or if we are opening it in a new tab/window. The idea was interesting, but does not work... Test plan: Create a new ERM local package, a new list (virtual shelf), add some items to the list. Go to E-resource management > eHoldings > Local > Titles > Import from a list Click "import" Notice the "see job" link and click it => Confirm that with this patch applied you can open it in a new tab without getting a 404 Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
There is a route to this path in routes/erm.js, to redirect to the correct URI /cgi-bin/koha/admin/background_jobs.pl?op=view&id=:id However this link will not work if we are accessing it from outside the ERM app/module, or if we are opening it in a new tab/window.
I would have never guess it was new tab vs normal click. Thanks a lot Jonathan :) Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Patch complexity|--- |Small patch Version(s)|24.05.00 |24.05.00,23.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.01 |24.05.00,23.11.01,23.05.07 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org