[Bug 12274] New: Closed invoices not properly handled on invoice details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 Bug ID: 12274 Summary: Closed invoices not properly handled on invoice details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: abl@biblos.pk.edu.pl QA Contact: testopia@bugs.koha-community.org Symptoms: - closed invoices are displayed as "Open" on details page (acqui/invoice.pl), - it's not possible to reopen the closed invoice using "Edit" button. (see also bug 3050 comment #11) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |abl@biblos.pk.edu.pl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 --- Comment #1 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- Ouch; it's not an "Edit" button, should be "Save" button instead in comment #1.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 --- Comment #2 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 28303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28303&action=edit Bug 12274 - Closed invoices not properly handled on invoice details page Trivial fix for small regression (closed invoices are displayed as "Open" on details page, and it's not possible to reopen the closed invoice using "Save" button) introduced by bug 10613. Test plan: 1) Create and close some invoices 2) Note that closed invoices are erroneously displayed as "Open" on individual invoice[s] details page 3) Apply patch 4) Check previously closed invoices; their status on details page should now be properly displayed as "Closed on ..." (and an option for reopening would reappear as well) 5) Ensure that "Close" / "Reopen" checkboxes followed by "Save" button do work as expected for individual open / closed invoices respectivelly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Status|NEW |Needs Signoff CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10613 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Depends on| |10613 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28303|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28351&action=edit Bug 12274 - Closed invoices not properly handled on invoice details page Trivial fix for small regression (closed invoices are displayed as "Open" on details page, and it's not possible to reopen the closed invoice using "Save" button) introduced by bug 10613. Test plan: 1) Create and close some invoices 2) Note that closed invoices are erroneously displayed as "Open" on individual invoice[s] details page 3) Apply patch 4) Check previously closed invoices; their status on details page should now be properly displayed as "Closed on ..." (and an option for reopening would reappear as well) 5) Ensure that "Close" / "Reopen" checkboxes followed by "Save" button do work as expected for individual open / closed invoices respectivelly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28352&action=edit Bug 12274: Invoice detail: billingdate is badly formated Bug 10613 sent the billingdate as a string. The template waits a DateTime object. To reproduce: 1/ Go on a invoice detail page 2/ Select a billing date 3/ Boom without the patch [Tue May 20 13:39:18 2014] invoice.pl: Template process failed: undef error - The 'day' parameter ("2014") to DateTime::new did not pass the 'an integer which is a possible valid day of month' callback. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Severity|normal |critical --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- And I found another bug introduced by bug 10613. This is critical for the release, I raise the severity. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28351|0 |1 is obsolete| | Attachment #28352|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 28395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28395&action=edit [PASSED QA] Bug 12274 - Closed invoices not properly handled on invoice details page Trivial fix for small regression (closed invoices are displayed as "Open" on details page, and it's not possible to reopen the closed invoice using "Save" button) introduced by bug 10613. Test plan: 1) Create and close some invoices 2) Note that closed invoices are erroneously displayed as "Open" on individual invoice[s] details page 3) Apply patch 4) Check previously closed invoices; their status on details page should now be properly displayed as "Closed on ..." (and an option for reopening would reappear as well) 5) Ensure that "Close" / "Reopen" checkboxes followed by "Save" button do work as expected for individual open / closed invoices respectivelly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 28396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28396&action=edit [PASSED QA] Bug 12274: Invoice detail: billingdate is badly formated Bug 10613 sent the billingdate as a string. The template waits a DateTime object. To reproduce: 1/ Go on a invoice detail page 2/ Select a billing date 3/ Boom without the patch [Tue May 20 13:39:18 2014] invoice.pl: Template process failed: undef error - The 'day' parameter ("2014") to DateTime::new did not pass the 'an integer which is a possible valid day of month' callback. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Not all dates will make it go 'boom' but 31/07/2014 did. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12274 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jacek and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org