[Bug 17210] New: Remove us of onclick from biblio detail sidebar in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 Bug ID: 17210 Summary: Remove us of onclick from biblio detail sidebar in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |aleishaamohia@hotmail.com Summary|Remove us of onclick from |Remove use of onclick from |biblio detail sidebar in |biblio detail sidebar in |OPAC |OPAC Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54967&action=edit Bug 17210: Remove use of onclick form biblio detail sidebar in OPAC Four instances of onclick here: 1) Print 2) Save to your lists 3) Add to your cart 4) Remove from cart To test: Find a biblio detail page in OPAC and confirm all four events above work as expected before and after the patch. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54968&action=edit Bug 17210: Remove use of onclick from biblio detail sidebar in OPAC Four instances of onclick here: 1) Print 2) Save to your lists 3) Add to your cart 4) Remove from cart To test: Find a biblio detail page in OPAC and confirm all four events above work as expected before and after the patch. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54967|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54968|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 54975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54975&action=edit [SIGNED-OFF] Bug 17210: Remove use of onclick from biblio detail sidebar in OPAC Four instances of onclick here: 1) Print 2) Save to your lists 3) Add to your cart 4) Remove from cart To test: Find a biblio detail page in OPAC and confirm all four events above work as expected before and after the patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54975|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55280&action=edit Bug 17210: Remove use of onclick from biblio detail sidebar in OPAC Four instances of onclick here: 1) Print 2) Save to your lists 3) Add to your cart 4) Remove from cart To test: Find a biblio detail page in OPAC and confirm all four events above work as expected before and after the patch. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55281&action=edit Bug 17210: Add missing return false for print-large Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Aleisha, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17315 [Bug 17315] Can't add entry to lists using link in result list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Templates CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org