[Bug 10841] New: Edit/Delete item context links in items table are not translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Bug ID: 10841 Summary: Edit/Delete item context links in items table are not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr To test: - Install an additional language - Edit items for a record with multiple items - Click somewhere in the items table - Verify the links for editing and deleting items show up and work correctly, but are not translated. Also capitalization is not correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20868&action=edit Bug 10841: Make edit/delete item context links in cataloguing translatable HTML created with Javascript is not translatable the way HTML is normally translated. _() syntax has to be used to have strings translatable. To test: - Edit items for a record with multiple items - Click somewhere in the items table - Verify the links for editing and deleting items show up and work correctly - Apply patch - Verify the links still show the same behaviour Bonus: - Run 'perl translate update <languagecode>' in misc/translator - Verify that Edit item and Delete item show up in the po file, translate them - Install updated po files running 'perl translate install <languagecode>' - Verify links show up translated and work correctly Patch also fixes capitalization for a couple of error messages - only change there is: Deleted > deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20868|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20911&action=edit [SIGNED-OFF] Bug 10841: Make edit/delete item context links in cataloguing translatable HTML created with Javascript is not translatable the way HTML is normally translated. _() syntax has to be used to have strings translatable. To test: - Edit items for a record with multiple items - Click somewhere in the items table - Verify the links for editing and deleting items show up and work correctly - Apply patch - Verify the links still show the same behaviour Bonus: - Run 'perl translate update <languagecode>' in misc/translator - Verify that Edit item and Delete item show up in the po file, translate them - Install updated po files running 'perl translate install <languagecode>' - Verify links show up translated and work correctly Patch also fixes capitalization for a couple of error messages - only change there is: Deleted > deleted. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20911|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20919&action=edit Bug 10841: Make edit/delete item context links in cataloguing translatable HTML created with Javascript is not translatable the way HTML is normally translated. _() syntax has to be used to have strings translatable. To test: - Edit items for a record with multiple items - Click somewhere in the items table - Verify the links for editing and deleting items show up and work correctly - Apply patch - Verify the links still show the same behaviour Bonus: - Run 'perl translate update <languagecode>' in misc/translator - Verify that Edit item and Delete item show up in the po file, translate them - Install updated po files running 'perl translate install <languagecode>' - Verify links show up translated and work correctly Patch also fixes capitalization for a couple of error messages - only change there is: Deleted > deleted. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org