[Bug 16334] New: Cannot sort checkout search by name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 Bug ID: 16334 Summary: Cannot sort checkout search by name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When Bug 15793 removed the radio buttons I think the datatables sort parameters were not updated, you can now not sort based on patrons name To recreate: 1 - Have borrowers in your system 2 - Do a 'Check out' search to return several 3 - Note you cannot sort by name column -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15793 Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50634&action=edit Bug 16334 - Cannot sort checkout search by name This patch corrects the DataTable configuration of the table of patrons which displays when you search by patron name in circulation. To test, apply the patch and perform a search by patron name in circulation which will return multiple results. In the table of search results the "Name" column should be sortable, and sorted by default. Also changed: "Cardnumber" table header changed to "Card number." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336 [Bug 16336] UX of holds patron search with long lists of results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50634|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 50635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50635&action=edit Bug 16334 - Cannot sort checkout search by name This patch corrects the DataTable configuration of the table of patrons which displays when you search by patron name in circulation. To test, apply the patch and perform a search by patron name in circulation which will return multiple results. In the table of search results the "Name" column should be sortable, and sorted by default. Also changed: "Cardnumber" table header changed to "Card number." Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #1)
In the table of search results the "Name" column should be sortable, and sorted by default.
In 3.20.x and 3.22.x the table is sorted by card number. I am not sure we should change this behavior in this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #3)
(In reply to Owen Leonard from comment #1)
In the table of search results the "Name" column should be sortable, and sorted by default.
In 3.20.x and 3.22.x the table is sorted by card number. I am not sure we should change this behavior in this patch.
In 3.18, before the datatables here, the default was surname, I think the use of cardnumber was a change introduced when the search was changed and this reverts it to previous standard -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #4)
(In reply to Jonathan Druart from comment #3)
(In reply to Owen Leonard from comment #1)
In the table of search results the "Name" column should be sortable, and sorted by default.
In 3.20.x and 3.22.x the table is sorted by card number. I am not sure we should change this behavior in this patch.
In 3.18, before the datatables here, the default was surname, I think the use of cardnumber was a change introduced when the search was changed and this reverts it to previous standard
I am ok to change the behavior but on its own bug report, to get more opinions and highlight the change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #3)
In 3.20.x and 3.22.x the table is sorted by card number. I am not sure we should change this behavior in this patch.
Jonathan, in Bug 13926 (now in master) you changed the default sort to be on patron category. Was that intentional? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #6)
(In reply to Jonathan Druart from comment #3)
In 3.20.x and 3.22.x the table is sorted by card number. I am not sure we should change this behavior in this patch.
Jonathan, in Bug 13926 (now in master) you changed the default sort to be on patron category. Was that intentional?
I dont' think so -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|16336 | Depends on| |16336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336 [Bug 16336] UX of holds patron search with long lists of results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Instead of resubmitting this patch, I'm incorporating a corrected fix into Bug 16336, "UX of holds patron search with long lists of results." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16334 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org