[Bug 11003] New: intranet cart email broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Bug ID: 11003 Summary: intranet cart email broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com A call to yuiToolbar breaks js code on the cart page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21846&action=edit Bug 11003: intranet cart email broken A call to yuiToolbar breaks js code on the cart page. Test plan: - add some biblio to your cart - open the cart - try to send the cart, the url is basket/sendbasket.pl?bib_list=null - apply the patch - reload the cart view - try to send the cart, the url is now basket/sendbasket.pl?bib_list=X,Y,Z -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9218 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi@cineca.it --- Comment #2 from Paola Rossi <paola.rossi@cineca.it> --- I think that the situation is modified by bug 9218 "intranet cart email broken for non english templates (edit)". After applying 9218, and trying to send the cart, the url is not basket/sendbasket.pl?bib_list=null So I can't sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21846|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21933&action=edit Bug 11003: JS error on the cart page A call to yuiToolbar breaks js code on the cart page. Test plan: - add some biblio to your cart - open the cart - a js error occurs (see it with firebug): ReferenceError: yuiToolbar is not defined - apply the patch - retry and verify the error does not appear anymore. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Paola, Yes you are right, but the js error still occurs, it should be fixed. I updated the path. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|intranet cart email broken |JS error on the cart page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21933|0 |1 is obsolete| | --- Comment #5 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 21935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21935&action=edit JS error on the cart page Thanks, Jonathan. I confirm that the patch fixes the js error. I sign off the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment : * one-liner * I've checked that there is no other reference to yuiToolbar() in the code * passes koha-qa.pl passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21935|0 |1 is obsolete| | --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 22181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22181&action=edit Bug 11003: JS error on the cart page A call to yuiToolbar breaks js code on the cart page. Test plan: - add some biblio to your cart - open the cart - a js error occurs (see it with firebug): ReferenceError: yuiToolbar is not defined - apply the patch - retry and verify the error does not appear anymore. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Current status: Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22181|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 22184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22184&action=edit [PASSED QA] Bug 11003: JS error on the cart page A call to yuiToolbar breaks js code on the cart page. Test plan: - add some biblio to your cart - open the cart - a js error occurs (see it with firebug): ReferenceError: yuiToolbar is not defined - apply the patch - retry and verify the error does not appear anymore. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org