http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 17664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17664&action=edit Bug 10112 - add test for ./debian/control file to test, apply patch... - run successful test $ perl ./t/00-valid-debian-control-file.t 1..1 ok 1 - parsed ./debian/control file ok - add bad string to ./debian/control file $ sed -i -e '20i -------\' ./debian/control - run failed test $ perl ./t/00-valid-debian-control-file.t 1..1 not ok 1 - parsed ./debian/control file ok -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17664|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 17751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17751&action=edit Bug 10112 - add test for ./debian/control file to test, apply patch... - run successful test $ perl ./t/00-valid-debian-control-file.t 1..1 ok 1 - parsed ./debian/control file ok - add bad string to ./debian/control file $ sed -i -e '20i -------\' ./debian/control - run failed test $ perl ./t/00-valid-debian-control-file.t 1..1 not ok 1 - parsed ./debian/control file ok Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm test fails for me, I think Parse::DebControl might be a new dependency? Do we want to add this dependency for testing an automatically generated file? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |mtj@kohaaloha.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- If we had such tests, they should generate the control file out of the control.in file as Robin does, and test it instead. Because we want to test the control file generation, not the validity of the current file. It could be done on a temporary directory as other tests do. -- You are receiving this mail because: You are watching all bug changes.