[Bug 17299] New: Date due shows incorrect time on SCO.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17299 Bug ID: 17299 Summary: Date due shows incorrect time on SCO. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org For non-hourly loans, date due will by YYYY-MM-DD 23:59:00 Assuming date format MM/DD/YYYY, the date due under the self-checkout should appear as MM/DD/YYYY 11:59:00 PM (Timeformat: 12 hour) or MM/DD/YYYY 23:59:00 (Timeformat 24H). Instead it is showing as either MM/DD/YYYY 12:00 AM (Timeformat: 12 hour) or MM/DD/YYYY 00:00 (Timeformat: 24H) Steps to reproduce: 1/ Enable WebBasedSelfCheck syspref 2/ Check out an item to User A -- Do not use an hourly loan. 3/ Log in to Koha self check ( {OPAC URL}/cgi-bin/koha/sco/sco-main.pl). 4/ Enter User A's cardnumber. See that Checkouts are MM/DD/YYYY 12:00 AM (Timeformat: 12 hour) or MM/DD/YYYY 00:00 (Timeformat: 24H) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17299 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14595 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17299 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17299 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55553&action=edit Bug 17299: Display date due correctly on SCO Unless it's an hourly loan, date due should not display the time part (23:59). Because of bad code in GetPendingIssues, date_due is replaced with a DateTime object and is copied into date_due_sql. We need to use this date_due_sql to correctly display the date due in the sco module. Test plan: 1/ Enable WebBasedSelfCheck syspref 2/ Check out an item to User A -- Do not use an hourly loan. 3/ Log in to Koha self check ( {OPAC URL}/cgi-bin/koha/sco/sco-main.pl). 4/ Enter User A's cardnumber. Without this patch, checkouts are MM/DD/YYYY 12:00 AM (Timeformat: 12 hour) or MM/DD/YYYY 00:00 (Timeformat: 24H) With this patch applied, only the date is displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14016 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17299 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55553|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 55563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55563&action=edit Bug 17299: Display date due correctly on SCO Unless it's an hourly loan, date due should not display the time part (23:59). Because of bad code in GetPendingIssues, date_due is replaced with a DateTime object and is copied into date_due_sql. We need to use this date_due_sql to correctly display the date due in the sco module. Test plan: 1/ Enable WebBasedSelfCheck syspref 2/ Check out an item to User A -- Do not use an hourly loan. 3/ Log in to Koha self check ( {OPAC URL}/cgi-bin/koha/sco/sco-main.pl). 4/ Enter User A's cardnumber. Without this patch, checkouts are MM/DD/YYYY 12:00 AM (Timeformat: 12 hour) or MM/DD/YYYY 00:00 (Timeformat: 24H) With this patch applied, only the date is displayed Followed test plan, works as expected. Signed-off-by: Marc <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17299 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17299 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17299 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55563|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55584&action=edit Bug 17299: Display date due correctly on SCO Unless it's an hourly loan, date due should not display the time part (23:59). Because of bad code in GetPendingIssues, date_due is replaced with a DateTime object and is copied into date_due_sql. We need to use this date_due_sql to correctly display the date due in the sco module. Test plan: 1/ Enable WebBasedSelfCheck syspref 2/ Check out an item to User A -- Do not use an hourly loan. 3/ Log in to Koha self check ( {OPAC URL}/cgi-bin/koha/sco/sco-main.pl). 4/ Enter User A's cardnumber. Without this patch, checkouts are MM/DD/YYYY 12:00 AM (Timeformat: 12 hour) or MM/DD/YYYY 00:00 (Timeformat: 24H) With this patch applied, only the date is displayed Followed test plan, works as expected. Signed-off-by: Marc <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17299 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17299 --- Comment #5 from Barton Chittenden <barton@bywatersolutions.com> --- (In reply to Kyle M Hall from comment #4)
Pushed to master for 16.11, thanks Jonathan!
I would definitely like to see this back-ported -- as far as I can tell, it's a one line fix with no dependencies, and the bug causes Koha to give incorrect information to patrons. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org