[Bug 33620] New: Don't show patron-privacyguarantor/patron-privacy_guarantor_fines if borrowerRelationship is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Bug ID: 33620 Summary: Don't show patron-privacyguarantor/patron-privacy_guarantor_fines if borrowerRelationship is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com On the patron detail screen there are two list items: -Show checkouts to guarantor -Show charges to guarantor I end up hiding these with CSS often. It would be better if these simply did not show if borrowerRelationship is empty. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150257&action=edit Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty To test: 1. Apply patch 2. Have some values in borrowerRelationship. 3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:' 4. Now empty borrowerRelationship. 5. Visit the patron detail page again and you should no longer see either of those fields. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150257|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 150297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150297&action=edit Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty To test: 1. Apply patch 2. Have some values in borrowerRelationship. 3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:' 4. Now empty borrowerRelationship. 5. Visit the patron detail page again and you should no longer see either of those fields. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #3 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described, thanks for the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150297|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 153188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153188&action=edit Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty To test: 1. Apply patch 2. Have some values in borrowerRelationship. 3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:' 4. Now empty borrowerRelationship. 5. Visit the patron detail page again and you should no longer see either of those fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Sally from comment #3)
Works as described, thanks for the patch.
You forgot your signoff line, Sally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153188|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155654&action=edit Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty To test: 1. Apply patch 2. Have some values in borrowerRelationship. 3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:' 4. Now empty borrowerRelationship. 5. Visit the patron detail page again and you should no longer see either of those fields. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 --- Comment #7 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- (In reply to Marcel de Rooy from comment #5)
(In reply to Sally from comment #3)
Works as described, thanks for the patch.
You forgot your signoff line, Sally.
I don't think I did? I signed off on a sandbox. You can see my sign off line on comment #2: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620#c2 It looks like Lucas updated the patch again after my sign off in comments 2 and 3, and added a new patch on comment 4 a few months later? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org