[Bug 30030] New: Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Bug ID: 30030 Summary: Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails randomly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org See https://jenkins.koha-community.org/view/master/job/Koha_Master_U18/lastCompl... not ok 9 - On invalid "is going to expire" date, the method should not crash with "Invalid local time for date in time zone" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Test |Test |t/db_dependent/Koha/Patrons |t/db_dependent/Koha/Patrons |.t is_going_to_expire fails |.t is_going_to_expire fails |randomly |on U18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. 7/44 # Failed test 'On invalid "is going to expire" date, the method should not crash with "Invalid local time for date in time zone"' # at t/db_dependent/Koha/Patrons.t line 348. # got: 'Invalid local time for date in time zone: America/Sao_Paulo # ' # expected: '' # Looks like you failed 1 test of 9. # Failed test 'is_going_to_expire' # at t/db_dependent/Koha/Patrons.t line 353. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Test added by Bug 23079 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29403 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks like it is Bug 29403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 [Bug 29403] dt_from_string should fail if passed more data than expected for the format -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks like this is caused in Koha/DateUtils.pm dt_from_string() by : https://git.koha-community.org/Koha-community/Koha/src/commit/9c6741cbe3cb00... my $floating = 0; ... $dt->set_time_zone($server_tz) unless ( $date_only || $floating ); Call in Koha::Patron->is_going_to_expire is : dt_from_string( $self->dateexpiry, undef, 'floating' ) Maybe we need to set $floating = 1 in case tz = 'floating' ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Did you git bisect already? It's weird that this is only happening on U18. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #5)
Did you git bisect already? Oh I don't know how to do that.
It's weird that this is only happening on U18.
Indeed, maybe a behavior in perl lib that changed, I could not find. DateTime lib is a Titanic lib. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29403 |29718 CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It's not 29403, reverting doesn't fix the issue. Bisecting shows that it's commit Bug 29718: Mock the timezone Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 [Bug 29403] dt_from_string should fail if passed more data than expected for the format https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 [Bug 29718] DateTime - our 'iso' is not ISO 8601 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- To have the CI still be meaningful for Ubuntu 18.04 (until 2023-04-26) for 22.05 and in the future 22.11, should 29718 be reverted until then? (assuming it's possible) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #9 from Mason James <mtj@kohaaloha.com> --- (In reply to Victor Grousset/tuxayo from comment #8)
To have the CI still be meaningful for Ubuntu 18.04 (until 2023-04-26) for 22.05 and in the future 22.11, should 29718 be reverted until then? (assuming it's possible)
i've updated possible fix here... https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718#c44 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Bug 30030 depends on bug 29718, which changed state. Bug 29718 Summary: DateTime - our 'iso' is not ISO 8601 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Created attachment 138683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138683&action=edit Bug 30030: add 'invalid expiry date' tests, for every timezone this patch aims to add 'invalid expiry date' tests, for every timezone to test... 1/ apply patch 2/ run test root@kohadevbox:/kohadevbox/koha# prove -v t/db_dependent/Koha/Patrons.t ... 1..368 ... ok 32 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Buenos_Aires ok 33 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Catamarca ok 34 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Cordoba ok 35 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Jujuy ok 36 - On invalid "is going to expire" date, the method should not crash: America/Argentina/La_Rioja ok 37 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Mendoza ok 38 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Rio_Gallegos ok 39 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Salta ok 40 - On invalid "is going to expire" date, the method should not crash: America/Argentina/San_Juan ok 41 - On invalid "is going to expire" date, the method should not crash: America/Argentina/San_Luis ok 42 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Tucuman ok 43 - On invalid "is going to expire" date, the method should not crash: America/Argentina/Ushuaia ... All tests successful. Files=1, Tests=44, 84 wallclock secs ( 0.17 usr 0.07 sys + 58.19 cusr 24.35 csys = 82.78 CPU) Result: PASS 3/ confirm all 'invalid expiry date' tests pass OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi --- Comment #11 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Mason, I think the test patch attached doesn't make sense for other timezones as only in Brazil in 2019 the day light saving time was cancelled. Was the patch made so that ubuntu 18 test failure would be prevented somehow? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Bug 30030 depends on bug 29718, which changed state. Bug 29718 Summary: DateTime - our 'iso' is not ISO 8601 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- We don't support ubuntu 18.04 anymore (EOL since 2.5 years) and thus not have CI running on it. I guess this can be closed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org