[Bug 42833] New: Provider SSO icon size must auto
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 Bug ID: 42833 Summary: Provider SSO icon size must auto Initiative type: --- Sponsorship --- status: Product: Koha Version: 26.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mhby87@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Created attachment 200309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200309&action=edit Big icon size not resize like staff login When I active SSO login in KOHA, I used provider Icon URL for login icon. When I click Login into account on OPAC right top, provider icon not resize like staf login or OPAC homepage login. Reffer attachment. Tq -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 Mohd Hafiz Yusoff <mhby87@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Provider SSO icon size must |Provider SSO icon size must |auto |fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 --- Comment #1 from Mohd Hafiz Yusoff <mhby87@gmail.com> --- Created attachment 200379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200379&action=edit Fix size for provider icon at master header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 Mohd Hafiz Yusoff <mhby87@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Mohd Hafiz Yusoff <mhby87@gmail.com> --- In file a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Line 494 Form <img src="[% provider.icon_url | url %]" /> To <img src="[% provider.icon_url | url %]" style="max-height: 20px; max-width: 20px;" /> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 Mohd Hafiz Yusoff <mhby87@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Provider SSO icon size must |Provider SSO icon auto size |fix |at OPAC masterheader and | |must fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 --- Comment #3 from Mohd Hafiz Yusoff <mhby87@gmail.com> --- (In reply to Mohd Hafiz Yusoff from comment #2)
In file a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
Line 494
Form <img src="[% provider.icon_url | url %]" />
To <img src="[% provider.icon_url | url %]" style="max-height: 20px; max-width: 20px;" />
For masterheader only i think it nice to see if using 40px x 40px. Tq <img src="[% provider.icon_url | url %]" style="max-height: 40px; max-width: 40px;" /> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 --- Comment #4 from Mohd Hafiz Yusoff <mhby87@gmail.com> --- Anyone can update for simple fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 Mohd Hafiz Yusoff <mhby87@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200379|0 |1 is obsolete| | --- Comment #5 from Mohd Hafiz Yusoff <mhby87@gmail.com> --- Created attachment 202313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202313&action=edit Fix size for provider icon at master header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 43819 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Provider SSO icon auto size |Identity provider icon in |at OPAC masterheader and |the OPAC should allow |must fix |flexible sizing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Sponsorship status|--- |Sponsored Patch complexity|--- |Trivial patch Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 208219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208219&action=edit Bug 42833: Identity provider icon in the OPAC should allow flexible sizing This patch updates the OPAC so that identiy provider icons can be displayed at different sizes instead of just as icons. A common class, "identity_provider" is added to each image. A provider-specific class is added to each "identitiy_provider_<id>." A default style is added which allows the image to fill the available width of the login form. To test apply the patch and rebuild the OPAC CSS. - Go to Administration -> Identity providers and create a new identity provider. It doesn't need to be functional. - Add an icon URL. Because of CSP, a link to a remote image won't load. Save an image (e.g. https://placehold.co/600x400.png) to opac-tmpl/bootstrap/images and enter the icon URL in the form as http://localhost:8080/opac-tmpl/bootstrap/images/600x400.png - Go to the OPAC home page. You should see your ID provider image in the sidebar login form. The image should not overflow the sidebar container. - Test the modal which is shown when you click "Log in to your account" in the header menu. - Test the form which appears when you navigate to a page that asks you to log in, e.g. http://localhost:8080/cgi-bin/koha/opac-user.pl - Test that you can apply a custom style to your image using either the general class (.identity_provider) or a specific one (.identity_provider_<id>) using OPACUserCSS, e.g. .identity_provider { border: 1px solid red; } .identity_provider_2 { border: 1px solid blue; } Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208219|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 208440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208440&action=edit Bug 42833: Identity provider icon in the OPAC should allow flexible sizing This patch updates the OPAC so that identiy provider icons can be displayed at different sizes instead of just as icons. A common class, "identity_provider" is added to each image. A provider-specific class is added to each "identitiy_provider_<id>." A default style is added which allows the image to fill the available width of the login form. To test apply the patch and rebuild the OPAC CSS. - Go to Administration -> Identity providers and create a new identity provider. It doesn't need to be functional. - Add an icon URL. Because of CSP, a link to a remote image won't load. Save an image (e.g. https://placehold.co/600x400.png) to opac-tmpl/bootstrap/images and enter the icon URL in the form as http://localhost:8080/opac-tmpl/bootstrap/images/600x400.png - Go to the OPAC home page. You should see your ID provider image in the sidebar login form. The image should not overflow the sidebar container. - Test the modal which is shown when you click "Log in to your account" in the header menu. - Test the form which appears when you navigate to a page that asks you to log in, e.g. http://localhost:8080/cgi-bin/koha/opac-user.pl - Test that you can apply a custom style to your image using either the general class (.identity_provider) or a specific one (.identity_provider_<id>) using OPACUserCSS, e.g. .identity_provider { border: 1px solid red; } .identity_provider_2 { border: 1px solid blue; } Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Remember to: - Rebuild the CSS: yarn build - Restart everything: restart_all - Clear your browser cache 2. As I haven't set an identity provider before, remember for the domain to set "Allow OPAC" to "Allow" and restart everything: restart_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208440|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 --- Comment #10 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 208441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208441&action=edit Bug 42833: Identity provider icon in the OPAC should allow flexible sizing This patch updates the OPAC so that identiy provider icons can be displayed at different sizes instead of just as icons. A common class, "identity_provider" is added to each image. A provider-specific class is added to each "identitiy_provider_<id>." A default style is added which allows the image to fill the available width of the login form. To test apply the patch and rebuild the OPAC CSS. - Go to Administration -> Identity providers and create a new identity provider. It doesn't need to be functional. - Add an icon URL. Because of CSP, a link to a remote image won't load. Save an image (e.g. https://placehold.co/600x400.png) to opac-tmpl/bootstrap/images and enter the icon URL in the form as http://localhost:8080/opac-tmpl/bootstrap/images/600x400.png - Go to the OPAC home page. You should see your ID provider image in the sidebar login form. The image should not overflow the sidebar container. - Test the modal which is shown when you click "Log in to your account" in the header menu. - Test the form which appears when you navigate to a page that asks you to log in, e.g. http://localhost:8080/cgi-bin/koha/opac-user.pl - Test that you can apply a custom style to your image using either the general class (.identity_provider) or a specific one (.identity_provider_<id>) using OPACUserCSS, e.g. .identity_provider { border: 1px solid red; } .identity_provider_2 { border: 1px solid blue; } Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Mohd Hafiz Yusoff <mhby87@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|26.05 |Main --- Comment #11 from David Nind <david@davidnind.com> --- Changes made: 1. Status: changed from an enhancement to a normal bug (it is something not working correctly in the OPAC). 2. Version: 26.05 to Main, as the issue is present in Main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42833 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jacob.omara@openfifth.co.uk |y.org | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org