[Bug 19372] New: Selecti MARC framework doesn' t work when adding to basket from an external source
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Bug ID: 19372 Summary: Selecti MARC framework doesn't work when adding to basket from an external source Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mglavica@ffzg.hr QA Contact: testopia@bugs.koha-community.org In acquisitions, when adding items to basket from an external source there is an option to select MARC framework. No matter what we choose, the record is created in default framework. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15801 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Summary|Selecti MARC framework |Selecting MARC framework |doesn't work when adding to |doesn't work when adding to |basket from an external |basket from an external |source |source CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|minor |normal --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by bug 15801. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 [Bug 15801] Move the framework related code to Koha::BiblioFramework[s] - part 2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67398&action=edit Bug 19372: (bug 15801 follow-up) pass selected frameworkcode to the template Bug 15801 removes the 2 lines that were necessary to retrieve the framework selected by the user and pass it to the template. All bibliographic records created when adding an order to the basket using an external source used the default framework. Test plan: Add an order to a basket from an external source Select another framework than the default one => Without this patch, whatever the framework you picked, the default one is used => With this patch applied the framework code you will pick will be used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Upping severity a bit as it impacts stable releases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Marijana Glavica <mglavica@ffzg.hr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67398|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 67429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67429&action=edit Bug 19372: (bug 15801 follow-up) pass selected frameworkcode to the template Bug 15801 removes the 2 lines that were necessary to retrieve the framework selected by the user and pass it to the template. All bibliographic records created when adding an order to the basket using an external source used the default framework. Test plan: Add an order to a basket from an external source Select another framework than the default one => Without this patch, whatever the framework you picked, the default one is used => With this patch applied the framework code you will pick will be used Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Marijana Glavica <mglavica@ffzg.hr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67429|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 67430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67430&action=edit Bug 19372: (bug 15801 follow-up) pass selected frameworkcode to the template Bug 15801 removes the 2 lines that were necessary to retrieve the framework selected by the user and pass it to the template. All bibliographic records created when adding an order to the basket using an external source used the default framework. Test plan: Add an order to a basket from an external source Select another framework than the default one => Without this patch, whatever the framework you picked, the default one is used => With this patch applied the framework code you will pick will be used Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 --- Comment #8 from Marijana Glavica <mglavica@ffzg.hr> --- Sorry, I am not sure how this duplicate testing and signing-off has happened. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67430|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67443&action=edit Bug 19372: (bug 15801 follow-up) pass selected frameworkcode to the template Bug 15801 removes the 2 lines that were necessary to retrieve the framework selected by the user and pass it to the template. All bibliographic records created when adding an order to the basket using an external source used the default framework. Test plan: Add an order to a basket from an external source Select another framework than the default one => Without this patch, whatever the framework you picked, the default one is used => With this patch applied the framework code you will pick will be used Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable Patch complexity|--- |Trivial patch --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31298 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35927 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35927 [Bug 35927] Selecting MARC framework again doesn't work when adding to basket from an external source -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org