[Bug 33641] New: We should record return branch in old checkouts (oldissues)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Bug ID: 33641 Summary: We should record return branch in old checkouts (oldissues) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org See bug 33010 - the intention is to list the checkouts returned at current branch, but we only store this info in statistics. It would be handy to keep this info in the issue/oldissues tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 [Bug 33010] CheckinSlip doesn't return checkins if checkout branch and checkin branch differ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #1 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- +1, This would be helpful data and is not particularly accessible with the current structure. I'm currently trying to write a query to determine how often our items are returned somewhere other than the branch at which they were checked out and the manner in which we record things is making is very difficult. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #2 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 170105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170105&action=edit Bug 33641: DB Update Added return_branch to issues table and old_issues table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170106&action=edit Bug 33641: DB update -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170107&action=edit Bug 33641: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170105|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170106|0 |1 is obsolete| | --- Comment #5 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 170108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170108&action=edit Bug 33641: DB update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170107|0 |1 is obsolete| | --- Comment #6 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 170109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170109&action=edit Bug 33641: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #7 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 170110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170110&action=edit Bug 33641: Code changes To test: 1. Apply patch, restart_all, updatedatabase 2. Check out an item to a patron 3. Query the database - select return_branch from issues; should return NULL - select branchcode from issues; should return the branchcode of the library you checkout the item out from - select return_branch from old_issues; should match the branchcode from the previous query -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #8 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 170111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170111&action=edit Bug 33641: Unit Tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170108|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 170138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170138&action=edit Bug 33641: DB update Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170109|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 170139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170139&action=edit Bug 33641: DO NOT PUSH - Schema Updates Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170110|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 170140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170140&action=edit Bug 33641: Code changes To test: 1. Apply patch, restart_all, updatedatabase 2. Check out an item to a patron 3. Query the database - select return_branch from issues; should return NULL - select branchcode from issues; should return the branchcode of the library you checkout the item out from - select return_branch from old_issues; should match the branchcode from the previous query Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170111|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 170141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170141&action=edit Bug 33641: Unit Tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18994 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Summary|We should record return |We should record return |branch in old checkouts |library in old checkouts |(oldissues) |(oldissues) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- I'm not sure we really need the 'return_branch' in the issues table at all.. it will always be empty.. could we not just add it to the old_issues table only? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170138|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173562&action=edit Bug 33641: DB update Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170139|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173563&action=edit Bug 33641: DO NOT PUSH - Schema Updates Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170140|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173564&action=edit Bug 33641: Code changes To test: 1. Apply patch, restart_all, updatedatabase 2. Check out an item to a patron 3. Query the database - select return_branch from issues; should return NULL - select branchcode from issues; should return the branchcode of the library you checkout the item out from - select return_branch from old_issues; should match the branchcode from the previous query Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170141|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173565&action=edit Bug 33641: Unit Tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- OK.. It makes UNION queries a tad simpler.. No regressions found, nice enhancement. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a rather small patch, any chance we could turn return_branch into checkin_library? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #19)
This is a rather small patch, any chance we could turn return_branch into checkin_library?
Hm, I didn't mean to block this with my comment. Would anyone be willing to adopt? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173562|0 |1 is obsolete| | Attachment #173563|0 |1 is obsolete| | Attachment #173564|0 |1 is obsolete| | Attachment #173565|0 |1 is obsolete| | --- Comment #21 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174510&action=edit Bug 33641: DB update Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #22 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174511&action=edit Bug 33641: Code changes To test: 1. Apply patch, restart_all, updatedatabase 2. Check out an item to a patron 3. Query the database - select return_branch from issues; should return NULL - select branchcode from issues; should return the branchcode of the library you checkout the item out from - select return_branch from old_issues; should match the branchcode from the previous query Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #23 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174512&action=edit Bug 33641: Unit Tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #24 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174513&action=edit Bug 33641: (follow-up) Change return_branch to checkin_library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #25 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174514&action=edit Bug 33641: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, this needs some more work: ALTER TABLE old_issues ADD COLUMN checkin_library varchar(10) DEFAULT NULL COMMENT 'foreign key, linking to the branches table for the location the item was returned' AFTER returndate There is no FK or link, it's only adding the column. I have adapted the comments accordingly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we broke tons of tests here. Please check on Jenkins, especially api related ones. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #29 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174536&action=edit Bug 33641: (follow-up) Add field to api spec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #30 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Nick Clemens (kidclamp) from comment #29)
Created attachment 174536 [details] [review] Bug 33641: (follow-up) Add field to api spec
Asking for Tomas' input, this fixes tests, but I am sure is incomplete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174536|0 |1 is obsolete| | --- Comment #31 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 174538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174538&action=edit Bug 33641: (follow-up) Add field to api spec Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Edit: I changed the attribute name to match our guidelines (tcohen) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up patch "Add field to api spec" picked for main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #33 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174569&action=edit Bug 33641: Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174569|0 |1 is obsolete| | --- Comment #34 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174570&action=edit Bug 33641: Fix StoreLastBorrower.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174570|0 |1 is obsolete| | --- Comment #35 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174571&action=edit Bug 33641: Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174571|0 |1 is obsolete| | --- Comment #36 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174572&action=edit Bug 33641: (Follow-up) Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174572|0 |1 is obsolete| | --- Comment #37 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174573&action=edit Bug 33641: (Follow-up) Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174573|0 |1 is obsolete| | --- Comment #38 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174574&action=edit Bug 33641: (Follow-up) Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We still need fixes for indexer.t that should also mock userenv. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174574|0 |1 is obsolete| | --- Comment #40 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174584&action=edit Bug 33641: (Follow-up) Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Matt Blenkinsop from comment #40)
Created attachment 174584 [details] [review] Bug 33641: (Follow-up) Fix unit tests
Sorry, I forgot to note here that I had already pushed "Fix unit tests". Can you please provide the additional change separately? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #42 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174585&action=edit Bug 33641: (Follow-up) Fix Indexer.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Matt Blenkinsop from comment #42)
Created attachment 174585 [details] [review] Bug 33641: (Follow-up) Fix Indexer.t
Pushed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #44 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |david@davidnind.com --- Comment #45 from David Nind <david@davidnind.com> --- No user interface changes, not covered in the manual - no update required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org