[Bug 40127] New: JS error on biblio detail page when there are no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Bug ID: 40127 Summary: JS error on biblio detail page when there are no items Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com "build_items_table is not defined" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183185&action=edit Bug 40127: Move build_items_table outside of document.ready So it's not delayed and we catch have the error in the Cypress test. Otherwise the error appear too late (in the after each) and the test does not fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183186&action=edit Bug 40127: Add a Cypress test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183187&action=edit Bug 40127: Remove JS error from the biblio detail page when no items "build_items_table is not defined" We should not try to build the items table if there are no items. Test plan: Go to the bibliographic detail page of a biblio without items You should not see errors in the browser's console Go to the bibliographic detail page of a biblio with items You should not see errors in the browser's console The table should be displayed and the different features should work as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183185|0 |1 is obsolete| | Attachment #183186|0 |1 is obsolete| | Attachment #183187|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183188&action=edit Bug 40127: Move build_items_table outside of document.ready So it's not delayed and we catch have the error in the Cypress test. Otherwise the error appear too late (in the after each) and the test does not fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183189&action=edit Bug 40127: Add a Cypress test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183190&action=edit Bug 40127: Remove JS error from the biblio detail page when no items "build_items_table is not defined" We should not try to build the items table if there are no items. Test plan: Go to the bibliographic detail page of a biblio without items You should not see errors in the browser's console Go to the bibliographic detail page of a biblio with items You should not see errors in the browser's console The table should be displayed and the different features should work as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183188|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 183228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183228&action=edit Bug 40127: Move build_items_table outside of document.ready So it's not delayed and we catch have the error in the Cypress test. Otherwise the error appear too late (in the after each) and the test does not fail Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183189|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 183229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183229&action=edit Bug 40127: Add a Cypress test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183190|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 183230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183230&action=edit Bug 40127: Remove JS error from the biblio detail page when no items "build_items_table is not defined" We should not try to build the items table if there are no items. Test plan: Go to the bibliographic detail page of a biblio without items You should not see errors in the browser's console Go to the bibliographic detail page of a biblio with items You should not see errors in the browser's console The table should be displayed and the different features should work as before Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a JavaScript release notes| |error on bibliographic | |record pages in the staff | |interface, where the record | |has no items. Version|24.11 |Main Status|Needs Signoff |Signed Off CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate, | |rel_25_05_candidate, | |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183229|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183283&action=edit Bug 40127: Add a Cypress test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Removed ".only" from cypress test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40168 [Bug 40168] afterEach not called in KohaTable cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40170 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40170 [Bug 40170] Replace cypress-mysql with mysql2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|40170 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40170 [Bug 40170] Replace cypress-mysql with mysql2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183228|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 183452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183452&action=edit Bug 40127: Move build_items_table outside of document.ready So it's not delayed and we catch have the error in the Cypress test. Otherwise the error appear too late (in the after each) and the test does not fail Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183230|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 183453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183453&action=edit Bug 40127: Remove JS error from the biblio detail page when no items "build_items_table is not defined" We should not try to build the items table if there are no items. Test plan: Go to the bibliographic detail page of a biblio without items You should not see errors in the browser's console Go to the bibliographic detail page of a biblio with items You should not see errors in the browser's console The table should be displayed and the different features should work as before Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183283|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 183454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183454&action=edit Bug 40127: Add a Cypress test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 --- Comment #16 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x for 25.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.02 |25.11.00,25.05.02,24.11.08 released in| | --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40544 [Bug 40544] Manage bundle button broken? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate, | |rel_25_05_candidate, | |rel_25_11_candidate | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #18 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- 39987 - Batch item deletion breadcrumb uses wrong link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 --- Comment #20 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #21 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org