https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15956, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9848, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9845, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9842, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9838 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #2)

From bug 9848 comment 9

""" They arnt a test suite they are a reminder that one needs to be written """

But then it seems like Adrien was running them at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848#c0? I wonder if there is anyone at BibLibre who can speak to that... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 151960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151960&action=edit Bug 26700: Remove unused C4/SIP/t directory This patch removes the unused C4/SIP/t directory. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151960|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151965&action=edit Bug 26700: Remove unused C4/SIP/t directory This patch removes the unused C4/SIP/t directory. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #7)

You just remove, not move. Did you check if there are some useful tests that we do not want to loose here? And they probably need quite a bit of editing too if we want to move them..

How did you verify that they are not being used?

I raised this ticket and linked to existing tickets over 2 years ago, and no one ever replied. These tests aren't run by the official Koha test suite. If anyone uses them in an unofficial capacity, I'm sure they'll raise a ticket to say so after they're removed. (If they're running them, they're probably also someone with the capacity to do the work of editing them and moving them into the t/ or xt/ directories.) As Jonathan noted in 2021, Colin also commented in 2015 that he couldn't determine that anyone ran these tests or that anyone felt confident in working on them. Since we have the git history and it wouldn't affect production installations, I think we can remove these tests, and then we'll really be able to verify if anyone uses them. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151966|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 152296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152296&action=edit Bug 26700: Remove occurrences in Makefile.PL As well as other 2 non existing paths Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #8)

Since we have the git history and it wouldn't affect production installations, I think we can remove these tests, and then we'll really be able to verify if anyone uses them.

A few weeks later, we are all ready to go :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.